Inconsistent UI when creating rooms in space I don't have permission to do so

[michaelkaye]

Steps to reproduce

I do not have permission to add rooms or create rooms in the given space.

When using the + by the list of rooms, i see greyed out UI for creating a room in the space:

When using the + by the space, i do not see greyed out UI:

Additionally, if i do click "add room to space", it takes me to "Create a room" not "add a room":

And then when i complete the operation, i get the generic "it broke":

I think this second part might be related to #20222 "add room turning into create room" - but the lack of permission checks which got me into that UI at all is the core of this issue.

Outcome

What did you expect?

Consistent greyed out UI

What happened instead?

Only one of the two routes greyed out the option, and the other route took me to an error.

Operating system

Linux ubuntu

Application version

Element version: 1.10.1 Olm version: 3.2.8

How did you install the app?

No response

Homeserver

ems

Will you send logs?

No

[t3chguy]

Additionally, if i do click "add room to space", it takes me to "Create a room" not "add a room":

is a bug and already fixed on develop

[t3chguy]

Only one of the two routes greyed out the option, and the other route took me to an error.

This is also fixed on develop already