Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redaction wrongly shown as continuation of previous sender #21030

Closed
t3chguy opened this issue Feb 10, 2022 · 4 comments · Fixed by matrix-org/matrix-react-sdk#7797
Closed

Redaction wrongly shown as continuation of previous sender #21030

t3chguy opened this issue Feb 10, 2022 · 4 comments · Fixed by matrix-org/matrix-react-sdk#7797
Assignees
@t3chguy
Labels
A-Redaction A-Timeline O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Low/no impact on users T-Defect X-Regression X-Release-Blocker Z-t3chguy

Comments

@t3chguy
Copy link
Member

t3chguy commented Feb 10, 2022 •
edited
Loading

image

This Message deleted was a message from Matthew, deleted by Matthew
@germain-gg germain-gg added O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Low/no impact on users labels Feb 11, 2022
@SimonBrandner SimonBrandner mentioned this issue Feb 13, 2022
Closed
@SimonBrandner
Copy link
Contributor

Possibly related to #21055

@SimonBrandner
Copy link
Contributor

SimonBrandner commented Feb 13, 2022 •
edited
Loading

Steps to repro:

  1. Send a message as User A
  2. Send a message as User B
  3. Send a second message as User B
  4. Redact B's first message
  5. Note how it looks like A sent it.

@t3chguy
Copy link
Member Author

t3chguy commented Feb 14, 2022

I do not believe this is a release blocker for 1.10.2 but only for releases thereafter, the MELS/ELS/GELS changeset was after the RC matrix-org/matrix-react-sdk@714136d

@t3chguy t3chguy self-assigned this Feb 14, 2022
@t3chguy t3chguy mentioned this issue Feb 14, 2022
Merged
@dbkr
Copy link
Member

dbkr commented Feb 14, 2022

Confirmed this is not a problem on the 1.10.2 (v3.40.0) release branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t3chguy t3chguy

Labels
A-Redaction A-Timeline O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Low/no impact on users T-Defect X-Regression X-Release-Blocker Z-t3chguy
Projects
None yet
Milestone
No milestone
4 participants
@germain-gg @dbkr @t3chguy @SimonBrandner