Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Right panel thread view time stamp overlaps message text #21084

Closed
ohporter opened this issue Feb 14, 2022 · 10 comments
Closed

Right panel thread view time stamp overlaps message text #21084

ohporter opened this issue Feb 14, 2022 · 10 comments
Assignees
Labels
A-Threads O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Needs-Design Z-Labs

Comments

@ohporter
Copy link

ohporter commented Feb 14, 2022

Steps to reproduce

  1. Where are you starting? What can you see?

Timeline open on a room with a preexisting thread consisting of multiple messages.

  1. What do you click?

I click on the thread view button in the upper right.

Outcome

What did you expect?

I expect to see the message with timestamps separated from the message text like in the timeline view of messages.

What happened instead?

The message timestamp slightly overlaps the message text as shown in the following image.

image

Operating system

Debian 11

Browser information

Google Chrome Version 98.0.4758.80 (Official Build) (64-bit)

URL for webapp

Element version: 1.10.2 Olm version: 3.2.8

Application version

Element version: 1.10.2 Olm version: 3.2.8

Homeserver

Synapse 1.52.0

Will you send logs?

No

@dbkr dbkr added A-Threads O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist labels Feb 14, 2022
@HarHarLinks
Copy link
Contributor

Browser information
Version 98.0.4758.80 (Official Build) (64-bit)

OK but which browser? 😄

@ohporter
Copy link
Author

Browser information
Version 98.0.4758.80 (Official Build) (64-bit)

OK but which browser? smile

Chrome..fixed above.

@t3chguy
Copy link
Member

t3chguy commented Mar 10, 2022

image

This issue is not exclusive to right panel or threads timelines, with certain font sizes it can happen in the main timeline too. Needs some design input on how we handle this, whether to always reserve a bit more space to have enough for AM/PM, to do it conditionally, to scale based on font-size, etc

@germain-gg
Copy link
Contributor

159279551-a247d58a-b4bf-4d1e-b75e-3df537d24cfa

On hover, the following can happen. @janogarcia would be great to have your input on how to cater for all those cases?

@janogarcia
Copy link

@gsouquet This is mostly an issue with the current implementation, which deviates from the design spec in some places. It should be solved by fixing the issues I shared here: #21502 👍

@germain-gg
Copy link
Contributor

Closing in favour of #21502

@t3chguy
Copy link
Member

t3chguy commented Apr 13, 2022

#21502 doesn't currently cover this and its already a mess so would prefer splitting out issues

@t3chguy t3chguy reopened this Apr 13, 2022
@janogarcia
Copy link

@t3chguy With the changes we recently implemented there's plenty room for it (screenshot below from current develop). Moreover, with the new spacing updates that I requested there will be an additional 4px there.

@t3chguy
Copy link
Member

t3chguy commented Apr 19, 2022

@janogarcia as per the above, that space is not enough for larger font sizes which can be chosen in Settings > Appearance

This issue is not exclusive to right panel or threads timelines, with certain font sizes it can happen in the main timeline too. Needs some design input on how we handle this, whether to always reserve a bit more space to have enough for AM/PM, to do it conditionally, to scale based on font-size, etc

@janogarcia
Copy link

I'm closing this one as it's been addressed in a separate issue/PR as mentioned above.


Text size: 15px (default)

Element | 🧪 Playground Non-encrypted

Text size: 16px

Element | 🧪 Playground Non-encrypted

Text size: 18px

Element | 🧪 Playground Non-encrypted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Threads O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Needs-Design Z-Labs
Projects
None yet
Development

No branches or pull requests

7 participants