Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File uploads timeout too rapidly and can't be retried #21343

Open
ara4n opened this issue Mar 7, 2022 · 1 comment
Open

File uploads timeout too rapidly and can't be retried #21343

ara4n opened this issue Mar 7, 2022 · 1 comment
Labels
A-File-Upload Attachments and file uploads A-Room-View O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect

Comments

@ara4n
Copy link
Member

ara4n commented Mar 7, 2022

Steps to reproduce

  1. Simulate bad network connectivity
  2. Try to upload a file
  3. Get frustrated

Outcome

What did you expect?

I expect the file upload to keep trying to upload until i have good connectivity - or at least queue up with a retry button like my other messages do.

What happened instead?

Instead, it gives up after ~30s and then deletes itself from the timeline, meaning i have no retry button, and i have to manually retry to upload again (plus it will now be out of order with my other queued messages). Worse still, you can't tell if the original send even worked, so you end up sending a duplicate (at least in an E2EE room). We're failing our own What Goes Wrong interview question :((

I'm pretty sure this is a regression and that we used to queue these correctly.

Operating system

macOS

Application version

Nightly

How did you install the app?

Nightly

Homeserver

matrix.org

Will you send logs?

No

@ara4n ara4n added the T-Defect label Mar 7, 2022
@germain-gg germain-gg added A-File-Upload Attachments and file uploads A-Room-View O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround X-Regression labels Mar 8, 2022
@t3chguy
Copy link
Member

t3chguy commented Mar 8, 2022

We never had functionality to queue yet-to-be-uploaded messages, that's #9234

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-File-Upload Attachments and file uploads A-Room-View O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Development

No branches or pull requests

3 participants