Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out flood of hidden events when we detect the scrollback is full of it #22080

Closed
jaller94 opened this issue May 5, 2022 · 2 comments
Closed
Labels
A-Location-Sharing O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Z-Labs

Comments

@jaller94
Copy link
Contributor

jaller94 commented May 5, 2022

Your use case

What would you like to do?

Element Web doesn't handle Location streams well if there are no non-hidden events filling the vertical timeline.

I have a room in which I often leave my location stream bot running for hours at a 2 second interval. When I come back it has 3000+ hidden location events that bring Element Web to its knees. Element keeps requesting more events from the homeserver until the vertical browser view is filled with visible events. Usually this means that roughtly 30 events have to be loaded, but when there are 1000s of hidden events in the room's history it takes a very long time until the room is usable and it might fill up the RAM or cause you to get ratelimited.

Join at your own risk: Geo Tracker: Test room

This is similar to element-hq/element-meta#491 but with regular events that Element decides to hide.

Why would you like to do it?

If Element detects that the room history is full of hidden events, e.g. m.beacon, it may decide to not request these from the home`server.

How would you like to achieve it?

Can Element ask to exclude certain events types when asking for more messages?

Have you considered any alternatives?

m.beacon events could become an "edit" their previous event.

Additional context

No response

@andybalaam
Copy link
Contributor

andybalaam commented May 5, 2022

I would argue this is a defect: "when someone has been sharing live location, Element Web freezes when I enter the room". Do you agree @jaller94 ?

@duxovni duxovni added T-Defect S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Uncommon Most users are unlikely to come across this or unexpected workflow and removed T-Enhancement labels May 6, 2022
@t3chguy
Copy link
Member

t3chguy commented May 6, 2022

Duplicate of element-hq/element-meta#491

@t3chguy t3chguy closed this as completed May 6, 2022
@jaller94 jaller94 closed this as not planned Won't fix, can't repro, duplicate, stale Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Location-Sharing O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Z-Labs
Projects
None yet
Development

No branches or pull requests

5 participants