Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Room search feedback UI should not be visible when UIFeature.feedback is false #23327

Closed
jamescl opened this issue Sep 21, 2022 · 0 comments · Fixed by matrix-org/matrix-react-sdk#9305
Assignees
Labels

Comments

@jamescl
Copy link

jamescl commented Sep 21, 2022

Your use case

What would you like to do?

When using the room search functionality, there is a "Results not as expected? Please give feedback." message and Feedback button visible when UIFeature.feedback is false

This is in the search not the expore rooms UI)
image

Why would you like to do it?

To avoid users thinking they are sending feedback to the homeserver when they are actually sending it to the element dev team

How would you like to achieve it?

Using the existing feature flag that stops the feedback popups

Have you considered any alternatives?

No response

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants