Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two notifications show up when you get pinged, rather than one like you would expect. (Element Nightly) #24088

Closed
ArrayBolt3 opened this issue Dec 22, 2022 · 5 comments
Labels
T-Defect X-Needs-Info This issue is blocked awaiting information from the reporter

Comments

@ArrayBolt3
Copy link

Steps to reproduce

  1. Ask for someone to ping you.
  2. Minimize the Element Desktop window.
  3. Wait for them to ping you.

Outcome

What did you expect?

A single notification should pop up.

What happened instead?

Two notifications pop up, one from the message coming into the room as usual, and one from being pinged. The two notifications are identical.

Operating system

Lubuntu 23.04 Alpha

Application version

Element Nightly version: 2022122101 Olm version: 3.2.12

How did you install the app?

From the element.io apt repository

Homeserver

matrix.org

Will you send logs?

Yes

@ArrayBolt3
Copy link
Author

Note that I don't think this used to happen - I believe it happened just after the last update. (I might be wrong there, but I'm pretty sure this is a recent issue, at least.)

@weeman1337
Copy link
Contributor

Thanks for reporting the issue @ArrayBolt3 Don't have a Lubuntu 23.04 but cannot reproduce on latest Ubuntu 22.04.1 LTS. Can you send a screenshot of your notification settings?

@weeman1337 weeman1337 added the X-Needs-Info This issue is blocked awaiting information from the reporter label Jan 2, 2023
@t3chguy
Copy link
Member

t3chguy commented Jan 3, 2023

This might a Synapse issue - matrix-org/synapse#14539

@ArrayBolt3
Copy link
Author

ArrayBolt3 commented Jan 3, 2023

@weeman1337 Screenshot of notification settings:

image

I notice it only happens in certain Matrix rooms - if I'm pinged in a Libera.Chat room, this doesn't seem to happen, but if I'm pinged in a room such as @lubuntu-devel:lubuntu.me, or a semi-private room I'm a part of, I get the doubled notifications. One time it was even four notifications all at once.

@t3chguy That Synapse issue matches my symptoms quite well. Additionally, I noticed when using Thunderbird's Matrix client connected to my lubuntu.me homeserver, messages sent in the #lubuntu-devel:lubuntu.me room appeared doubled. So I think it's very likely that this bug is an unintentional duplicate of the one you linked to.

@t3chguy
Copy link
Member

t3chguy commented Jan 3, 2023

Closing in favour of matrix-org/synapse#14539

The Matrix spec says push rules should be evaluated against all live events, nothing about client doing any de-duplication

@t3chguy t3chguy closed this as completed Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Defect X-Needs-Info This issue is blocked awaiting information from the reporter
Projects
None yet
Development

No branches or pull requests

3 participants