Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quick Search instantly closes (Conduit) #24195

Closed
timokoesters opened this issue Jan 9, 2023 · 2 comments
Closed

Quick Search instantly closes (Conduit) #24195

timokoesters opened this issue Jan 9, 2023 · 2 comments
Labels
A-New-Search-Experience The new search dialog available in Labs O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Z-Spec-Compliance An area where Element doesn't correctly implement the spec

Comments

@timokoesters
Copy link

Steps to reproduce

  1. Log in to conduit server (Feel free to DM me for an account)
  2. Open the Ctrl-K search menu
  3. Type anything

Outcome

  • Search instantly closes
    Element logs:
    Uncaught (in promise) M_UNRECOGNIZED: MatrixError: [404] M_UNRECOGNIZED: Unrecognized request ([https://conduit.koesters.xyz/_matrix/client/unstable/org.mat…s2kw3c5%3Aconduit.rs/hierarchy?suggested_only=false&limit=50](https://conduit.koesters.xyz/_matrix/client/unstable/org.matrix.msc2946/rooms/!MtBkOeeMGE6s2kw3c5%3Aconduit.rs/hierarchy?suggested_only=false&limit=50))
    TypeError: lt is undefined

The network debugger shows that element first tried the v1 /hierarchy, then unstable /hierarchy (both of which currently fail on conduit with a 404 M_UNRECOGNIZED)

Operating system

No response

Browser information

No response

URL for webapp

No response

Application version

No response

Homeserver

No response

Will you send logs?

No
@turt2live
Copy link
Member

turt2live commented Jan 9, 2023 •
edited
Loading

The endpoint was added in Matrix 1.2, meaning under the js-sdk's support policy, we should be supporting it not existing on the server as of writing.

However, a spec release is right around the corner by a matter of weeks: I'm not sure the team will have a chance to add safe fallback code before then, or if the fallback code would be there long enough. Relatedly though, this issue highlights the importance of #22346 - we shouldn't be connecting to homeservers which lack endpoints we need.

@turt2live turt2live added S-Major Severely degrades major functionality or product features, with no satisfactory workaround Z-Spec-Compliance An area where Element doesn't correctly implement the spec O-Uncommon Most users are unlikely to come across this or unexpected workflow A-New-Search-Experience The new search dialog available in Labs labels Jan 9, 2023
@timokoesters
Copy link
Author

Thanks for the quick response. I didn't know about that issue yet and agree with your conclusion and I will close this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-New-Search-Experience The new search dialog available in Labs O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Z-Spec-Compliance An area where Element doesn't correctly implement the spec
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@turt2live @timokoesters