Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GYU: Implement MSC3952 in matrix-react-sdk #24377

Closed
Tracked by #24291
Johennes opened this issue Jan 30, 2023 · 4 comments
Closed
Tracked by #24291

GYU: Implement MSC3952 in matrix-react-sdk #24377

Johennes opened this issue Jan 30, 2023 · 4 comments

Comments

@Johennes
Copy link
Contributor

Johennes commented Jan 30, 2023

Picking up from matrix-org/matrix-react-sdk#9983

@Johennes Johennes mentioned this issue Jan 30, 2023
15 tasks
@Johennes Johennes changed the title Implement MSC3952 in matrix-react-sdk Get your updates: Implement MSC3952 in matrix-react-sdk Feb 1, 2023
@Johennes Johennes changed the title Get your updates: Implement MSC3952 in matrix-react-sdk GYU: Implement MSC3952 in matrix-react-sdk Feb 14, 2023
@clokep
Copy link

clokep commented Mar 17, 2023

There's some ongoing thought of how to deal with when you've been unmentioned via an edit: matrix-org/matrix-react-sdk#9983 (comment); I'm punting this work a bit because it isn't directly related to implement MSC3952.

@clokep
Copy link

clokep commented Mar 22, 2023

Remaining work after matrix-org/matrix-react-sdk#9983:

  • Ensure edited messages appear in red when the user was ever notified for that event (or any of its edits). (See conversation around here.)
  • Better handling of editing a reply (currently the user you're replying to will be dropped from the list of mentioned users).

We might also want to file follow-ups to:

  • Display something if you're "mentioned" by an event, but not in the text (no pill). (Some sort of info tooltip? This needs design help!)
  • Ensure that yourself having a pill doesn't appear red unless the message is also a mention.

@daniellekirkwood
Copy link
Contributor

I think we can go ahead and make some of those items of this ticket (rather than comments). Let's do that together in our next call :)

@clokep
Copy link

clokep commented Mar 24, 2023

Ensure edited messages appear in red when the user was ever notified for that event (or any of its edits). (See conversation around here.)

Ensure that yourself having a pill doesn't appear red unless the message is also a mention.

See #24923.

Better handling of editing a reply (currently the user you're replying to will be dropped from the list of mentioned users).

See #24924.

Display something if you're "mentioned" by an event, but not in the text (no pill). (Some sort of info tooltip? This needs design help!)

See #24927.

I also filed #24925 to properly handle this in the WYSIWYG editor.

@clokep clokep closed this as completed Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants