Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore (eventually) shows empty room list for non-existent server #24481

Closed
JeanPaulLucien opened this issue Feb 10, 2023 · 2 comments
Closed
Assignees
Labels
O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression

Comments

@JeanPaulLucien
Copy link

JeanPaulLucien commented Feb 10, 2023

Steps to reproduce

  1. You should inject feneas.org to your server list in Explore. I have this server there.
  2. Start Element Desktop
  3. Open Explore
  4. Select feneas.org

More detailed and hard way:

  1. Create own Matrix servers
  2. Create rooms. Imitate that rooms with users exist.
  3. Add in server list and ask for rooms.
  4. Exit from Element
  5. Disable server;
  6. Ask for rooms again.

Outcome

What did you expect?

Report that server does not exist. It's correct, because this Matrix server does not exist.

What happened instead?

About 60 seconds of loading, empty room list and nothing that server does not exist.

Operating system

Windows

Application version

1.11.22

How did you install the app?

In-app update

Homeserver

matrix.org

Will you send logs?

No

@JeanPaulLucien JeanPaulLucien changed the title Loop Explore does something too long with non-existed server Feb 10, 2023
@dbkr dbkr added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Feb 13, 2023
@t3chguy
Copy link
Member

t3chguy commented Feb 14, 2023

The 60s timeout seems to be baked into Synapse. We cannot access the directories of other servers directly, we must ask your server to fetch them for us. So we have to await this timeout as we have no way of discerning if your server is being slow or the other server is slow/unavailable.

Eventually times out with
image
but you are right that there is no error just an empty list

image

This is a regression, there was an error in the old room directory modal

@richvdh richvdh changed the title Explore does something too long with non-existed server Explore (eventually) shows empty room list for non-existent server Feb 16, 2023
@t3chguy t3chguy self-assigned this Aug 8, 2023
@t3chguy
Copy link
Member

t3chguy commented Aug 14, 2023

Fixed by matrix-org/matrix-react-sdk#11378

@t3chguy t3chguy closed this as completed Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression
Projects
None yet
Development

No branches or pull requests

3 participants