Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: collapsible images #2466

Closed
0xD9 opened this issue Oct 13, 2016 · 7 comments
Closed

Feature request: collapsible images #2466

0xD9 opened this issue Oct 13, 2016 · 7 comments

Comments

@0xD9
Copy link

0xD9 commented Oct 13, 2016

Please add a feature to collapse / minimize images that are attached in-line in the chat log. The ability to hide an image that someone has posted would be very useful.

@ArdaXi
Copy link

ArdaXi commented Nov 27, 2016

I was just looking at how to implement this. I've seen other chat clients that solve this by having an "uploaded an image" line above the actual image, with an arrow next to the line that can be clicked to toggle a collapse state.

In matrix-react there is such a line in EventTile, but that only works if the first message someone sends is an image, ie. that line does not appear above every image, only the first someone sends if they didn't send text first.

Would it be an idea to either move that line to the MFileBody/MImageBody, or to move the download link to the top instead of the bottom and adding it onto that? Mostly looking for UI/UX feedback.

@aidalgol
Copy link
Contributor

aidalgol commented Jul 9, 2017

This would be extremely useful for when at work (or school, or out in public on a laptop) and someone posts an even vaguely inappropriate image.

@lnxwalt
Copy link

lnxwalt commented Jul 14, 2019

Is your suggestion related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

I was in a room where someone posted a very inappropriate image. I discovered that I had no way in Riot-web to hide the image or the message which contains it. It was frustrating to have to wait for the user to delete their post or an admin/mod to intervene. Please add this on the client level.

Fortunately, after myself and another person in the room requested its removal, the original poster deleted their post.

Describe the solution you'd like
A clear and concise description of what you want to happen.

I would like every post and attachment to be displayed with the tools that allow the viewer to hide that post or attachment. "Ignore User" is not always the correct answer if one only wishes to hide a single post or image by that user. Clicking the "..." would allow access to the hiding function.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

None.

Additional context
Add any other context or screenshots about the feature request here.

None.

@weeman1337
Copy link
Contributor

weeman1337 commented Jan 17, 2021

I investigated on this one. Also regarding the existing PR.

Why not just do it like another popular messaging app? Here are some screenshots:

If changing the element order (by putting the name at the top and add the collapse function while keeping the download link) maybe this one should clean up the image view a bit more. For example it is very confusing to me to click "decrypt" if I can already see this image and then have a "download" action.

My suggestion would be:

2021-01-17_10-33

Notes:

  • In my opinion the download function collides with the collapse function
  • Maybe the "download" action should be added to the "actions" either at a) or b)
  • Why not combine "decrypt" and "download" transparently and just name it "download"?
    • As mentioned above: I already see the image; what is the point of "decrypting" it? It is just confusing.
  • Then the image name could be moved above the image and can work as a collapse toggle
  • → doesn't require more space and adds the requested feature while having a proper usability

@keremgocen
Copy link

I'd like to help on this one but it does not seem clear yet what should be the implementation? Is this still being discussed, or is there a flight checklist an outsider like me can look at and implement without help?

@SimonBrandner
Copy link
Contributor

@keremgocen, there already is a PR to fix this. I believe it's blocked on design or similar

@SimonBrandner SimonBrandner removed Easy Help Wanted Extra attention is needed labels Aug 26, 2021
@turt2live
Copy link
Member

Per my comment on the PR, we believe the core concerns raised here have been resolved through other changes. If folks feel that is untrue or would still like to see this, then please open a fresh issue so we can engage the design and product teams more efficiently. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests