Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove list style from Percy test of a reply chain on timeline.spec.ts #24969

Closed
luixxiul opened this issue Mar 27, 2023 · 2 comments
Closed
Labels
A-Developer-Experience A-Testing Testing, code coverage, etc. O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Tolerable Low/no impact on users T-Defect

Comments

@luixxiul
Copy link

luixxiul commented Mar 27, 2023

Steps to reproduce

  1. Check Percy snapshots below for Fix flaky Percy tests of ReplyChain matrix-org/matrix-react-sdk#10450:

Outcome

What did you expect?

The list style should not be applied in the same way as on the main timeline.

What happened instead?

It is applied as below:

Screenshot from 2023-03-27 19-30-40

Please note that the position of the disc differs among the browsers. Above is the snapshot on Safari. The disc does not appear on Firefox.

Operating system

No response

Browser information

Chrome (Edge) and Safari

URL for webapp

No response

Application version

No response

Homeserver

No response

Will you send logs?

No

@luixxiul
Copy link
Author

This one is hard to spot, but there is a disc covered by the avatar H on the first line.

Screenshot from 2023-03-28 05-16-27

@germain-gg germain-gg added A-Developer-Experience S-Tolerable Low/no impact on users O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Mar 28, 2023
@Johennes Johennes added the A-Testing Testing, code coverage, etc. label Oct 16, 2023
@t3chguy
Copy link
Member

t3chguy commented Apr 19, 2024

Percy tests are gone

@t3chguy t3chguy closed this as completed Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Developer-Experience A-Testing Testing, code coverage, etc. O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Tolerable Low/no impact on users T-Defect
Projects
None yet
Development

No branches or pull requests

4 participants