You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
matrix-org/matrix-react-sdk#10441 has added E2E tests of the audio player (audio-player.spec.ts). The test includes Percy snapshots to check a visual regression of mx_EventTile_last on which the player is rendered, but since the repository has run out of the quota, the PR was integrated without checking whether Percy would take snapshots as expected. We should check it once the quota is restored later this month.
Looks like seek bars are not there for any of them (searched for „audio“).
I would still close this issue. The purpose of Percy snapshots is to be aware of the changes. That can also mean the current state may probably not the correct one.
Looks like seek bars are not there for any of them
The seek bars have been hidden intentionally due to #24898 (here is a comment on the test).
The intention of the issue was to add a reminder to check the snapshot, since the PR has been merged without confirming whether snapshots of the mx_EventTile_last were properly captured. This link lists them, and it seems they are captured as expected 👍
matrix-org/matrix-react-sdk#10441 has added E2E tests of the audio player (
audio-player.spec.ts
). The test includes Percy snapshots to check a visual regression ofmx_EventTile_last
on which the player is rendered, but since the repository has run out of the quota, the PR was integrated without checking whether Percy would take snapshots as expected. We should check it once the quota is restored later this month.ref: #24747 and #22542
The text was updated successfully, but these errors were encountered: