Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirm Percy snapshots for audio-player.spec.ts #25055

Closed
luixxiul opened this issue Apr 6, 2023 · 2 comments
Closed

Confirm Percy snapshots for audio-player.spec.ts #25055

luixxiul opened this issue Apr 6, 2023 · 2 comments

Comments

@luixxiul
Copy link

luixxiul commented Apr 6, 2023

matrix-org/matrix-react-sdk#10441 has added E2E tests of the audio player (audio-player.spec.ts). The test includes Percy snapshots to check a visual regression of mx_EventTile_last on which the player is rendered, but since the repository has run out of the quota, the PR was integrated without checking whether Percy would take snapshots as expected. We should check it once the quota is restored later this month.

ref: #24747 and #22542

@weeman1337
Copy link
Contributor

You can have a look at a recent build: https://percy.io/dfde73bd/matrix-react-sdk/builds/26747313

Looks like seek bars are not there for any of them (searched for „audio“).

I would still close this issue. The purpose of Percy snapshots is to be aware of the changes. That can also mean the current state may probably not the correct one.

@weeman1337 weeman1337 closed this as not planned Won't fix, can't repro, duplicate, stale Apr 20, 2023
@luixxiul
Copy link
Author

Looks like seek bars are not there for any of them

The seek bars have been hidden intentionally due to #24898 (here is a comment on the test).

The intention of the issue was to add a reminder to check the snapshot, since the PR has been merged without confirming whether snapshots of the mx_EventTile_last were properly captured. This link lists them, and it seems they are captured as expected 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants