Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests looking for data-testid fail on Cypress Cloud #25161

Closed
luixxiul opened this issue Apr 20, 2023 · 1 comment · Fixed by #25163
Closed

Tests looking for data-testid fail on Cypress Cloud #25161

luixxiul opened this issue Apr 20, 2023 · 1 comment · Fixed by #25163
Labels

Comments

@luixxiul
Copy link

Steps to reproduce

  1. Check Cypress test results of matrix-react-sdk here.

Outcome

What did you expect?

The tests should pass.

What happened instead?

Some tests in which data-testid attributes are searched failed. For example, see:

Please note that this issue is reproduced only on Cypress Cloud, not local Cypress. Also data-testid attributes which are not found seem to be different among test results.

Operating system

No response

Browser information

No response

URL for webapp

No response

Application version

No response

Homeserver

No response

Will you send logs?

No

@luixxiul
Copy link
Author

luixxiul commented Apr 20, 2023

Checking this result for matrix-org/matrix-react-sdk#10658, I suspect this regressed due to a0791ff (#25152). Unless the policy for tests was changed to discourage using data-testid, the attribute should not be stripped on Cypress.

See:

  <div
    class="mx_SettingsTab_heading"
  >
    General
  </div>

The div is expected to include data-testid='general' (See: here).

Please check this result too for another example: https://cloud.cypress.io/projects/ppvnzg/runs/12638/overview/d584bf52-de5b-4c40-9677-2a5423e85523?roarHideRunsWithDiffGroupsAndTags=1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant