Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Offline presence icons are effectively invisible on dark theme #25792

Closed
turt2live opened this issue Jul 13, 2023 · 1 comment · Fixed by matrix-org/matrix-react-sdk#11287
Closed

Offline presence icons are effectively invisible on dark theme #25792

turt2live opened this issue Jul 13, 2023 · 1 comment · Fixed by matrix-org/matrix-react-sdk#11287
Assignees
@germain-gg
Labels
A-Room-List O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Tolerable Low/no impact on users T-Defect X-Regression

Comments

@turt2live
Copy link
Member

Steps to reproduce

  1. Have a presence-enabled homeserver
  2. Have people offline

Outcome

What did you expect?

Noticable presence indicators

What happened instead?

image

Operating system

Windows 11

Application version

Element Nightly version: 0.0.1-nightly.2023071301 Olm version: 3.2.14

How did you install the app?

The Internet

Homeserver

t2l.io

Will you send logs?

No
@kerryarchibald kerryarchibald added X-Regression A-Room-List O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Tolerable Low/no impact on users labels Jul 13, 2023
@germain-gg germain-gg self-assigned this Jul 14, 2023
@germain-gg germain-gg mentioned this issue Jul 18, 2023
Merged
3 tasks
@janogarcia
Copy link

janogarcia commented Jul 19, 2023 •
edited
Loading

@germain-gg The usage shown in the screenshots is actually breaking the contract for the purpose of the on-solid token.

on-solid would be for rendering content on top of any solid color that it's not the canvas color or a subtle one.

The unread indicators in the screenshot are partially rendered on top of a colored background and partially on top of the canvas. That's why it does not fit that token's original purpose/context.

I would recommend setting the indicators to color.icon.primary instead for better semantics and the expected behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@germain-gg germain-gg

Labels
A-Room-List O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Tolerable Low/no impact on users T-Defect X-Regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Restore offline presence badge color matrix-org/matrix-react-sdk
4 participants
@janogarcia @germain-gg @turt2live @kerryarchibald