Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quotes are not working when the new WYSIWYG is enabled #26296

Closed
giomfo opened this issue Oct 4, 2023 · 1 comment · Fixed by matrix-org/matrix-react-sdk#11914
Closed

Quotes are not working when the new WYSIWYG is enabled #26296

giomfo opened this issue Oct 4, 2023 · 1 comment · Fixed by matrix-org/matrix-react-sdk#11914
Assignees
@t3chguy
Labels
A-Rich-Text-Editor Issues with the new rich text editor, also known as the WYSIWYG editor O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Z-Labs

Comments

@giomfo
Copy link
Member

giomfo commented Oct 4, 2023

Steps to reproduce

  1. Enable the new WYSIWYG editor in the application settings
  2. Select a message in an existing room timeline
  3. Select the option "Quote"

Outcome

What did you expect?

The quoted message should appear in the composer and be sent with the new message

What happened instead?

nothing appears in the composer, the quoted message is missing in the new sent message

Additional informations:

Operating system

No response

Browser information

No response

URL for webapp

No response

Application version

Element version: 73c7706-react-feb7e9899bc6-js-6e8d15e5ed42 Olm version: 3.2.14

Homeserver

No response

Will you send logs?

No
@giomfo giomfo added the T-Defect label Oct 4, 2023
@kerryarchibald kerryarchibald added S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience Z-Labs A-Rich-Text-Editor Issues with the new rich text editor, also known as the WYSIWYG editor labels Oct 6, 2023
@jonnyandrew jonnyandrew mentioned this issue Nov 20, 2023
Closed
@giomfo
Copy link
Member Author

giomfo commented Nov 21, 2023

After thinking, we decided to remove the quote option from the context menu on all Element clients (web and mobile).
The quote will stay an option in the RTE itself

@t3chguy t3chguy mentioned this issue Nov 21, 2023
Merged
@t3chguy t3chguy self-assigned this Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t3chguy t3chguy

Labels
A-Rich-Text-Editor Issues with the new rich text editor, also known as the WYSIWYG editor O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Z-Labs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove Quote from MessageContextMenu as it is unsupported by WYSIWYG matrix-org/matrix-react-sdk
3 participants
@t3chguy @kerryarchibald @giomfo