Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeated setting of .m.rule.is_room_mention push rule #27173

Closed
erikjohnston opened this issue Mar 13, 2024 · 4 comments · Fixed by matrix-org/matrix-js-sdk#4135
Closed

Repeated setting of .m.rule.is_room_mention push rule #27173

erikjohnston opened this issue Mar 13, 2024 · 4 comments · Fixed by matrix-org/matrix-js-sdk#4135
Assignees
Labels
A-Notifications O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Release-Blocker

Comments

@erikjohnston
Copy link
Member

Steps to reproduce

Element web seems to be sending the following requests in a loop:

  • PUT /_matrix/client/v3/pushrules/global/override/.m.rule.is_room_mention/enabled
  • PUT /_matrix/client/v3/pushrules/global/override/.m.rule.is_room_mention/actions

Outcome

What did you expect?

For it to not repeatedly send those requests

What happened instead?

It gets stuck in a loop?

Operating system

Ubuntu

Browser information

Firefox/123.0

URL for webapp

No response

Application version

54ba087-react-0f251d8a55a6-js-78d05942a35a

Homeserver

matrix.org

Will you send logs?

Yes

@t3chguy
Copy link
Member

t3chguy commented Mar 13, 2024

Likely caused by element-hq/synapse#16987

@t3chguy t3chguy added S-Minor Impairs non-critical functionality or suitable workarounds exist A-Notifications Z-Synapse O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Mar 22, 2024
@AndrewKvalheim
Copy link
Contributor

AndrewKvalheim commented Mar 27, 2024

This is hammering at 2000 requests per minute. What can I do now but just close Element?

Edit: Blocked the runaway request with uBlock Origin

@langleyd langleyd added S-Major Severely degrades major functionality or product features, with no satisfactory workaround and removed S-Minor Impairs non-critical functionality or suitable workarounds exist labels Mar 27, 2024
@marvinwankersteen
Copy link

marvinwankersteen commented Mar 28, 2024

I can confirm the problem. My Linux Mint has been updating Element in the background and I've seen it in the server logs that the logs are getting cluttered.

After some debugging I found this issue here.

I downgraded Element desktop from v1.11.62 to v1.11.61 and the problem is gone for now.

https://packages.element.io/debian/pool/main/e/element-desktop/element-desktop_1.11.61_amd64.deb

In the server container logs the following logs is flooding:

2024-03-28 11:59:05,840 - synapse.access.http.10000 - 472 - INFO - GET-9549 - ::ffff:W.X.Y.Z - 10000 - {@user:domain.com} Processed request: 0.023sec/0.002sec (0.006sec, 0.000sec) (0.002sec/0.013sec/3) 7452B 200 "GET /_matrix/client/v3/sync?filter=12&timeout=30000&set_presence=unavailable&since=s7329751_11015327_85_1057534_477490_196832_327302_1784570_0_19 HTTP/1.1" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Element/1.11.62 Chrome/122.0.6261.70 Electron/29.1.0 Safari/537.36" [0 dbevts]
2024-03-28 11:59:05,994 - synapse.access.http.10000 - 472 - INFO - GET-9550 - ::ffff:W.X.Y.Z - 10000 - {@user:domain.com} Processed request: 0.016sec/0.001sec (0.006sec, 0.001sec) (0.001sec/0.008sec/3) 7452B 200 "GET /_matrix/client/v3/sync?filter=12&timeout=30000&set_presence=unavailable&since=s7329751_11015327_85_1057534_477490_196834_327302_1784570_0_19 HTTP/1.1" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Element/1.11.62 Chrome/122.0.6261.70 Electron/29.1.0 Safari/537.36" [0 dbevts]
2024-03-28 11:59:06,146 - synapse.access.http.10000 - 472 - INFO - GET-9552 - ::ffff:W.X.Y.Z - 10000 - {@user:domain.com} Processed request: 0.016sec/0.001sec (0.005sec, 0.000sec) (0.001sec/0.008sec/3) 7452B 200 "GET /_matrix/client/v3/sync?filter=12&timeout=30000&set_presence=unavailable&since=s7329751_11015327_85_1057534_477490_196837_327302_1784570_0_19 HTTP/1.1" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Element/1.11.62 Chrome/122.0.6261.70 Electron/29.1.0 Safari/537.36" [0 dbevts]

The developer console shows the same like in #27246.

I have the server version v1.103.0 running.

@t3chguy t3chguy removed the Z-Synapse label Mar 28, 2024
@t3chguy
Copy link
Member

t3chguy commented Mar 28, 2024

Regressed by matrix-org/matrix-js-sdk#4100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Notifications O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Release-Blocker
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants