Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No feedback when decrypting attachments #2749

Closed
ara4n opened this issue Dec 16, 2016 · 7 comments
Closed

No feedback when decrypting attachments #2749

ara4n opened this issue Dec 16, 2016 · 7 comments
Labels
A-E2EE P1 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Needs-Community-Testing

Comments

@ara4n
Copy link
Member

ara4n commented Dec 16, 2016

coffee says he got a file decrypt link from yannick with an apk in e2e room; clicked it; no feedback whilst stuff downloaded, and then the download link disappered entirely
@richvdh
Copy link
Member

richvdh commented Dec 16, 2016

It seems unlikely apks would be singled out for special treatment?

@richvdh
Copy link
Member

richvdh commented Dec 16, 2016

Indeed, apks seem to work fine for me.

I can believe that there is no feedback while download and decryption happens, or if there is an error.

(Also, this is a two-step process: First, click "Decrypt", which downloads and decrypts the attachment. Then the link turns into "Download", which is a misleading name, as by then the attachment is downloaded and in memory. Then, clicking "Download" just gives you a save dialog.)

@richvdh richvdh changed the title e2e file transfer broken for apk files No feedback when decrypting attachments Dec 16, 2016
@richvdh richvdh added the A-E2EE label Dec 16, 2016
@ara4n
Copy link
Member Author

ara4n commented Dec 16, 2016

i can believe this isn't apk specific, was just filing the bug verbatim as it came in from @matrixcoffee. It sounds like the link never turned into "Download". @matrixcoffee: what browser was this; can you repro it; and if so, can you please share the JS console?

@ara4n ara4n added T-Defect S-Tolerable Low/no impact on users P2 labels Dec 20, 2016
@ara4n
Copy link
Member Author

ara4n commented Feb 22, 2017

i just got bitten badly by this - it took about 3 minutes to download a 24MB encrypted attachment, and there was no reaction whatsoever to me having clicked the link. I had to guess that it was working based on the network inspector. Finally it changed to 'Download...' rather than 'Decrypt...' which is unintuitive, given it'd already downloaded it by that point......

@richvdh
Copy link
Member

richvdh commented Feb 23, 2017

argh. yes. This isn't a p2 cosmetic imho...

@richvdh richvdh mentioned this issue May 11, 2017
Closed
@lampholder lampholder added ui/ux P1 S-Minor Impairs non-critical functionality or suitable workarounds exist and removed S-Tolerable Low/no impact on users P2 labels Jan 18, 2018
@lampholder
Copy link
Member

Meddling with the labels on this, because it is highly annoying.

Also, it seems that once it has decrypted the link loses it's cursor: pointer styling.

@t3chguy t3chguy mentioned this issue Jun 12, 2018
Closed
@ara4n ara4n mentioned this issue Jul 9, 2018
Closed
@turt2live turt2live mentioned this issue Apr 28, 2020
Closed
@jryans jryans removed the Z-UI/UX label Mar 9, 2021
@kittykat
Copy link
Contributor

I'm going to close this for now as we couldn't reproduce it:

Attachment decryption button isn't there anymore.

Please re-open with more details if there is still an issue here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-E2EE P1 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Needs-Community-Testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@kittykat @jryans @ara4n @richvdh @lampholder @duxovni