Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop & drag roomtiles in roomlist fails if you have too many or too much ordering #3280

Closed
ara4n opened this issue Feb 21, 2017 · 5 comments
Closed
Labels
A-Room-List P2 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@ara4n
Copy link
Member

ara4n commented Feb 21, 2017

I suspect this is an artefact of the stupid floating point ordering system its currently using.

@ara4n ara4n added T-Defect S-Minor Impairs non-critical functionality or suitable workarounds exist P2 A-Room-List labels Feb 21, 2017
@ara4n
Copy link
Member Author

ara4n commented Feb 21, 2017

combined with #2365 this makes the drop & drag feel incredibly flakey.

@ara4n
Copy link
Member Author

ara4n commented Feb 21, 2017

@intelfx was suffering this; his tag orderings are:

$ grep -B1 '"order":' data
                                    "m.favourite": {
                                        "order": null
--
                                    "m.favourite": {
                                        "order": 0.9921875
--
                                    "m.favourite": {
                                        "order": 0.9521484375
--
                                    "m.favourite": {
                                        "order": null
--
                                    "m.favourite": {
                                        "order": null
--
                                    "m.favourite": {
                                        "order": 0
--
                                    "m.favourite": {
                                        "order": 0.9160156250000001
--
                                    "m.favourite": {
                                        "order": 0.98828125
--
                                    "m.favourite": {
                                        "order": ".046875"

Looks like this is an unpleasant combo of string v. float typing, 0's and nulls.

@ara4n
Copy link
Member Author

ara4n commented Feb 21, 2017

clearly different clients are maintaining it differently and then interacting badly.

@turt2live
Copy link
Member

The room list also doesn't scroll when dragging and dropping. This makes it difficult to sort rooms when using custom tags.

@turt2live
Copy link
Member

Closing in favour of #8614

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Room-List P2 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Development

No branches or pull requests

2 participants