Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Riot now fails fairly ungracefully in Tor browser #4379

Closed
dbkr opened this issue Jun 20, 2017 · 8 comments
Closed

Riot now fails fairly ungracefully in Tor browser #4379

dbkr opened this issue Jun 20, 2017 · 8 comments
Labels
P3 S-Critical Prevents work, causes data loss and/or has no workaround T-Defect Z-Platform-Specific

Comments

@dbkr
Copy link
Member

dbkr commented Jun 20, 2017

No description provided.

@ara4n
Copy link
Member

ara4n commented Jun 20, 2017

is this a dup of #4238?

@dbkr
Copy link
Member Author

dbkr commented Jun 20, 2017

Possibly, although I was initially testing with Tor browser 6.5

@richvdh
Copy link
Member

richvdh commented Jun 21, 2017

@dbkr: could you be more specific?

@richvdh
Copy link
Member

richvdh commented Jun 21, 2017

I suspect it's related to #4340 (ie, we barf if indexeddb fails)

@lampholder
Copy link
Member

Testing with 7.0.1 (based on ff 52.2.0) - I get the modernizr warning then inifinispinner.

Looks likely to be a indexddb thing: Error: must pass indexedDB into IndexedDBCryptoStore bundle.js:120:1446

Full log:

downloadable font: kern: Too large subtable, table discarded (font-family: "Open Sans" style:normal weight:normal stretch:normal src index:0) source: https://riot.im/app/fonts/Open_Sans/OpenSans-Regular.ttf  theme-light.css:1:68041
TypeError: asm.js type error: Disabled by 'asmjs' runtime option  olm.js
Browser missing feature: 'indexeddb'  bundle.js:82:19408
"Initialised rageshake: See https://bugs.chromium.org/p/chromium/issues/detail?id=583193 to fix line numbers on Chrome."  bundle.js:82:19408
set language to en-us  bundle.js:82:19408
"Vector starting at https://riot.im/app/"  bundle.js:82:19408
Browser is missing required features.  bundle.js:82:19408
downloadable font: kern: Too large subtable, table discarded (font-family: "Open Sans" style:normal weight:bold stretch:normal src index:0) source: https://riot.im/app/fonts/Open_Sans/OpenSans-Bold.ttf  theme-light.css:1:68608
User accepts the compatibility risks.  bundle.js:82:19408
set language to en-us  bundle.js:82:19408
User has previously accepted risks in using an unsupported browser  bundle.js:82:19408
"Vector starting at https://riot.im/app/"  bundle.js:82:19408
No previous session found.  bundle.js:82:19408
"Doing guest login on https://matrix.org"  bundle.js:82:19408
Unable to load session Error: must pass indexedDB into IndexedDBCryptoStore
Stack trace:
e@https://riot.im/app/bundles/cb81721f371eda52f2e4/bundle.js:120:1446
@https://riot.im/app/bundles/cb81721f371eda52f2e4/bundle.js:39:632
e.exports.createClient@https://riot.im/app/bundles/cb81721f371eda52f2e4/bundle.js:120:9782
a@https://riot.im/app/bundles/cb81721f371eda52f2e4/bundle.js:87:667
i/<@https://riot.im/app/bundles/cb81721f371eda52f2e4/bundle.js:87:147
r@https://riot.im/app/bundles/cb81721f371eda52f2e4/bundle.js:27:8950
g.prototype.then/</<@https://riot.im/app/bundles/cb81721f371eda52f2e4/bundle.js:27:9223
g/r.promiseDispatch@https://riot.im/app/bundles/cb81721f371eda52f2e4/bundle.js:27:2944
g.prototype.then/<@https://riot.im/app/bundles/cb81721f371eda52f2e4/bundle.js:27:9174
r@https://riot.im/app/bundles/cb81721f371eda52f2e4/bundle.js:27:6501
e@https://riot.im/app/bundles/cb81721f371eda52f2e4/bundle.js:27:6439
o@https://riot.im/app/bundles/cb81721f371eda52f2e4/bundle.js:82:8788
a@https://riot.im/app/bundles/cb81721f371eda52f2e4/bundle.js:82:8966
u/n@https://riot.im/app/bundles/cb81721f371eda52f2e4/bundle.js:82:9325
  bundle.js:82:19408
Error: must pass indexedDB into IndexedDBCryptoStore  bundle.js:120:1446
XML Parsing Error: syntax error
Location: https://riot.im/app/version?cachebuster=1498036540300
Line Number 1, Column 1:  version:1:1
Initialised anonymous analytics  bundle.js:82:19408
XML Parsing Error: syntax error
Location: https://riot.im/app/version?cachebuster=1498037140300
Line Number 1, Column 1:  version:1:1
XML Parsing Error: syntax error
Location: https://riot.im/app/version?cachebuster=1498037740300
Line Number 1, Column 1:  version:1:1
TypeError: n is null[Learn More]  bundle.js:149:10768

@dbkr
Copy link
Member Author

dbkr commented Jun 21, 2017

Yeah, what @lampholder said - for me it went straight to infinite spinner, but I'd probably clicked through the warning screen on a previous run many moons ago

@richvdh
Copy link
Member

richvdh commented Jun 22, 2017

p3 critical, @lampholder ?

fixed by matrix-org/matrix-js-sdk#473, anyway

@dbkr dbkr closed this as completed Jun 22, 2017
@lampholder
Copy link
Member

p3 because it wasn't affecting many users, critical 'cause those it is affecting it's affecting completely.

That was my rationale, anyway... :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 S-Critical Prevents work, causes data loss and/or has no workaround T-Defect Z-Platform-Specific
Projects
None yet
Development

No branches or pull requests

4 participants