Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run multiple instances of Riot-web electron app with different config folder #4566

Closed
MurzNN opened this issue Jul 13, 2017 · 10 comments
Closed
Labels
A-Electron P4 [OBSOLETE LABEL] Interesting — Not yet scheduled, will accept patches S-Tolerable Low/no impact on users T-Enhancement

Comments

@MurzNN
Copy link
Contributor

MurzNN commented Jul 13, 2017

I need to be online in several Matrix accounts simultaneously. Can I run multiple instances of Riot-web electron app with different config folders? At now on Linux Riot-web store config in ~/.config/Riot folder.

Maybe I can set another path to Riot config via command line argument or shell variable? And will be good to have the way to change app icon too.

@t3chguy
Copy link
Member

t3chguy commented Jul 13, 2017

Use the --profile=x switch when starting riot, where x is a unique value for each extra store you want

@MurzNN
Copy link
Contributor Author

MurzNN commented Jul 13, 2017

Thanks, it works! Maybe there also exist way to replace app icon (and tray icon), and app name for profiles too?
Or maybe you can describe a hack - which image file I can replace in Riot-web sources for change the icon? I already try to replace images in resources/app/img but this isn't help.

Can you describe which image file is used for tray icon and window icon in Riot-web electron app?

@MurzNN
Copy link
Contributor Author

MurzNN commented Jul 13, 2017

I find in sources of resources/app/src/tray.js that config file resources/webapp/config.json can have icon_path value with custom icon, but setting it to custom image not help - app icon stay original.
Also changing brand only change "Show/hide" menuitem in tray icon, but general popup is stay "Riot".

@lampholder lampholder added feature P4 [OBSOLETE LABEL] Interesting — Not yet scheduled, will accept patches S-Tolerable Low/no impact on users labels Jul 13, 2017
@lampholder
Copy link
Member

Since the ability to run multiple instances already exists, I'm labelling this a p4 cosmetic feature request (to enable each of those instances to appear visually distinct).

OOI what do people think about this vs the app's having the ability to handle multiple accounts within a single instance? Obviously that's a fair amount more work...

@t3chguy
Copy link
Member

t3chguy commented Jul 13, 2017

The Logo and Text are actually based on the Favicon and document.title of the underlying webapp, the config.json values are only for during start-up
You should be able to edit the index.html and replace the favicon

@ansiwen
Copy link

ansiwen commented Aug 4, 2017

@lampholder: I think the possibility to have several accounts within the app is still essential. If you run it in the browser or especially as the iOS app, there is no ways to run multiple instances. (Yes, in the browser you can create a wildcard webserver where *.chat.example.com are all served with a riot instance and have different configs that way...) It would also look nicer to have just one icon for the app. Imagin you would need several email client instances for different mail accounts?

@MurzNN
Copy link
Contributor Author

MurzNN commented Aug 4, 2017

If Riot Electron app is only web page in browser, can Election app have multiple tabs with different webpages, and switcher between them? Example of this implementation we can see in multiple accounts apps like http://rambox.pro/
...Seems Rambox also supports multiple Riot clients in his boxes :)

@t3chguy
Copy link
Member

t3chguy commented Aug 4, 2017

@MurzNN not without rewriting too much of the app

@t3chguy
Copy link
Member

t3chguy commented Aug 4, 2017

Since config is more of a build config rather than user config, and it is now possible to have multiple profiles of riot-web electron open I think that the next step is proper multiple account support, so closing this in favour of that as it has already led to confusion as demonstrated by @ansiwen: #2320

@t3chguy t3chguy closed this as completed Aug 4, 2017
@MurzNN
Copy link
Contributor Author

MurzNN commented Aug 7, 2017

Yes, multiple accounts is tracked at #2320
Also I create separate issue about changing app icon and names #4745

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Electron P4 [OBSOLETE LABEL] Interesting — Not yet scheduled, will accept patches S-Tolerable Low/no impact on users T-Enhancement
Projects
None yet
Development

No branches or pull requests

5 participants