Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emoji are inverted when in code tags on the dark theme #7872

Closed
turt2live opened this issue Dec 16, 2018 · 2 comments · Fixed by matrix-org/matrix-react-sdk#6320
Closed

Emoji are inverted when in code tags on the dark theme #7872

turt2live opened this issue Dec 16, 2018 · 2 comments · Fixed by matrix-org/matrix-react-sdk#6320
Assignees
@SimonBrandner
Labels
A-Emoji P2 S-Tolerable Low/no impact on users T-Defect

Comments

@turt2live
Copy link
Member

also it is plain wrong on the dark theme
@turt2live
Copy link
Member Author

image

@turt2live
Copy link
Member Author

It uses the system emoji, which is now intended: #9281

Leaving this open to repurpose for inversion

@turt2live turt2live changed the title Emoji is different when in code tags Emoji are inverted when in code tags on the dark theme Mar 26, 2019
@turt2live turt2live mentioned this issue May 19, 2019
Merged
@jryans jryans added the A-Emoji label May 30, 2019
@turt2live turt2live mentioned this issue Apr 30, 2020
Closed
@aaronraimist aaronraimist mentioned this issue May 31, 2020
Closed
@jryans jryans removed the Z-UI/UX label Mar 9, 2021
@SimonBrandner SimonBrandner self-assigned this Jul 7, 2021
@SimonBrandner SimonBrandner mentioned this issue Jul 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SimonBrandner SimonBrandner

Labels
A-Emoji P2 S-Tolerable Low/no impact on users T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use a proper color scheme for codeblocks SimonBrandner/matrix-react-sdk
4 participants
@jryans @turt2live @lampholder @SimonBrandner