Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempting to autofill a command/emoji quickly will cause a user to be autofilled instead #9757

Open
aaronraimist opened this issue May 18, 2019 · 9 comments
Labels
A-Autocomplete A-Composer A-Slash-Commands O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@aaronraimist
Copy link
Collaborator

Description

If I type /devtab quickly in an attempt to get to /devtools, Riot autofills some user in the room instead of autofilling the command. First mentioned in #6993 (which seems to be fixed 😄).

Steps to reproduce

  1. Open a room with a user who's username starts with d
  2. Type /dtab

Log: not sent

Screen Shot 2019-05-17 at 6 11 37 PM

Version information

  • Platform: web

For the web app:

  • Browser: Safari and Firefox
  • OS: macOS
  • URL: riot.im/develop
@jryans jryans added S-Minor Impairs non-critical functionality or suitable workarounds exist P2 A-Autocomplete labels May 20, 2019
@t3chguy t3chguy changed the title Attempting to autofill a command quickly will cause a user to be autofilled instead Attempting to autofill a command/emoji quickly will cause a user to be autofilled instead Jun 1, 2021
@yannicka
Copy link

I am not sure if this problem still exists. 🤔

@SimonBrandner
Copy link
Contributor

Yes it does :(

@SimonBrandner SimonBrandner added O-Uncommon Most users are unlikely to come across this or unexpected workflow and removed P2 labels Aug 29, 2021
@yannicka
Copy link

yannicka commented Aug 29, 2021

When I type /d<tab> it autocompletes /ddg (and when I type /dev<tab> it autocompletes /devtools ). And I'm in a room where there is a user whose username begins with "d".

@aaronraimist
Copy link
Collaborator Author

Doing it quickly is the key. I can definitely still reproduce.

@yannicka
Copy link

Oh yes, if you do this quickly enough, there is the problem. ^^'

@Peque
Copy link

Peque commented Oct 9, 2021

I can reproduce too with emojis. 👍

@ell1e
Copy link

ell1e commented Aug 17, 2022

Since my ticket was closed in favor of this one, let me suggest the additional points that aren't listed here yet (edit: apparently that's simply a bug, see next comment):

IMHO emoji autocomplete should be : and username autocomplete should only be via @ since this is how it works for all other messengers I've ever used (Telegram, Discord, if I recall Wire Messenger as well). Right now, typing : seems to also autocomplete usernames, but this seems bad to me since if someone using Element is going by muscle memory (as most people will for emojis) then this will mess things up if a user with a name similar to an emoji name is around. Also, @ already exists for that, and the usernames in the auto-complete popup even are listed with @ at the start, so one could argue that : can even autocomplete them is inconsistent even if it had no other disadvantages.

Also, sometimes when doing the auto-complete too fast it seems to do nothing at all. (Popup didn't even open yet, and then the "tab" completion confirm keypress is simply ignored.) This also shouldn't happen IMHO.

@t3chguy
Copy link
Member

t3chguy commented Aug 17, 2022

@ell1e that's simply a bug and doesn't happen if you go slower, hence this issue.

@Flexmaen
Copy link

I also add my points since they were not mentioned here:

  1. I wrote :-D
  2. I pressed enter.
  3. I got ✌️

Other Smileys like :-) ;-) ;-D work, but the same problem with :-O and :-P - so I guess everything containing a letter triggers the pop-up emoji window that will turn your input into something different then.

It helped when I also disabled "Enable Emoji suggestions while typing", but still this is a bug, because:

  • replacing Emojis was already turned off
  • :-D shouldn't be replaced by an emoji which is triggered by :v:

If you continue writing, the smiley won't be replaced. But usually you put the smileys on the end of the line and so when pressing enter afterwards it get's replaced then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Autocomplete A-Composer A-Slash-Commands O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Development

No branches or pull requests

8 participants