Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hs_url param is broken #9908

Closed
uhoreg opened this issue May 30, 2019 · 8 comments
Closed

hs_url param is broken #9908

uhoreg opened this issue May 30, 2019 · 8 comments

Comments

@uhoreg
Copy link
Member

uhoreg commented May 30, 2019

users used to be able to set the default homeserver URL by setting a parameter ( matrix-org/matrix-react-sdk#716 ), but it looks like it was broken in the redesign

@turt2live
Copy link
Member

this is somewhat intentionally broken in develop due to the recent login/auth changes btw.

@lampholder
Copy link
Member

I hadn't considered this - the intention is for people to provide links to https://riot.im/app (or other riot instances) and specify the default homeserver via GET params.

In theory this sounds like a good thing to keep supporting - do we have any idea how well used it is?

@turt2live is it possible to:

  • if the riot instance allows connecting to other HSes, check whether the provided HS is valid as we do when checking the config
  • if the riot instance is locked down to a single HS, probably just ignore the GET param HS?

@turt2live
Copy link
Member

turt2live commented May 31, 2019

@lampholder the exact same parameters are heavily intertwined with email validation already, and are ignored by the validator for this reason

@abcydybcy
Copy link

Any update on this? We don't want to host yet another copy of Riot, but without the ability to redirect to homeserver login we're forced to.

@turt2live
Copy link
Member

It's no easier to do than it was in May. Hosting your own Riot is going to be much better.

@TheTimeWalker
Copy link

Just found out that this is broken which is a bit annoying since I often times get issues with people onboarding to my home server since they immediately try to login to matrix.org instead. The solution "hosting your own Riot" doesn't make much sense to me because riot-web's Readme already mentions that hosting your own instance with the same domain as your home server brings in some security risks.

@uhoreg
Copy link
Member Author

uhoreg commented Feb 14, 2020

@TheTimeWalker It's only an issue to host Riot on the same hostname as your homeserver, not demain. So if your Riot is on riot.example.com, and your homeserver is on synapse.example.com, then you're fine.

@t3chguy
Copy link
Member

t3chguy commented Mar 19, 2020

Closing in favour of #5469 which has more upvotes

@t3chguy t3chguy closed this as completed Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants