Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_auth_and_persist_outliers could do with being optimised #11013

Open
matrixbot opened this issue Dec 19, 2023 · 0 comments
Open

_auth_and_persist_outliers could do with being optimised #11013

matrixbot opened this issue Dec 19, 2023 · 0 comments

Comments

@matrixbot
Copy link
Collaborator

matrixbot commented Dec 19, 2023

This issue has been migrated from #11013.


As part of my work on #9595, I've ended up making some of the code which persists events received over federation a bit more conservative. (Specifically, this is the code for handling batches of outliers, in FederationEventHandler._auth_and_persist_outliers).

matrix-org/synapse#10896 (comment) raised the concern that this could result in a lot of round-trips between the federation inbound worker and the event persister.

It should be possible to optimise all this, so that we do all the event auth first, and then persist everything in one big chunk.

@matrixbot matrixbot changed the title Dummy issue _auth_and_persist_outliers could do with being optimised Dec 21, 2023
@matrixbot matrixbot reopened this Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant