You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm not sure it makes sense for this to inherit from SynapseError. The risk is that this manages to bubble all the way to the client API, returning a 403, which seems entirely wrong.
Make sure any upstream callers handle FederationDeniedError properly and not just the inherited SynapseError class
Pull Request Checklist
Pull request is based on the develop branch
Pull request includes a changelog file. The entry should:
Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
Use markdown where necessary, mostly for code blocks.
End with either a period (.) or an exclamation mark (!).
Start with a capital letter.
Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
This issue has been migrated from #14190.
FederationDeniedError
is not aSynapseError
.Basically the same reasoning that @erikjohnston gave in matrix-org/synapse#13816 (comment)
See matrix-org/synapse#14191 where
SynapseError
is given more context and clarified.Todo
FederationDeniedError
properly and not just the inheritedSynapseError
classPull Request Checklist
EventStore
toEventWorkerStore
.".code blocks
.(run the linters)
The text was updated successfully, but these errors were encountered: