Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging loop after SIGHUP when a StreamHandler is configured #6550

Open
matrixbot opened this issue Dec 17, 2023 · 0 comments
Open

Logging loop after SIGHUP when a StreamHandler is configured #6550

matrixbot opened this issue Dec 17, 2023 · 0 comments

Comments

@matrixbot
Copy link
Collaborator

matrixbot commented Dec 17, 2023

This issue has been migrated from #6550.


If you use the default logging config, which has a StreamHandler pointing at sys.stderr, and do not set --no-redirect-stdio, then when you send synapse a SIGHUP, it will stack overflow and abort.

The problem appears to be that when you SIGHUP it, the streamhandler gets repointed at the redirected stderr, which goes back into a logger: so as soon as anything is logged, we get an infinite loop.

@matrixbot matrixbot changed the title Dummy issue Logging loop after SIGHUP when a StreamHandler is configured Dec 21, 2023
@matrixbot matrixbot reopened this Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant