Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix translation charset #732

Merged
merged 1 commit into from
Jan 23, 2023
Merged

Fix translation charset #732

merged 1 commit into from
Jan 23, 2023
+1 −1

Conversation

meisenzahl
Copy link
Member

@meisenzahl meisenzahl requested a review from ryonakano January 23, 2023 16:13
@meisenzahl meisenzahl mentioned this pull request Jan 23, 2023
Merged
6 tasks
tintou
tintou approved these changes Jan 23, 2023
View reviewed changes
Copy link
Member

@tintou tintou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are forcing UTF-8 from the code-side anyway so better use it here too

@danirabbit danirabbit merged commit bda2e11 into master Jan 23, 2023
@danirabbit danirabbit deleted the fix-translations-charsets branch January 23, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tintou tintou tintou approved these changes

@ryonakano ryonakano Awaiting requested review from ryonakano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@meisenzahl @tintou @danirabbit