Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Permissions view creates empty files in home folder #124

Merged
merged 1 commit into from
Oct 20, 2020
Merged

Permissions view creates empty files in home folder #124

merged 1 commit into from
Oct 20, 2020
+44 −3

Conversation

meisenzahl
Copy link
Member

Closes #121

@meisenzahl
Copy link
Member Author

Fixes a recursive constructor invocation

  • AppManager.construct ()
  • AppManager.get_apps_for_installation ()
  • App.construct ()
  • App.get_overrides_path ()
  • AppManager.get_default ().user_installation_path

At that time AppManager was not yet completely created...

danirabbit
danirabbit approved these changes Oct 20, 2020
View reviewed changes
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job tracking down the issue. Can confirm this fixes it

@danirabbit danirabbit merged commit 2744ee1 into elementary:master Oct 20, 2020
@danirabbit danirabbit mentioned this pull request Oct 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danirabbit danirabbit danirabbit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Permissions view creates empty files in home folder
2 participants
@meisenzahl @danirabbit