Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugging rendering and/or crash with PANIC after PR #2380 #2459

Open
akruphi opened this issue Oct 22, 2024 · 1 comment
Open

Bugging rendering and/or crash with PANIC after PR #2380 #2459

akruphi opened this issue Oct 22, 2024 · 1 comment

Comments

@akruphi
Copy link
Contributor

akruphi commented Oct 22, 2024

After PR #2380 moving Files highlighting editing dialog by Ctrl+F5 often leads to incorrect rendering in Files highlighting list and/or crash with PANIC (thanks @shmuz for investigation):
image

We wait correction PR from @anta999 .

From telegram-chat https://t.me/far2l_ru/32381:

Если да, то я знаю про этот косяк и как поймать PANIC если за нижнюю границу область с примеров файлов опутсить

Забываю все время про него и дмуал потом исправлю

Там рисуется напрямую в буфеер фара, потому что через диалог помидоры криво рисуются

Ограничение на отрисовку элемента который напряимую рисуется там - примеры файлов

@spnethw
Copy link
Contributor

spnethw commented Nov 9, 2024

Починено в PR #2452 :

int X1 = CurX;
int Y1 = CurY;
int X2 = CurX + Length;
int Y2 = CurY;
if (X1 < 0)
X1 = 0;
if (Y1 < 0)
Y1 = 0;
if (X2 > ScrX)
X2 = ScrX;
if (Y2 > ScrY)
Y2 = ScrY;
ScrBuf.FillRect(X1, Y1, X2, Y2, Ch, Color);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants