From c7d9459635c0fd34de068baafe5b989a9aa1ecfe Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu, 23 Feb 2023 09:11:45 +0000 Subject: [PATCH] Bump phpstan/phpstan from 1.9.18 to 1.10.1 (#3036) * Bump phpstan/phpstan from 1.9.18 to 1.10.1 Bumps [phpstan/phpstan](https://github.com/phpstan/phpstan) from 1.9.18 to 1.10.1. - [Release notes](https://github.com/phpstan/phpstan/releases) - [Changelog](https://github.com/phpstan/phpstan/blob/1.10.x/CHANGELOG.md) - [Commits](https://github.com/phpstan/phpstan/compare/1.9.18...1.10.1) --- updated-dependencies: - dependency-name: phpstan/phpstan dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] * Updated phpstan.dist.baseline.neon --------- Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Fabrizio Balliano Co-authored-by: Sven Reichel --- composer.lock | 12 +- phpstan.dist.baseline.neon | 2628 +----------------------------------- phpstan.dist.issues.neon | 6 - 3 files changed, 55 insertions(+), 2591 deletions(-) diff --git a/composer.lock b/composer.lock index de97e693c105..787c65c9de74 100644 --- a/composer.lock +++ b/composer.lock @@ -3414,16 +3414,16 @@ }, { "name": "phpstan/phpstan", - "version": "1.9.18", + "version": "1.10.1", "source": { "type": "git", "url": "https://github.com/phpstan/phpstan.git", - "reference": "f2d5cf71be91172a57c649770b73c20ebcffb0bf" + "reference": "1cd5fc530a8b68702f3733ad64294b2a39564198" }, "dist": { "type": "zip", - "url": "https://api.github.com/repos/phpstan/phpstan/zipball/f2d5cf71be91172a57c649770b73c20ebcffb0bf", - "reference": "f2d5cf71be91172a57c649770b73c20ebcffb0bf", + "url": "https://api.github.com/repos/phpstan/phpstan/zipball/1cd5fc530a8b68702f3733ad64294b2a39564198", + "reference": "1cd5fc530a8b68702f3733ad64294b2a39564198", "shasum": "" }, "require": { @@ -3453,7 +3453,7 @@ ], "support": { "issues": "https://github.com/phpstan/phpstan/issues", - "source": "https://github.com/phpstan/phpstan/tree/1.9.18" + "source": "https://github.com/phpstan/phpstan/tree/1.10.1" }, "funding": [ { @@ -3469,7 +3469,7 @@ "type": "tidelift" } ], - "time": "2023-02-17T15:01:27+00:00" + "time": "2023-02-21T21:57:23+00:00" }, { "name": "phpunit/php-code-coverage", diff --git a/phpstan.dist.baseline.neon b/phpstan.dist.baseline.neon index 48e1b4490122..a5d57280661a 100644 --- a/phpstan.dist.baseline.neon +++ b/phpstan.dist.baseline.neon @@ -10,11 +10,6 @@ parameters: count: 1 path: app/Mage.php - - - message: "#^Right side of && is always true\\.$#" - count: 1 - path: app/Mage.php - - message: "#^Comparison operation \"\\=\\=\" between \\(Varien_Simplexml_Element\\|null\\) and 1 results in an error\\.$#" count: 1 @@ -30,6 +25,11 @@ parameters: count: 1 path: app/code/core/Mage/Admin/Model/Resource/Acl.php + - + message: "#^Method Mage_Admin_Model_Resource_User\\:\\:_encryptPassword\\(\\) is unused\\.$#" + count: 1 + path: app/code/core/Mage/Admin/Model/Resource/User.php + - message: "#^Return type \\(bool\\) of method Mage_Admin_Model_Resource_User\\:\\:delete\\(\\) should be compatible with return type \\(\\$this\\(Mage_Core_Model_Resource_Db_Abstract\\)\\) of method Mage_Core_Model_Resource_Db_Abstract\\:\\:delete\\(\\)$#" count: 1 @@ -70,121 +70,26 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/Block/Cache/Grid.php - - - message: "#^If condition is always true\\.$#" - count: 3 - path: app/code/core/Mage/Adminhtml/Block/Catalog/Category/Abstract.php - - - - message: "#^Left side of && is always true\\.$#" - count: 2 - path: app/code/core/Mage/Adminhtml/Block/Catalog/Category/Abstract.php - - message: "#^Right side of && is always false\\.$#" count: 1 path: app/code/core/Mage/Adminhtml/Block/Catalog/Category/Abstract.php - - - message: "#^Unreachable statement \\- code above always terminates\\.$#" - count: 2 - path: app/code/core/Mage/Adminhtml/Block/Catalog/Category/Abstract.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Catalog/Category/Tab/Design.php - - - - message: "#^Right side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Catalog/Category/Tree.php - - message: "#^Cannot call method addAttributeToSelect\\(\\) on Mage_Core_Model_Resource_Db_Collection_Abstract\\|false\\.$#" count: 1 path: app/code/core/Mage/Adminhtml/Block/Catalog/Category/Widget/Chooser.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Catalog/Form/Renderer/Fieldset/Element.php - - - - message: "#^Right side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Catalog/Form/Renderer/Fieldset/Element.php - - - - message: "#^Else branch is unreachable because ternary operator condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Catalog/Product/Attribute/Edit/Tab/Main.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Catalog/Product/Composite/Fieldset/Grouped.php - - - - message: "#^Right side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit.php - - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit/Js.php - - - - message: "#^Unreachable statement \\- code above always terminates\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit/Js.php - - - - message: "#^If condition is always true\\.$#" - count: 2 - path: app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit/Tab/Categories.php - - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit/Tab/Categories.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit/Tab/Categories.php - - - - message: "#^If condition is always true\\.$#" - count: 2 - path: app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit/Tab/Inventory.php - - - - message: "#^Unreachable statement \\- code above always terminates\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit/Tab/Inventory.php - - message: "#^Method Mage_Eav_Model_Entity_Attribute_Source_Interface\\:\\:getAllOptions\\(\\) invoked with 2 parameters, 0 required\\.$#" count: 1 path: app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit/Tab/Super/Config/Simple.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit/Tab/Super/Config/Simple.php - - message: "#^Method Mage_Catalog_Model_Product_Type_Configurable\\:\\:canUseAttribute\\(\\) invoked with 2 parameters, 1 required\\.$#" count: 1 path: app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit/Tab/Super/Settings.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Catalog/Product/Grid.php - - message: "#^Call to an undefined method Mage_Eav_Model_Entity_Attribute\\:\\:isScopeGlobal\\(\\)\\.$#" count: 2 @@ -200,31 +105,6 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/Block/Catalog/Product/Helper/Form/Gallery.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Cms/Wysiwyg/Images/Content/Files.php - - - - message: "#^Left side of && is always true\\.$#" - count: 2 - path: app/code/core/Mage/Adminhtml/Block/Customer/Edit/Tab/Addresses.php - - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Customer/Edit/Tab/View.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Customer/Edit/Tab/View.php - - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Customer/Edit/Tab/View/Grid/Renderer/Item.php - - message: "#^Property Mage_Adminhtml_Block_Customer_Edit_Tab_View_Sales\\:\\:\\$_collection \\(Mage_Sales_Model_Entity_Sale_Collection\\) does not accept Varien_Data_Collection_Db\\.$#" count: 1 @@ -235,16 +115,6 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/Block/Customer/Edit/Tab/View/Wishlist.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Customer/Edit/Tab/Wishlist.php - - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Customer/Edit/Tab/Wishlist.php - - message: "#^Method Mage_Adminhtml_Block_Customer_Sales_Order_Address_Form_Renderer_Vat\\:\\:getValidateButton\\(\\) should return Mage_Adminhtml_Block_Widget_Button but returns Mage_Core_Block_Abstract\\.$#" count: 1 @@ -255,16 +125,6 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/Block/Customer/Sales/Order/Address/Form/Renderer/Vat.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Dashboard/Graph.php - - - - message: "#^Unreachable statement \\- code above always terminates\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Notification/Toolbar.php - - message: "#^Access to an undefined property Mage_Adminhtml_Block_Notification_Window\\:\\:\\$_aclResourcePath\\.$#" count: 1 @@ -300,11 +160,6 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/Block/Permissions/Usernroles.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Report/Grid.php - - message: "#^Call to an undefined method Mage_Reports_Model_Resource_Report_Collection_Abstract\\:\\:addOrderStatusFilter\\(\\)\\.$#" count: 1 @@ -320,11 +175,6 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/Block/Report/Grid/Abstract.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Report/Grid/Abstract.php - - message: "#^Property Mage_Adminhtml_Block_Report_Grid_Abstract\\:\\:\\$_columnGroupBy \\(string\\) in isset\\(\\) is not nullable\\.$#" count: 1 @@ -350,46 +200,16 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/Block/Review/Grid/Filter/Type.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Sales/Items/Abstract.php - - - - message: "#^Unreachable statement \\- code above always terminates\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Sales/Items/Abstract.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Sales/Order/Comments/View.php - - message: "#^Method Mage_Adminhtml_Block_Sales_Order_Create_Billing_Address\\:\\:getAddress\\(\\) should return Mage_Customer_Model_Address but returns Mage_Sales_Model_Quote_Address\\.$#" count: 1 path: app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Billing/Address.php - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Billing/Method/Form.php - - - - message: "#^If condition is always false\\.$#" - count: 2 - path: app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Form/Address.php - - message: "#^Method Mage_Adminhtml_Block_Sales_Order_Create_Giftmessage_Form\\:\\:getEntity\\(\\) should return Varien_Object but returns Mage_Eav_Model_Entity_Abstract\\.$#" count: 1 path: app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Giftmessage/Form.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 2 - path: app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Giftmessage/Form.php - - message: "#^Property Mage_Adminhtml_Block_Sales_Order_Create_Giftmessage_Form\\:\\:\\$_entity \\(Mage_Eav_Model_Entity_Abstract\\) does not accept Varien_Object\\.$#" count: 1 @@ -405,31 +225,16 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Shipping/Address.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Sidebar/Compared.php - - message: "#^Method Mage_Catalog_Model_Resource_Product_Compare_Item_Collection\\:\\:useProductItem\\(\\) invoked with 1 parameter, 0 required\\.$#" count: 1 path: app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Sidebar/Compared.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Sidebar/Pcompared.php - - message: "#^Method Mage_Catalog_Model_Resource_Product_Compare_Item_Collection\\:\\:useProductItem\\(\\) invoked with 1 parameter, 0 required\\.$#" count: 1 path: app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Sidebar/Pcompared.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Sidebar/Wishlist.php - - message: "#^Call to an undefined method Mage_Adminhtml_Block_Sales_Order_Creditmemo_Create_Adjustments\\:\\:addTotal\\(\\)\\.$#" count: 1 @@ -445,31 +250,11 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/Block/Sales/Order/Creditmemo/Create/Items.php - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Sales/Order/Creditmemo/Totals.php - - - - message: "#^If condition is always false\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Sales/Order/Creditmemo/View.php - - message: "#^Return type \\(Mage_Sales_Model_Order_Creditmemo\\) of method Mage_Adminhtml_Block_Sales_Order_Creditmemo_View_Items\\:\\:getSource\\(\\) should be compatible with return type \\(Mage_Sales_Model_Order_Invoice\\) of method Mage_Adminhtml_Block_Sales_Items_Abstract\\:\\:getSource\\(\\)$#" count: 1 path: app/code/core/Mage/Adminhtml/Block/Sales/Order/Creditmemo/View/Items.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Sales/Order/Payment.php - - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Sales/Order/Shipment/Create/Items.php - - message: "#^Return type \\(Mage_Sales_Model_Order_Shipment\\) of method Mage_Adminhtml_Block_Sales_Order_Shipment_Create_Items\\:\\:getSource\\(\\) should be compatible with return type \\(Mage_Sales_Model_Order_Invoice\\) of method Mage_Adminhtml_Block_Sales_Items_Abstract\\:\\:getSource\\(\\)$#" count: 1 @@ -480,76 +265,16 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/Block/Sales/Order/Shipment/Packaging.php - - - message: "#^If condition is always true\\.$#" - count: 5 - path: app/code/core/Mage/Adminhtml/Block/Sales/Order/Shipment/Packaging.php - - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Sales/Order/Shipment/Packaging.php - - message: "#^Method Mage_Adminhtml_Block_Sales_Order_Shipment_Packaging\\:\\:getQtyOrderedItem\\(\\) should return int\\|null but empty return statement found\\.$#" count: 1 path: app/code/core/Mage/Adminhtml/Block/Sales/Order/Shipment/Packaging.php - - - message: "#^Unreachable statement \\- code above always terminates\\.$#" - count: 6 - path: app/code/core/Mage/Adminhtml/Block/Sales/Order/Shipment/Packaging.php - - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Sales/Order/Shipment/View/Form.php - - message: "#^Return type \\(Mage_Sales_Model_Order_Shipment\\) of method Mage_Adminhtml_Block_Sales_Order_Shipment_View_Items\\:\\:getSource\\(\\) should be compatible with return type \\(Mage_Sales_Model_Order_Invoice\\) of method Mage_Adminhtml_Block_Sales_Items_Abstract\\:\\:getSource\\(\\)$#" count: 1 path: app/code/core/Mage/Adminhtml/Block/Sales/Order/Shipment/View/Items.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Sales/Order/Totalbar.php - - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Sales/Order/View/Giftmessage.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 2 - path: app/code/core/Mage/Adminhtml/Block/Sales/Order/View/Giftmessage.php - - - - message: "#^Right side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Sales/Order/View/Giftmessage.php - - - - message: "#^If condition is always true\\.$#" - count: 2 - path: app/code/core/Mage/Adminhtml/Block/Sales/Order/View/Info.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Sales/Order/View/Info.php - - - - message: "#^Unreachable statement \\- code above always terminates\\.$#" - count: 2 - path: app/code/core/Mage/Adminhtml/Block/Sales/Order/View/Info.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Sales/Order/View/Items.php - - message: "#^Property Mage_Adminhtml_Block_Sales_Order_View_Items_Renderer_Default\\:\\:\\$_giftMessage \\(Mage_GiftMessage_Model_Message\\) does not accept default value of type array\\.$#" count: 1 @@ -570,11 +295,6 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/Block/Sales/Order/View/Tab/Shipments.php - - - message: "#^Ternary operator condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Sales/Transactions/Grid.php - - message: "#^Property Mage_Adminhtml_Block_Shipping_Carrier_Tablerate_Grid\\:\\:\\$_conditionName \\(string\\) does not accept int\\.$#" count: 1 @@ -606,67 +326,22 @@ parameters: path: app/code/core/Mage/Adminhtml/Block/System/Config/Form.php - - message: "#^Else branch is unreachable because previous condition is always true\\.$#" + message: "#^Method Mage_Core_Model_Email_Template\\:\\:getProcessedTemplate\\(\\) invoked with 2 parameters, 0\\-1 required\\.$#" count: 1 - path: app/code/core/Mage/Adminhtml/Block/System/Config/Form.php + path: app/code/core/Mage/Adminhtml/Block/System/Email/Template/Preview.php - - message: "#^If condition is always true\\.$#" + message: "#^Call to an undefined method Mage_Tag_Model_Resource_Tag_Collection\\:\\:addAttributeToFilter\\(\\)\\.$#" count: 1 - path: app/code/core/Mage/Adminhtml/Block/System/Config/Form.php + path: app/code/core/Mage/Adminhtml/Block/Tag/Grid/All.php - - message: "#^Negated boolean expression is always false\\.$#" + message: "#^Binary operation \"\\*\" between string and 1 results in an error\\.$#" count: 1 - path: app/code/core/Mage/Adminhtml/Block/System/Config/Form.php + path: app/code/core/Mage/Adminhtml/Block/Tax/Rate/Grid/Renderer/Data.php - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/System/Config/Tabs.php - - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/System/Email/Template/Edit.php - - - - message: "#^Method Mage_Core_Model_Email_Template\\:\\:getProcessedTemplate\\(\\) invoked with 2 parameters, 0\\-1 required\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/System/Email/Template/Preview.php - - - - message: "#^Call to an undefined method Mage_Tag_Model_Resource_Tag_Collection\\:\\:addAttributeToFilter\\(\\)\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Tag/Grid/All.php - - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Tag/Grid/All.php - - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Tag/Grid/Customers.php - - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Tax/Rate/Grid.php - - - - message: "#^Binary operation \"\\*\" between string and 1 results in an error\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Tax/Rate/Grid/Renderer/Data.php - - - - message: "#^If condition is always true\\.$#" - count: 2 - path: app/code/core/Mage/Adminhtml/Block/Tax/Rule/Grid.php - - - - message: "#^Variable \\$category in empty\\(\\) always exists and is not falsy\\.$#" + message: "#^Variable \\$category in empty\\(\\) always exists and is not falsy\\.$#" count: 1 path: app/code/core/Mage/Adminhtml/Block/Urlrewrite/Category/Tree.php @@ -680,21 +355,6 @@ parameters: count: 2 path: app/code/core/Mage/Adminhtml/Block/Widget/Form.php - - - message: "#^Unreachable statement \\- code above always terminates\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Widget/Form.php - - - - message: "#^Else branch is unreachable because ternary operator condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Widget/Grid.php - - - - message: "#^If condition is always true\\.$#" - count: 3 - path: app/code/core/Mage/Adminhtml/Block/Widget/Grid.php - - message: "#^Property Mage_Adminhtml_Block_Widget_Grid\\:\\:\\$defaultColumnSettings \\(array\\\\>\\) does not accept default value of type array\\\\>\\.$#" count: 1 @@ -730,21 +390,6 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/Controller/Report/Abstract.php - - - message: "#^If condition is always true\\.$#" - count: 2 - path: app/code/core/Mage/Adminhtml/Controller/Sales/Creditmemo.php - - - - message: "#^If condition is always true\\.$#" - count: 2 - path: app/code/core/Mage/Adminhtml/Controller/Sales/Invoice.php - - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Controller/Sales/Shipment.php - - message: "#^Property Mage_Adminhtml_Model_Config\\:\\:\\$_config \\(Mage_Core_Model_Config_Base\\) does not accept Varien_Simplexml_Config\\.$#" count: 1 @@ -770,41 +415,11 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/Model/Giftmessage/Save.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 3 - path: app/code/core/Mage/Adminhtml/Model/Giftmessage/Save.php - - - - message: "#^If condition is always false\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Model/Sales/Order.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Model/Sales/Order.php - - - - message: "#^If condition is always true\\.$#" - count: 5 - path: app/code/core/Mage/Adminhtml/Model/Sales/Order/Create.php - - - - message: "#^Left side of && is always true\\.$#" - count: 2 - path: app/code/core/Mage/Adminhtml/Model/Sales/Order/Create.php - - message: "#^Method Mage_Adminhtml_Model_Sales_Order_Create\\:\\:initFromOrderItem\\(\\) should return Mage_Sales_Model_Quote_Item\\|string but returns \\$this\\(Mage_Adminhtml_Model_Sales_Order_Create\\)\\.$#" count: 2 path: app/code/core/Mage/Adminhtml/Model/Sales/Order/Create.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 2 - path: app/code/core/Mage/Adminhtml/Model/Sales/Order/Create.php - - message: "#^Right side of && is always true\\.$#" count: 2 @@ -860,11 +475,6 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/controllers/Customer/Wishlist/Product/Composite/WishlistController.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 3 - path: app/code/core/Mage/Adminhtml/controllers/CustomerController.php - - message: "#^Call to an undefined method Varien_Simplexml_Element\\:\\:getClassName\\(\\)\\.$#" count: 1 @@ -875,21 +485,11 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/controllers/Permissions/BlockController.php - - - message: "#^Comparison operation \"\\>\\=\" between int\\<1, max\\> and 1 is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/controllers/Permissions/UserController.php - - message: "#^Variable \\$id in isset\\(\\) always exists and is not nullable\\.$#" count: 1 path: app/code/core/Mage/Adminhtml/controllers/Permissions/VariableController.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/controllers/PollController.php - - message: "#^Cannot call method aggregate\\(\\) on Mage_Core_Model_Resource_Db_Collection_Abstract\\|false\\.$#" count: 2 @@ -940,11 +540,6 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/controllers/Sales/Order/InvoiceController.php - - - message: "#^Call to function is_object\\(\\) with array\\|string will always evaluate to false\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/controllers/Sales/Order/ShipmentController.php - - message: "#^Method Mage_Adminhtml_Sales_Order_ShipmentController\\:\\:getShippingItemsGridAction\\(\\) should return Mage_Core_Controller_Response_Http but returns Zend_Controller_Response_Abstract\\.$#" count: 1 @@ -955,31 +550,11 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/controllers/Sales/Order/ShipmentController.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/controllers/Sales/OrderController.php - - message: "#^Method Mage_Adminhtml_Controller_Action\\:\\:_setForcedFormKeyActions\\(\\) invoked with 2 parameters, 1 required\\.$#" count: 1 path: app/code/core/Mage/Adminhtml/controllers/Sales/OrderController.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/controllers/Sales/Recurring/ProfileController.php - - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/controllers/System/Config/System/StorageController.php - - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/controllers/System/Config/System/StorageController.php - - message: "#^Variable \\$data in isset\\(\\) always exists and is not nullable\\.$#" count: 1 @@ -995,11 +570,6 @@ parameters: count: 2 path: app/code/core/Mage/Adminhtml/controllers/System/StoreController.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 6 - path: app/code/core/Mage/Adminhtml/controllers/System/StoreController.php - - message: "#^Method Mage_Directory_Model_Country\\:\\:loadByCode\\(\\) invoked with 2 parameters, 1 required\\.$#" count: 1 @@ -1065,11 +635,6 @@ parameters: count: 2 path: app/code/core/Mage/Api/Model/Server/Handler/Abstract.php - - - message: "#^Instanceof between Mage_Core_Model_Abstract\\|false and Mage_Api_Model_Resource_Abstract will always evaluate to false\\.$#" - count: 1 - path: app/code/core/Mage/Api/Model/Server/Handler/Abstract.php - - message: "#^Method Mage_Api_Model_Session\\:\\:isSessionExpired\\(\\) invoked with 0 parameters, 1 required\\.$#" count: 1 @@ -1150,36 +715,11 @@ parameters: count: 1 path: app/code/core/Mage/Api2/Model/Acl.php - - - message: "#^Strict comparison using \\=\\=\\= between int and null will always evaluate to false\\.$#" - count: 1 - path: app/code/core/Mage/Api2/Model/Acl/Global.php - - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Api2/Model/Acl/Global/Rule/ResourcePermission.php - - - - message: "#^Instanceof between Mage_Core_Model_Abstract\\|false and Mage_Api2_Model_Auth_Adapter_Abstract will always evaluate to false\\.$#" - count: 1 - path: app/code/core/Mage/Api2/Model/Auth/Adapter.php - - - - message: "#^Unreachable statement \\- code above always terminates\\.$#" - count: 1 - path: app/code/core/Mage/Api2/Model/Auth/Adapter.php - - message: "#^Method Mage_Api2_Model_Config\\:\\:getResourceGroup\\(\\) should return bool\\|Mage_Core_Model_Config_Element but returns Varien_Simplexml_Element\\.$#" count: 1 path: app/code/core/Mage/Api2/Model/Config.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Api2/Model/Dispatcher.php - - message: "#^Call to an undefined method Mage_Api2_Model_Config\\:\\:getMainRoute\\(\\)\\.$#" count: 1 @@ -1220,16 +760,6 @@ parameters: count: 1 path: app/code/core/Mage/Api2/Model/Resource.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 6 - path: app/code/core/Mage/Api2/Model/Resource.php - - - - message: "#^Instanceof between Mage_Core_Model_Abstract and Mage_Eav_Model_Form will always evaluate to false\\.$#" - count: 1 - path: app/code/core/Mage/Api2/Model/Resource/Validator/Eav.php - - message: "#^Method Mage_Eav_Model_Entity_Attribute_Source_Interface\\:\\:getAllOptions\\(\\) invoked with 1 parameter, 0 required\\.$#" count: 1 @@ -1250,21 +780,6 @@ parameters: count: 1 path: app/code/core/Mage/Api2/Model/Resource/Validator/Eav.php - - - message: "#^Result of \\|\\| is always false\\.$#" - count: 1 - path: app/code/core/Mage/Api2/Model/Resource/Validator/Eav.php - - - - message: "#^Result of \\|\\| is always true\\.$#" - count: 1 - path: app/code/core/Mage/Api2/Model/Resource/Validator/Eav.php - - - - message: "#^Unreachable statement \\- code above always terminates\\.$#" - count: 1 - path: app/code/core/Mage/Api2/Model/Resource/Validator/Eav.php - - message: "#^Call to an undefined method Zend_Validate_Interface\\:\\:setMessage\\(\\)\\.$#" count: 1 @@ -1305,11 +820,6 @@ parameters: count: 1 path: app/code/core/Mage/Api2/Model/Route/ApiType.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Api2/Model/Server.php - - message: "#^Call to an undefined method Varien_Object\\:\\:decrypt\\(\\)\\.$#" count: 1 @@ -1390,11 +900,6 @@ parameters: count: 1 path: app/code/core/Mage/Bundle/Block/Adminhtml/Catalog/Product/Edit/Tab/Bundle/Option/Selection.php - - - message: "#^If condition is always true\\.$#" - count: 2 - path: app/code/core/Mage/Bundle/Block/Adminhtml/Sales/Order/Items/Renderer.php - - message: "#^Call to an undefined method Mage_Catalog_Model_Product_Type_Price\\:\\:getIsPricesCalculatedByIndex\\(\\)\\.$#" count: 1 @@ -1415,11 +920,6 @@ parameters: count: 1 path: app/code/core/Mage/Bundle/Helper/Catalog/Product/Configuration.php - - - message: "#^Ternary operator condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Bundle/Helper/Catalog/Product/Configuration.php - - message: "#^Call to an undefined method Mage_Bundle_Model_CatalogIndex_Data_Bundle\\:\\:_addAttributeFilter\\(\\)\\.$#" count: 1 @@ -1440,16 +940,6 @@ parameters: count: 1 path: app/code/core/Mage/Bundle/Model/CatalogIndex/Data/Bundle.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Bundle/Model/Option.php - - - - message: "#^Result of && is always false\\.$#" - count: 1 - path: app/code/core/Mage/Bundle/Model/Option.php - - message: "#^Call to an undefined method Mage_Bundle_Model_Resource_Price_Index\\:\\:reindexProduct\\(\\)\\.$#" count: 1 @@ -1460,26 +950,11 @@ parameters: count: 2 path: app/code/core/Mage/Bundle/Model/Product/Price.php - - - message: "#^Else branch is unreachable because ternary operator condition is always true\\.$#" - count: 2 - path: app/code/core/Mage/Bundle/Model/Product/Price.php - - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Bundle/Model/Product/Price.php - - message: "#^Method Mage_Bundle_Model_Product_Price\\:\\:getOptions\\(\\) should return Mage_Bundle_Model_Resource_Option_Collection but returns array\\.$#" count: 1 path: app/code/core/Mage/Bundle/Model/Product/Price.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 2 - path: app/code/core/Mage/Bundle/Model/Product/Price.php - - message: "#^Offset 'option_id' does not exist on array\\{final_price\\: mixed\\}\\.$#" count: 4 @@ -1510,16 +985,6 @@ parameters: count: 1 path: app/code/core/Mage/Bundle/Model/Product/Type.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Bundle/Model/Resource/Option/Collection.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Bundle/Model/Resource/Price/Index.php - - message: "#^Call to an undefined method Mage_Captcha_Model_Interface\\:\\:isRequired\\(\\)\\.$#" count: 1 @@ -1535,11 +1000,6 @@ parameters: count: 3 path: app/code/core/Mage/Captcha/Model/Observer.php - - - message: "#^Negated boolean expression is always true\\.$#" - count: 9 - path: app/code/core/Mage/Captcha/Model/Observer.php - - message: "#^Result of method Mage_Captcha_Model_Interface\\:\\:isCorrect\\(\\) \\(void\\) is used\\.$#" count: 9 @@ -1570,16 +1030,6 @@ parameters: count: 1 path: app/code/core/Mage/Catalog/Block/Breadcrumbs.php - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Block/Category/View.php - - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Block/Layer/View.php - - message: "#^Argument of an invalid type string supplied for foreach, only iterables are supported\\.$#" count: 1 @@ -1590,26 +1040,11 @@ parameters: count: 2 path: app/code/core/Mage/Catalog/Block/Navigation.php - - - message: "#^Comparison operation \"\\>\" between int\\<2, 7\\> and 0 is always true\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Block/Navigation.php - - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Block/Navigation.php - - message: "#^Property Mage_Catalog_Block_Navigation\\:\\:\\$_currentCategoryKey \\(string\\) does not accept int\\.$#" count: 1 path: app/code/core/Mage/Catalog/Block/Navigation.php - - - message: "#^Unreachable statement \\- code above always terminates\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Block/Navigation.php - - message: "#^Variable \\$htmlChildren in empty\\(\\) always exists and is always falsy\\.$#" count: 1 @@ -1617,13 +1052,8 @@ parameters: - message: "#^If condition is always true\\.$#" - count: 2 - path: app/code/core/Mage/Catalog/Block/Product.php - - - - message: "#^Left side of && is always true\\.$#" count: 1 - path: app/code/core/Mage/Catalog/Block/Product/Abstract.php + path: app/code/core/Mage/Catalog/Block/Product.php - message: "#^Property Mage_Catalog_Block_Product_Abstract\\:\\:\\$_reviewsHelperBlock \\(Mage_Review_Block_Helper\\|null\\) does not accept Mage_Core_Block_Abstract\\|false\\.$#" @@ -1675,36 +1105,11 @@ parameters: count: 1 path: app/code/core/Mage/Catalog/Block/Product/List/Toolbar.php - - - message: "#^Right side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Block/Product/List/Upsell.php - - message: "#^Property Mage_Catalog_Block_Product_New\\:\\:\\$_productsCount \\(null\\) does not accept int\\.$#" count: 2 path: app/code/core/Mage/Catalog/Block/Product/New.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Block/Product/Price.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Block/Product/View/Options.php - - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Block/Product/View/Options/Abstract.php - - - - message: "#^Unreachable statement \\- code above always terminates\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Block/Product/View/Options/Abstract.php - - message: "#^Method Mage_Catalog_Block_Product_View_Options_Type_Date\\:\\:_getValueWithLeadingZeros\\(\\) should return string but returns int\\.$#" count: 1 @@ -1720,11 +1125,6 @@ parameters: count: 1 path: app/code/core/Mage/Catalog/Block/Product/Widget/Html/Pager.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Block/Product/Widget/New.php - - message: "#^Property Mage_Catalog_Block_Product_Widget_New\\:\\:\\$_pager \\(Mage_Catalog_Block_Product_Widget_Html_Pager\\) does not accept Mage_Core_Block_Abstract\\|false\\.$#" count: 1 @@ -1756,24 +1156,19 @@ parameters: path: app/code/core/Mage/Catalog/Helper/Product.php - - message: "#^Negated boolean expression is always false\\.$#" + message: "#^Ternary operator condition is always true\\.$#" count: 1 - path: app/code/core/Mage/Catalog/Helper/Product/Compare.php + path: app/code/core/Mage/Catalog/Helper/Product.php - - message: "#^Property Mage_Catalog_Helper_Product_Compare\\:\\:\\$_itemCollection \\(Mage_Catalog_Model_Resource_Eav_Mysql4_Product_Compare_Item_Collection\\) does not accept Mage_Catalog_Model_Resource_Product_Compare_Item_Collection\\.$#" + message: "#^Method Mage_Catalog_Helper_Product_Compare\\:\\:getItemCollection\\(\\) should return Mage_Catalog_Model_Resource_Eav_Mysql4_Product_Compare_Item_Collection but returns Mage_Catalog_Model_Resource_Product_Compare_Item_Collection\\.$#" count: 1 path: app/code/core/Mage/Catalog/Helper/Product/Compare.php - - message: "#^If condition is always true\\.$#" - count: 2 - path: app/code/core/Mage/Catalog/Helper/Product/Configuration.php - - - - message: "#^Left side of && is always true\\.$#" + message: "#^Property Mage_Catalog_Helper_Product_Compare\\:\\:\\$_itemCollection \\(Mage_Catalog_Model_Resource_Eav_Mysql4_Product_Compare_Item_Collection\\) does not accept Mage_Catalog_Model_Resource_Product_Compare_Item_Collection\\.$#" count: 1 - path: app/code/core/Mage/Catalog/Helper/Product/Configuration.php + path: app/code/core/Mage/Catalog/Helper/Product/Compare.php - message: "#^Call to an undefined method Mage_Core_Model_Abstract\\:\\:loadSelf\\(\\)\\.$#" @@ -1835,11 +1230,6 @@ parameters: count: 1 path: app/code/core/Mage/Catalog/Model/Api2/Product/Validator/Product.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Model/Api2/Product/Validator/Product.php - - message: "#^Call to an undefined method Varien_Object\\:\\:formatUrlKey\\(\\)\\.$#" count: 1 @@ -1865,21 +1255,11 @@ parameters: count: 1 path: app/code/core/Mage/Catalog/Model/Category.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 2 - path: app/code/core/Mage/Catalog/Model/Category.php - - message: "#^Cannot call method getRootCategoryId\\(\\) on int\\|string\\.$#" count: 1 path: app/code/core/Mage/Catalog/Model/Category/Api.php - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Model/Category/Api.php - - message: "#^Method Mage_Eav_Model_Entity_Attribute_Source_Interface\\:\\:getAllOptions\\(\\) invoked with 1 parameter, 0 required\\.$#" count: 1 @@ -1900,11 +1280,6 @@ parameters: count: 2 path: app/code/core/Mage/Catalog/Model/Config.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Model/Convert/Adapter/Catalog.php - - message: "#^Call to an undefined method Mage_Eav_Model_Entity_Abstract\\:\\:getStoreId\\(\\)\\.$#" count: 1 @@ -1935,21 +1310,6 @@ parameters: count: 1 path: app/code/core/Mage/Catalog/Model/Convert/Parser/Product.php - - - message: "#^Call to function is_array\\(\\) with bool\\|string will always evaluate to false\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Model/Convert/Parser/Product.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Model/Convert/Parser/Product.php - - - - message: "#^Left side of && is always true\\.$#" - count: 4 - path: app/code/core/Mage/Catalog/Model/Design.php - - message: "#^Method Mage_Catalog_Model_Category\\:\\:getParentDesignCategory\\(\\) invoked with 1 parameter, 0 required\\.$#" count: 1 @@ -1995,11 +1355,6 @@ parameters: count: 1 path: app/code/core/Mage/Catalog/Model/Layer/Filter/Attribute.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Model/Layer/Filter/Category.php - - message: "#^Parameter \\#2 \\$filterBlock \\(Mage_Catalog_Block_Layer_Filter_Decimal\\) of method Mage_Catalog_Model_Layer_Filter_Decimal\\:\\:apply\\(\\) should be compatible with parameter \\$filterBlock \\(null\\) of method Mage_Catalog_Model_Layer_Filter_Abstract\\:\\:apply\\(\\)$#" count: 1 @@ -2010,11 +1365,6 @@ parameters: count: 1 path: app/code/core/Mage/Catalog/Model/Observer.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 2 - path: app/code/core/Mage/Catalog/Model/Observer.php - - message: "#^Call to an undefined method Mage_Eav_Model_Entity_Attribute_Backend_Abstract\\:\\:addImage\\(\\)\\.$#" count: 1 @@ -2035,31 +1385,16 @@ parameters: count: 1 path: app/code/core/Mage/Catalog/Model/Product.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Model/Product.php - - message: "#^Property Mage_Catalog_Model_Product\\:\\:\\$_typeInstance \\(Mage_Catalog_Model_Product_Type_Abstract\\) does not accept Mage_Core_Model_Abstract\\|false\\.$#" count: 1 path: app/code/core/Mage/Catalog/Model/Product.php - - - message: "#^Strict comparison using \\=\\=\\= between \\*NEVER\\* and true will always evaluate to false\\.$#" - count: 2 - path: app/code/core/Mage/Catalog/Model/Product/Api.php - - message: "#^Parameter \\#3 \\$attributes \\(stdClass\\) of method Mage_Catalog_Model_Product_Api_V2\\:\\:info\\(\\) should be compatible with parameter \\$attributes \\(array\\) of method Mage_Catalog_Model_Product_Api\\:\\:info\\(\\)$#" count: 1 path: app/code/core/Mage/Catalog/Model/Product/Api/V2.php - - - message: "#^Strict comparison using \\=\\=\\= between \\*NEVER\\* and true will always evaluate to false\\.$#" - count: 2 - path: app/code/core/Mage/Catalog/Model/Product/Api/V2.php - - message: "#^Cannot call method getBackend\\(\\) on bool\\|Mage_Catalog_Model_Resource_Attribute\\.$#" count: 11 @@ -2070,11 +1405,6 @@ parameters: count: 1 path: app/code/core/Mage/Catalog/Model/Product/Attribute/Media/Api/V2.php - - - message: "#^Strict comparison using \\=\\=\\= between \\*NEVER\\* and true will always evaluate to false\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Model/Product/Attribute/Tierprice/Api.php - - message: "#^Access to an undefined property object\\:\\:\\$customer_group_id\\.$#" count: 1 @@ -2095,11 +1425,6 @@ parameters: count: 1 path: app/code/core/Mage/Catalog/Model/Product/Flat/Indexer.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Model/Product/Image.php - - message: "#^Cannot call method isIndexable\\(\\) on Mage_Eav_Model_Entity_Attribute_Abstract\\|false\\.$#" count: 1 @@ -2115,16 +1440,6 @@ parameters: count: 1 path: app/code/core/Mage/Catalog/Model/Product/Option.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Model/Product/Option.php - - - - message: "#^Unreachable statement \\- code above always terminates\\.$#" - count: 2 - path: app/code/core/Mage/Catalog/Model/Product/Option/Type/Default.php - - message: "#^Call to an undefined method Mage_Catalog_Model_Product_Configuration_Item_Option_Interface\\:\\:getId\\(\\)\\.$#" count: 2 @@ -2142,17 +1457,7 @@ parameters: - message: "#^Elseif condition is always true\\.$#" - count: 3 - path: app/code/core/Mage/Catalog/Model/Product/Option/Type/Select.php - - - - message: "#^If condition is always true\\.$#" - count: 6 - path: app/code/core/Mage/Catalog/Model/Product/Option/Type/Select.php - - - - message: "#^Left side of && is always true\\.$#" - count: 1 + count: 2 path: app/code/core/Mage/Catalog/Model/Product/Option/Type/Select.php - @@ -2165,21 +1470,11 @@ parameters: count: 1 path: app/code/core/Mage/Catalog/Model/Product/Type.php - - - message: "#^Call to function is_string\\(\\) with array will always evaluate to false\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Model/Product/Type/Abstract.php - - message: "#^Call to function is_array\\(\\) with string will always evaluate to false\\.$#" count: 1 path: app/code/core/Mage/Catalog/Model/Product/Type/Configurable.php - - - message: "#^If condition is always true\\.$#" - count: 2 - path: app/code/core/Mage/Catalog/Model/Product/Type/Configurable.php - - message: "#^Method Mage_Catalog_Model_Product_Type_Configurable\\:\\:getProductByAttributes\\(\\) should return Mage_Catalog_Model_Product\\|null but returns Varien_Object\\.$#" count: 1 @@ -2230,11 +1525,6 @@ parameters: count: 1 path: app/code/core/Mage/Catalog/Model/Resource/Attribute.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Model/Resource/Category.php - - message: "#^Method Mage_Catalog_Model_Resource_Category\\:\\:getChildrenAmount\\(\\) should return int but returns string\\|false\\|null\\.$#" count: 1 @@ -2245,11 +1535,6 @@ parameters: count: 1 path: app/code/core/Mage/Catalog/Model/Resource/Category.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Model/Resource/Category.php - - message: "#^Property Mage_Catalog_Model_Resource_Category\\:\\:\\$_isActiveAttributeId \\(int\\) does not accept string\\|false\\|null\\.$#" count: 1 @@ -2305,31 +1590,16 @@ parameters: count: 1 path: app/code/core/Mage/Catalog/Model/Resource/Category/Tree.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Model/Resource/Category/Tree.php - - message: "#^Method Mage_Catalog_Model_Resource_Category_Tree\\:\\:_getItemIsActive\\(\\) invoked with 2 parameters, 1 required\\.$#" count: 1 path: app/code/core/Mage/Catalog/Model/Resource/Category/Tree.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Model/Resource/Category/Tree.php - - message: "#^Parameter \\#1 \\$category \\(Mage_Catalog_Model_Category\\) of method Mage_Catalog_Model_Resource_Category_Tree\\:\\:move\\(\\) should be compatible with parameter \\$node \\(Varien_Data_Tree_Node\\) of method Varien_Data_Tree_Dbp\\:\\:move\\(\\)$#" count: 1 path: app/code/core/Mage/Catalog/Model/Resource/Category/Tree.php - - - message: "#^Result of && is always false\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Model/Resource/Category/Tree.php - - message: "#^Property Mage_Catalog_Model_Resource_Config\\:\\:\\$_storeId \\(int\\) on left side of \\?\\? is not nullable\\.$#" count: 1 @@ -2385,11 +1655,6 @@ parameters: count: 1 path: app/code/core/Mage/Catalog/Model/Resource/Product/Collection.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Model/Resource/Product/Collection.php - - message: "#^Method Mage_Catalog_Model_Resource_Product_Collection\\:\\:_addUrlRewrite\\(\\) invoked with 1 parameter, 0 required\\.$#" count: 1 @@ -2430,61 +1695,16 @@ parameters: count: 1 path: app/code/core/Mage/Catalog/Model/Resource/Product/Indexer/Price.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Model/Resource/Product/Link/Collection.php - - message: "#^Left side of && is always true\\.$#" count: 1 - path: app/code/core/Mage/Catalog/Model/Resource/Product/Link/Collection.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Model/Resource/Product/Link/Collection.php - - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Model/Resource/Product/Link/Product/Collection.php - - - - message: "#^Left side of && is always true\\.$#" - count: 2 - path: app/code/core/Mage/Catalog/Model/Resource/Product/Link/Product/Collection.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 2 path: app/code/core/Mage/Catalog/Model/Resource/Product/Link/Product/Collection.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Model/Resource/Product/Option/Collection.php - - message: "#^Property Mage_Catalog_Model_Url\\:\\:\\$_saveRewritesHistory \\(bool\\) on left side of \\?\\? is not nullable\\.$#" count: 1 path: app/code/core/Mage/Catalog/Model/Url.php - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/controllers/CategoryController.php - - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/controllers/ProductController.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/controllers/ProductController.php - - message: "#^Call to an undefined method Mage_CatalogIndex_Model_Resource_Attribute\\:\\:checkCount\\(\\)\\.$#" count: 1 @@ -2515,11 +1735,6 @@ parameters: count: 1 path: app/code/core/Mage/CatalogIndex/Model/Indexer.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/CatalogIndex/Model/Indexer.php - - message: "#^Variable \\$kill in isset\\(\\) always exists and is not nullable\\.$#" count: 1 @@ -2530,26 +1745,11 @@ parameters: count: 1 path: app/code/core/Mage/CatalogIndex/Model/Indexer/Eav.php - - - message: "#^Call to function is_null\\(\\) with string will always evaluate to false\\.$#" - count: 1 - path: app/code/core/Mage/CatalogIndex/Model/Indexer/Minimalprice.php - - message: "#^Return type \\(string\\) of method Mage_CatalogIndex_Model_Indexer_Price\\:\\:_getIndexableAttributeConditions\\(\\) should be compatible with return type \\(array\\) of method Mage_CatalogIndex_Model_Indexer_Abstract\\:\\:_getIndexableAttributeConditions\\(\\)$#" count: 1 path: app/code/core/Mage/CatalogIndex/Model/Indexer/Price.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/CatalogIndex/Model/Price.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/CatalogIndex/Model/Resource/Aggregation.php - - message: "#^Method Mage_CatalogIndex_Model_Resource_Indexer_Abstract\\:\\:saveIndex\\(\\) with return type void returns mixed but should not return anything\\.$#" count: 1 @@ -2561,7 +1761,7 @@ parameters: path: app/code/core/Mage/CatalogIndex/Model/Retreiver.php - - message: "#^Negated boolean expression is always false\\.$#" + message: "#^Method Mage_CatalogInventory_Block_Adminhtml_Form_Field_Minsaleqty\\:\\:_getGroupRenderer\\(\\) should return Mage_CatalogInventory_Block_Adminhtml_Form_Field_Customergroup but returns Mage_Core_Block_Abstract\\|false\\.$#" count: 1 path: app/code/core/Mage/CatalogInventory/Block/Adminhtml/Form/Field/Minsaleqty.php @@ -2570,21 +1770,11 @@ parameters: count: 1 path: app/code/core/Mage/CatalogInventory/Block/Adminhtml/Form/Field/Minsaleqty.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/CatalogInventory/Model/Observer.php - - message: "#^Method Mage_CatalogInventory_Model_Observer\\:\\:_getQuoteItemQtyForCheck\\(\\) should return int but returns float\\.$#" count: 1 path: app/code/core/Mage/CatalogInventory/Model/Observer.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/CatalogInventory/Model/Observer.php - - message: "#^Cannot call method setTypeId\\(\\) on Mage_Core_Model_Resource_Db_Collection_Abstract\\|false\\.$#" count: 1 @@ -2610,66 +1800,26 @@ parameters: count: 1 path: app/code/core/Mage/CatalogInventory/Model/Stock/Item.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/CatalogInventory/Model/Stock/Status.php - - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/CatalogRule/Model/Action/Index/Refresh.php - - message: "#^Return type \\(int\\) of method Mage_CatalogRule_Model_Action_Index_Refresh_Row\\:\\:_getProduct\\(\\) should be compatible with return type \\(null\\) of method Mage_CatalogRule_Model_Action_Index_Refresh\\:\\:_getProduct\\(\\)$#" count: 1 path: app/code/core/Mage/CatalogRule/Model/Action/Index/Refresh/Row.php - - - message: "#^Call to function is_null\\(\\) with int will always evaluate to false\\.$#" - count: 1 - path: app/code/core/Mage/CatalogRule/Model/Observer.php - - message: "#^Call to an undefined method Mage_Rule_Model_Condition_Combine\\:\\:collectValidatedAttributes\\(\\)\\.$#" count: 1 path: app/code/core/Mage/CatalogRule/Model/Rule.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/CatalogRule/Model/Rule.php - - message: "#^Method Mage_Eav_Model_Entity_Attribute_Source_Interface\\:\\:getAllOptions\\(\\) invoked with 1 parameter, 0 required\\.$#" count: 1 path: app/code/core/Mage/CatalogSearch/Block/Advanced/Form.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/CatalogSearch/Block/Autocomplete.php - - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/CatalogSearch/Helper/Data.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 3 - path: app/code/core/Mage/CatalogSearch/Helper/Data.php - - message: "#^Property Mage_CatalogSearch_Helper_Data\\:\\:\\$_queryText \\(string\\) in isset\\(\\) is not nullable\\.$#" count: 1 path: app/code/core/Mage/CatalogSearch/Helper/Data.php - - - message: "#^Call to function is_array\\(\\) with bool\\|string will always evaluate to false\\.$#" - count: 1 - path: app/code/core/Mage/CatalogSearch/Model/Advanced.php - - message: "#^Method Mage_CatalogSearch_Model_Advanced\\:\\:getProductCollection\\(\\) should return Mage_CatalogSearch_Model_Resource_Advanced_Collection but returns array\\|float\\|int\\|string\\|false\\|null\\.$#" count: 1 @@ -2681,34 +1831,9 @@ parameters: path: app/code/core/Mage/CatalogSearch/Model/Layer/Filter/Attribute.php - - message: "#^Call to function is_array\\(\\) with bool\\|string will always evaluate to false\\.$#" + message: "#^Property Mage_CatalogSearch_Model_Resource_Fulltext_Collection\\:\\:\\$_relevanceSortOrder \\(null\\) does not accept default value of type int\\.$#" count: 1 - path: app/code/core/Mage/CatalogSearch/Model/Resource/Fulltext.php - - - - message: "#^If condition is always true\\.$#" - count: 4 - path: app/code/core/Mage/CatalogSearch/Model/Resource/Fulltext.php - - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/CatalogSearch/Model/Resource/Fulltext.php - - - - message: "#^Unreachable statement \\- code above always terminates\\.$#" - count: 1 - path: app/code/core/Mage/CatalogSearch/Model/Resource/Fulltext.php - - - - message: "#^If condition is always false\\.$#" - count: 1 - path: app/code/core/Mage/CatalogSearch/Model/Resource/Fulltext/Collection.php - - - - message: "#^Property Mage_CatalogSearch_Model_Resource_Fulltext_Collection\\:\\:\\$_relevanceSortOrder \\(null\\) does not accept default value of type int\\.$#" - count: 1 - path: app/code/core/Mage/CatalogSearch/Model/Resource/Fulltext/Collection.php + path: app/code/core/Mage/CatalogSearch/Model/Resource/Fulltext/Collection.php - message: "#^Property Mage_CatalogSearch_Model_Resource_Fulltext_Collection\\:\\:\\$_relevanceSortOrder \\(null\\) does not accept int\\.$#" @@ -2721,27 +1846,7 @@ parameters: path: app/code/core/Mage/CatalogSearch/Model/Resource/Search/Collection.php - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/CatalogSearch/Model/Resource/Search/Collection.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Centinel/Block/Adminhtml/Validation.php - - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Centinel/Block/Adminhtml/Validation/Form.php - - - - message: "#^Right side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Centinel/Block/Adminhtml/Validation/Form.php - - - - message: "#^If condition is always true\\.$#" + message: "#^Cannot call method setMethod\\(\\) on object\\|false\\.$#" count: 1 path: app/code/core/Mage/Centinel/Helper/Data.php @@ -2750,31 +1855,11 @@ parameters: count: 1 path: app/code/core/Mage/Checkout/Block/Cart/Abstract.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Checkout/Block/Cart/Crosssell.php - - message: "#^Variable \\$ninProductIds in empty\\(\\) always exists and is not falsy\\.$#" count: 1 path: app/code/core/Mage/Checkout/Block/Cart/Crosssell.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Checkout/Block/Cart/Item/Renderer.php - - - - message: "#^Right side of && is always false\\.$#" - count: 1 - path: app/code/core/Mage/Checkout/Block/Cart/Item/Renderer.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Checkout/Block/Cart/Item/Renderer/Configurable.php - - message: "#^Property Mage_Checkout_Block_Cart_Shipping\\:\\:\\$_address \\(array\\) does not accept Mage_Sales_Model_Quote_Address\\.$#" count: 1 @@ -2786,17 +1871,7 @@ parameters: path: app/code/core/Mage/Checkout/Block/Cart/Sidebar.php - - message: "#^Left side of && is always true\\.$#" - count: 2 - path: app/code/core/Mage/Checkout/Block/Links.php - - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Checkout/Block/Onepage/Abstract.php - - - - message: "#^Negated boolean expression is always false\\.$#" + message: "#^Method Mage_Checkout_Block_Onepage_Billing\\:\\:_getTaxvat\\(\\) should return Mage_Customer_Block_Widget_Taxvat but returns Mage_Core_Block_Abstract\\|false\\.$#" count: 1 path: app/code/core/Mage/Checkout/Block/Onepage/Billing.php @@ -2805,11 +1880,6 @@ parameters: count: 1 path: app/code/core/Mage/Checkout/Block/Onepage/Billing.php - - - message: "#^Right side of && is always true\\.$#" - count: 3 - path: app/code/core/Mage/Checkout/Block/Onepage/Billing.php - - message: "#^Method Mage_Checkout_Block_Onepage_Progress\\:\\:getShippingPriceInclTax\\(\\) should return float but returns string\\.$#" count: 1 @@ -2820,36 +1890,6 @@ parameters: count: 1 path: app/code/core/Mage/Checkout/Block/Onepage/Success.php - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Checkout/Controller/Action.php - - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Checkout/Helper/Data.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Checkout/Helper/Data.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 5 - path: app/code/core/Mage/Checkout/Model/Cart.php - - - - message: "#^Result of && is always false\\.$#" - count: 1 - path: app/code/core/Mage/Checkout/Model/Cart.php - - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Checkout/Model/Cart/Api.php - - message: "#^Negated boolean expression is always false\\.$#" count: 1 @@ -2870,11 +1910,6 @@ parameters: count: 1 path: app/code/core/Mage/Checkout/Model/Cart/Customer/Api/V2.php - - - message: "#^Right side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Checkout/Model/Cart/Payment/Api.php - - message: "#^Parameter \\#1 \\$data \\(object\\) of method Mage_Checkout_Model_Cart_Payment_Api_V2\\:\\:_preparePaymentData\\(\\) should be compatible with parameter \\$data \\(array\\) of method Mage_Checkout_Model_Cart_Payment_Api\\:\\:_preparePaymentData\\(\\)$#" count: 1 @@ -2885,11 +1920,6 @@ parameters: count: 1 path: app/code/core/Mage/Checkout/Model/Cart/Payment/Api/V2.php - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Checkout/Model/Cart/Product/Api.php - - message: "#^Method Mage_Checkout_Model_Cart_Product_Api_V2\\:\\:_prepareProductsData\\(\\) should return array but returns mixed\\.$#" count: 1 @@ -2905,41 +1935,16 @@ parameters: count: 1 path: app/code/core/Mage/Checkout/Model/Type/Abstract.php - - - message: "#^If condition is always true\\.$#" - count: 2 - path: app/code/core/Mage/Checkout/Model/Type/Abstract.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 2 - path: app/code/core/Mage/Checkout/Model/Type/Abstract.php - - - - message: "#^If condition is always true\\.$#" - count: 4 - path: app/code/core/Mage/Checkout/Model/Type/Multishipping.php - - message: "#^Method Mage_Sales_Model_Quote\\:\\:getBillingAddress\\(\\) invoked with 1 parameter, 0 required\\.$#" count: 1 path: app/code/core/Mage/Checkout/Model/Type/Multishipping.php - - - message: "#^Right side of && is always true\\.$#" - count: 2 - path: app/code/core/Mage/Checkout/Model/Type/Multishipping.php - - message: "#^Variable \\$paymentMethod in empty\\(\\) always exists and is not falsy\\.$#" count: 1 path: app/code/core/Mage/Checkout/Model/Type/Multishipping.php - - - message: "#^If condition is always true\\.$#" - count: 2 - path: app/code/core/Mage/Checkout/Model/Type/Onepage.php - - message: "#^Negated boolean expression is always true\\.$#" count: 1 @@ -2950,51 +1955,16 @@ parameters: count: 1 path: app/code/core/Mage/Checkout/Model/Type/Onepage.php - - - message: "#^Right side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Checkout/Model/Type/Onepage.php - - message: "#^Comparison operation \"\\=\\=\" between 0\\|0\\.0\\|array\\|string\\|false\\|null and 0 results in an error\\.$#" count: 1 path: app/code/core/Mage/Checkout/controllers/CartController.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Checkout/controllers/CartController.php - - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Checkout/controllers/CartController.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 2 - path: app/code/core/Mage/Checkout/controllers/CartController.php - - message: "#^Call to an undefined method Mage_Sales_Model_Service_Order\\:\\:register\\(\\)\\.$#" count: 1 path: app/code/core/Mage/Checkout/controllers/OnepageController.php - - - message: "#^Call to function is_null\\(\\) with Mage_Sales_Model_Order will always evaluate to false\\.$#" - count: 1 - path: app/code/core/Mage/Checkout/controllers/OnepageController.php - - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Cms/Helper/Page.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 2 - path: app/code/core/Mage/Cms/Helper/Page.php - - message: "#^Method Mage_Cms_Model_Wysiwyg_Images_Storage\\:\\:getConfig\\(\\) should return Mage_Core_Model_Config_Element but returns Varien_Simplexml_Element\\|false\\.$#" count: 1 @@ -3010,16 +1980,6 @@ parameters: count: 1 path: app/code/core/Mage/ConfigurableSwatches/Helper/Productimg.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/ConfigurableSwatches/Helper/Productlist.php - - - - message: "#^If condition is always true\\.$#" - count: 3 - path: app/code/core/Mage/Core/Block/Abstract.php - - message: "#^Method Mage_Core_Block_Abstract\\:\\:_getUrlModel\\(\\) should return Mage_Core_Model_Url but returns Mage_Core_Model_Abstract\\|false\\.$#" count: 1 @@ -3035,76 +1995,16 @@ parameters: count: 1 path: app/code/core/Mage/Core/Block/Abstract.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 2 - path: app/code/core/Mage/Core/Block/Abstract.php - - - - message: "#^Result of && is always false\\.$#" - count: 1 - path: app/code/core/Mage/Core/Block/Abstract.php - - - - message: "#^Right side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Core/Block/Abstract.php - - - - message: "#^Unreachable statement \\- code above always terminates\\.$#" - count: 1 - path: app/code/core/Mage/Core/Block/Abstract.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Core/Block/Flush.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Core/Block/Html/Select.php - - message: "#^Ternary operator condition is always true\\.$#" count: 1 path: app/code/core/Mage/Core/Block/Messages.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Core/Block/Profiler.php - - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Core/Block/Template.php - - - - message: "#^Unreachable statement \\- code above always terminates\\.$#" - count: 1 - path: app/code/core/Mage/Core/Block/Template.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Core/Block/Text.php - - message: "#^Call to an undefined method Zend_Controller_Router_Interface\\:\\:addRoute\\(\\)\\.$#" count: 1 path: app/code/core/Mage/Core/Controller/Front/Router.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Core/Controller/Request/Http.php - - - - message: "#^Strict comparison using \\=\\=\\= between string and null will always evaluate to false\\.$#" - count: 2 - path: app/code/core/Mage/Core/Controller/Request/Http.php - - message: "#^Call to an undefined method Varien_Simplexml_Element\\:\\:is\\(\\)\\.$#" count: 1 @@ -3115,11 +2015,6 @@ parameters: count: 1 path: app/code/core/Mage/Core/Controller/Varien/Action.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Core/Controller/Varien/Action.php - - message: "#^Property Mage_Core_Controller_Varien_Action\\:\\:\\$_request \\(Mage_Core_Controller_Request_Http\\) does not accept Zend_Controller_Request_Abstract\\.$#" count: 1 @@ -3140,11 +2035,6 @@ parameters: count: 1 path: app/code/core/Mage/Core/Controller/Varien/Front.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Core/Controller/Varien/Front.php - - message: "#^Method Mage_Core_Controller_Varien_Front\\:\\:_getRequestRewriteController\\(\\) should return Mage_Core_Model_Url_Rewrite_Request but returns bool\\|Mage_Core_Model_Abstract\\.$#" count: 1 @@ -3170,16 +2060,6 @@ parameters: count: 1 path: app/code/core/Mage/Core/Helper/Abstract.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Core/Helper/Abstract.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Core/Helper/String.php - - message: "#^Property Mage_Core_Helper_String\\:\\:\\$_arrayHelper \\(Mage_Core_Helper_Array\\) does not accept Mage_Core_Helper_Abstract\\.$#" count: 1 @@ -3190,11 +2070,6 @@ parameters: count: 1 path: app/code/core/Mage/Core/Model/Abstract.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Core/Model/Abstract.php - - message: "#^Property Mage_Core_Model_Abstract\\:\\:\\$_cacheTag \\(string\\|true\\) does not accept default value of type false\\.$#" count: 1 @@ -3215,11 +2090,6 @@ parameters: count: 1 path: app/code/core/Mage/Core/Model/App.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 6 - path: app/code/core/Mage/Core/Model/App.php - - message: "#^Property Mage_Core_Model_App\\:\\:\\$_request \\(Mage_Core_Controller_Request_Http\\) in empty\\(\\) is not falsy\\.$#" count: 1 @@ -3240,11 +2110,6 @@ parameters: count: 1 path: app/code/core/Mage/Core/Model/App.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Core/Model/Cache.php - - message: "#^Method Mage_Core_Model_Cache\\:\\:getDbAdapter\\(\\) should return Zend_Db_Adapter_Abstract but returns Varien_Db_Adapter_Interface\\|false\\.$#" count: 1 @@ -3290,11 +2155,6 @@ parameters: count: 1 path: app/code/core/Mage/Core/Model/Config.php - - - message: "#^Strict comparison using \\=\\=\\= between int\\|string and false will always evaluate to false\\.$#" - count: 1 - path: app/code/core/Mage/Core/Model/Config.php - - message: "#^Method Mage_Core_Model_Cookie\\:\\:getHttponly\\(\\) should return bool but returns null\\.$#" count: 1 @@ -3345,11 +2205,6 @@ parameters: count: 1 path: app/code/core/Mage/Core/Model/Design/Package.php - - - message: "#^Right side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Core/Model/Email.php - - message: "#^Method Zend_Mail\\:\\:addBcc\\(\\) invoked with 2 parameters, 1 required\\.$#" count: 1 @@ -3370,11 +2225,6 @@ parameters: count: 1 path: app/code/core/Mage/Core/Model/Encryption.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Core/Model/Encryption.php - - message: "#^Method Mage_Core_Model_Factory\\:\\:getUrlRewriteInstance\\(\\) should return Mage_Core_Model_Url_Rewrite but returns bool\\|Mage_Core_Model_Abstract\\.$#" count: 1 @@ -3390,16 +2240,6 @@ parameters: count: 1 path: app/code/core/Mage/Core/Model/File/Storage.php - - - message: "#^Call to function is_string\\(\\) with array will always evaluate to false\\.$#" - count: 1 - path: app/code/core/Mage/Core/Model/File/Validator/NotProtectedExtension.php - - - - message: "#^Elseif condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Core/Model/Input/Filter.php - - message: "#^PHPDoc tag @param for parameter \\$filter with type array\\|Zend_Filter_Interface is not subtype of native type Zend_Filter_Interface\\.$#" count: 1 @@ -3435,11 +2275,6 @@ parameters: count: 1 path: app/code/core/Mage/Core/Model/Layout.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 2 - path: app/code/core/Mage/Core/Model/Layout.php - - message: "#^Method Mage_Core_Model_Layout_Update\\:\\:saveCache\\(\\) should return bool but returns Mage_Core_Model_App\\.$#" count: 1 @@ -3470,41 +2305,11 @@ parameters: count: 1 path: app/code/core/Mage/Core/Model/Resource.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Core/Model/Resource/Cache.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Core/Model/Resource/Cache.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Core/Model/Resource/Config.php - - - - message: "#^Left side of && is always true\\.$#" - count: 2 - path: app/code/core/Mage/Core/Model/Resource/Db/Abstract.php - - message: "#^Method Mage_Core_Model_Resource_Db_Abstract\\:\\:_getConnection\\(\\) should return Magento_Db_Adapter_Pdo_Mysql but returns Varien_Db_Adapter_Interface\\|false\\.$#" count: 1 path: app/code/core/Mage/Core/Model/Resource/Db/Abstract.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Core/Model/Resource/Db/Abstract.php - - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Core/Model/Resource/Db/Collection/Abstract.php - - message: "#^Property Mage_Core_Model_Resource_Db_Collection_Abstract\\:\\:\\$_resource \\(Mage_Core_Model_Resource_Db_Abstract\\) does not accept Mage_Core_Model_Resource_Db_Collection_Abstract\\|false\\.$#" count: 1 @@ -3550,31 +2355,11 @@ parameters: count: 1 path: app/code/core/Mage/Core/Model/Resource/Iterator.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Core/Model/Resource/Layout.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 2 - path: app/code/core/Mage/Core/Model/Resource/Resource.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Core/Model/Resource/Session.php - - message: "#^Call to an undefined method Varien_Simplexml_Element\\:\\:getClassName\\(\\)\\.$#" count: 2 path: app/code/core/Mage/Core/Model/Resource/Setup.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Core/Model/Resource/Setup.php - - message: "#^Property Mage_Core_Model_Resource_Setup\\:\\:\\$_conn \\(Varien_Db_Adapter_Pdo_Mysql\\) does not accept Varien_Db_Adapter_Interface\\|false\\.$#" count: 1 @@ -3600,21 +2385,11 @@ parameters: count: 1 path: app/code/core/Mage/Core/Model/Resource/Setup/Query/Modifier.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 2 - path: app/code/core/Mage/Core/Model/Resource/Translate.php - - message: "#^Right side of && is always true\\.$#" count: 1 path: app/code/core/Mage/Core/Model/Resource/Type/Db/Mysqli.php - - - message: "#^Right side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Core/Model/Resource/Type/Db/Pdo/Mysql.php - - message: "#^Parameter \\#2 \\$clear \\(bool\\) of method Mage_Core_Model_Session_Abstract_Varien\\:\\:getData\\(\\) should be compatible with parameter \\$index \\(int\\|string\\) of method Varien_Object\\:\\:getData\\(\\)$#" count: 1 @@ -3630,36 +2405,16 @@ parameters: count: 1 path: app/code/core/Mage/Core/Model/Session/Abstract/Zend.php - - - message: "#^Elseif condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Core/Model/Store.php - - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Core/Model/Store.php - - - - message: "#^Left side of && is always true\\.$#" - count: 3 - path: app/code/core/Mage/Core/Model/Store.php - - message: "#^Method Mage_Core_Model_Store\\:\\:_getSession\\(\\) should return Mage_Core_Model_Session but returns Mage_Core_Model_Session_Abstract\\.$#" count: 1 path: app/code/core/Mage/Core/Model/Store.php - - message: "#^Method Mage_Core_Model_Store\\:\\:getPriceFilter\\(\\) should return Varien_Filter_Sprintf but returns Mage_Directory_Model_Currency_Filter\\.$#" + message: "#^Method Mage_Core_Model_Store\\:\\:formatPrice\\(\\) should return string but returns float\\.$#" count: 1 path: app/code/core/Mage/Core/Model/Store.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 2 - path: app/code/core/Mage/Core/Model/Store.php - - message: "#^PHPDoc type bool of property Mage_Core_Model_Store\\:\\:\\$_cacheTag is not covariant with PHPDoc type string\\|true of overridden property Mage_Core_Model_Abstract\\:\\:\\$_cacheTag\\.$#" count: 1 @@ -3670,16 +2425,6 @@ parameters: count: 1 path: app/code/core/Mage/Core/Model/Store.php - - - message: "#^Right side of && is always true\\.$#" - count: 2 - path: app/code/core/Mage/Core/Model/Store.php - - - - message: "#^Unreachable statement \\- code above always terminates\\.$#" - count: 1 - path: app/code/core/Mage/Core/Model/Store.php - - message: "#^Argument of an invalid type string supplied for foreach, only iterables are supported\\.$#" count: 1 @@ -3690,11 +2435,6 @@ parameters: count: 1 path: app/code/core/Mage/Core/Model/Url.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 3 - path: app/code/core/Mage/Core/Model/Url.php - - message: "#^Negated boolean expression is always true\\.$#" count: 1 @@ -3705,31 +2445,16 @@ parameters: count: 1 path: app/code/core/Mage/Core/Model/Url/Rewrite.php - - - message: "#^Strict comparison using \\=\\=\\= between int and false will always evaluate to false\\.$#" - count: 1 - path: app/code/core/Mage/Core/Model/Url/Rewrite.php - - message: "#^Unreachable statement \\- code above always terminates\\.$#" count: 1 path: app/code/core/Mage/Core/Model/Url/Rewrite.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Core/Model/Url/Rewrite/Request.php - - message: "#^Negated boolean expression is always true\\.$#" count: 1 path: app/code/core/Mage/Core/Model/Url/Rewrite/Request.php - - - message: "#^Strict comparison using \\=\\=\\= between int and false will always evaluate to false\\.$#" - count: 1 - path: app/code/core/Mage/Core/Model/Url/Rewrite/Request.php - - message: "#^Unreachable statement \\- code above always terminates\\.$#" count: 1 @@ -3750,16 +2475,6 @@ parameters: count: 1 path: app/code/core/Mage/CurrencySymbol/Block/Adminhtml/System/Currencysymbol.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/CurrencySymbol/Helper/Data.php - - - - message: "#^Else branch is unreachable because ternary operator condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/CurrencySymbol/Model/System/Currencysymbol.php - - message: "#^Property Mage_CurrencySymbol_Model_System_Currencysymbol\\:\\:\\$_storeId \\(string\\|null\\) does not accept int\\|null\\.$#" count: 1 @@ -3770,36 +2485,16 @@ parameters: count: 1 path: app/code/core/Mage/CurrencySymbol/Model/System/Currencysymbol.php - - - message: "#^Else branch is unreachable because previous condition is always true\\.$#" - count: 2 - path: app/code/core/Mage/Customer/Block/Account/Dashboard/Address.php - - message: "#^Call to an undefined method Mage_Wishlist_Model_Resource_Item_Collection\\:\\:addAttributeToSelect\\(\\)\\.$#" count: 1 path: app/code/core/Mage/Customer/Block/Account/Dashboard/Sidebar.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Customer/Block/Account/Dashboard/Sidebar.php - - message: "#^Property Mage_Customer_Block_Account_Navigation\\:\\:\\$_activeLink \\(bool\\) does not accept string\\.$#" count: 2 path: app/code/core/Mage/Customer/Block/Account/Navigation.php - - - message: "#^Left side of \\|\\| is always true\\.$#" - count: 1 - path: app/code/core/Mage/Customer/Block/Address/Book.php - - - - message: "#^Right side of \\|\\| is always true\\.$#" - count: 1 - path: app/code/core/Mage/Customer/Block/Address/Book.php - - message: "#^Method Mage_Customer_Block_Address_Edit\\:\\:getCountryId\\(\\) should return int but returns string\\.$#" count: 1 @@ -3840,11 +2535,6 @@ parameters: count: 1 path: app/code/core/Mage/Customer/Helper/Data.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Customer/Model/Address/Abstract.php - - message: "#^Cannot access property \\$is_default_billing on array\\.$#" count: 2 @@ -3870,51 +2560,16 @@ parameters: count: 1 path: app/code/core/Mage/Customer/Model/Convert/Adapter/Customer.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Customer/Model/Convert/Adapter/Customer.php - - message: "#^Call to an undefined method Mage_Eav_Model_Entity_Abstract\\:\\:setStore\\(\\)\\.$#" count: 1 path: app/code/core/Mage/Customer/Model/Convert/Parser/Customer.php - - - message: "#^Call to function is_array\\(\\) with bool\\|string will always evaluate to false\\.$#" - count: 1 - path: app/code/core/Mage/Customer/Model/Convert/Parser/Customer.php - - - - message: "#^If condition is always true\\.$#" - count: 2 - path: app/code/core/Mage/Customer/Model/Convert/Parser/Customer.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Customer/Model/Convert/Parser/Customer.php - - - - message: "#^If condition is always true\\.$#" - count: 4 - path: app/code/core/Mage/Customer/Model/Customer.php - - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Customer/Model/Customer.php - - message: "#^Method Mage_Directory_Model_Region\\:\\:loadByName\\(\\) invoked with 1 parameter, 2 required\\.$#" count: 1 path: app/code/core/Mage/Customer/Model/Customer.php - - - message: "#^Ternary operator condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Customer/Model/Customer.php - - message: "#^Parameter \\#1 \\$data \\(stdClass\\) of method Mage_Customer_Model_Customer_Api_V2\\:\\:_prepareData\\(\\) should be compatible with parameter \\$data \\(array\\) of method Mage_Customer_Model_Customer_Api\\:\\:_prepareData\\(\\)$#" count: 1 @@ -3930,21 +2585,6 @@ parameters: count: 1 path: app/code/core/Mage/Customer/Model/Resource/Customer.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Customer/Model/Session.php - - - - message: "#^Right side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Customer/Model/Session.php - - - - message: "#^Unreachable statement \\- code above always terminates\\.$#" - count: 2 - path: app/code/core/Mage/Customer/Model/Session.php - - message: "#^Cannot call method addAttributeToSelect\\(\\) on Mage_Core_Model_Resource_Db_Collection_Abstract\\|false\\.$#" count: 1 @@ -4005,11 +2645,6 @@ parameters: count: 1 path: app/code/core/Mage/Dataflow/Model/Convert/Action/Abstract.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Dataflow/Model/Convert/Action/Abstract.php - - message: "#^Property Mage_Dataflow_Model_Convert_Action_Abstract\\:\\:\\$_container \\(Mage_Dataflow_Model_Convert_Container_Abstract\\) does not accept Mage_Dataflow_Model_Convert_Container_Interface\\.$#" count: 1 @@ -4020,36 +2655,16 @@ parameters: count: 1 path: app/code/core/Mage/Dataflow/Model/Convert/Action/Abstract.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Dataflow/Model/Convert/Adapter/Db/Table.php - - message: "#^If condition is always false\\.$#" count: 1 path: app/code/core/Mage/Dataflow/Model/Convert/Adapter/Io.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Dataflow/Model/Convert/Adapter/Io.php - - message: "#^Negated boolean expression is always true\\.$#" - count: 3 + count: 2 path: app/code/core/Mage/Dataflow/Model/Convert/Adapter/Io.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Dataflow/Model/Convert/Adapter/Zend/Cache.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Dataflow/Model/Convert/Adapter/Zend/Db.php - - message: "#^Call to an undefined method Mage_Dataflow_Model_Convert_Container_Interface\\:\\:getName\\(\\)\\.$#" count: 2 @@ -4086,8 +2701,8 @@ parameters: path: app/code/core/Mage/Dataflow/Model/Profile.php - - message: "#^Negated boolean expression is always false\\.$#" - count: 2 + message: "#^Method Mage_Directory_Helper_Data\\:\\:getCountryCollection\\(\\) should return Mage_Directory_Model_Resource_Country_Collection but returns Mage_Core_Model_Resource_Db_Collection_Abstract\\.$#" + count: 1 path: app/code/core/Mage/Directory/Helper/Data.php - @@ -4095,21 +2710,11 @@ parameters: count: 1 path: app/code/core/Mage/Directory/Helper/Data.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Directory/Model/Country.php - - message: "#^Method Mage_Directory_Model_Country\\:\\:getFormat\\(\\) should return Mage_Directory_Model_Country_Format but returns null\\.$#" count: 1 path: app/code/core/Mage/Directory/Model/Country.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Directory/Model/Currency.php - - message: "#^Method Mage_Directory_Model_Currency_Import_Webservicex\\:\\:_convert\\(\\) should return float\\|null but return statement is missing\\.$#" count: 1 @@ -4130,26 +2735,11 @@ parameters: count: 1 path: app/code/core/Mage/Downloadable/Block/Adminhtml/Catalog/Product/Edit/Tab/Downloadable/Links.php - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Downloadable/Block/Adminhtml/Catalog/Product/Edit/Tab/Downloadable/Samples.php - - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Downloadable/Block/Adminhtml/Sales/Items/Column/Downloadable/Name.php - - message: "#^Left side of && is always true\\.$#" count: 1 path: app/code/core/Mage/Downloadable/Block/Catalog/Product/Links.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Downloadable/Helper/Catalog/Product/Configuration.php - - message: "#^Cannot call method streamRead\\(\\) on resource\\.$#" count: 1 @@ -4160,26 +2750,11 @@ parameters: count: 1 path: app/code/core/Mage/Downloadable/Helper/Download.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Downloadable/Helper/File.php - - message: "#^Parameter \\#2 \\$resource \\(object\\) of method Mage_Downloadable_Model_Link_Api_V2\\:\\:add\\(\\) should be compatible with parameter \\$resource \\(array\\) of method Mage_Downloadable_Model_Link_Api\\:\\:add\\(\\)$#" count: 1 path: app/code/core/Mage/Downloadable/Model/Link/Api/V2.php - - - message: "#^Left side of && is always true\\.$#" - count: 2 - path: app/code/core/Mage/Downloadable/Model/Observer.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Downloadable/Model/Observer.php - - message: "#^If condition is always true\\.$#" count: 1 @@ -4206,12 +2781,7 @@ parameters: path: app/code/core/Mage/Downloadable/controllers/Product/EditController.php - - message: "#^Call to function is_array\\(\\) with string will always evaluate to false\\.$#" - count: 1 - path: app/code/core/Mage/Eav/Block/Adminhtml/Attribute/Edit/Options/Abstract.php - - - - message: "#^Call to an undefined method Mage_Eav_Model_Resource_Entity_Attribute\\:\\:getUsedInForms\\(\\)\\.$#" + message: "#^Call to an undefined method Mage_Eav_Model_Resource_Entity_Attribute\\:\\:getUsedInForms\\(\\)\\.$#" count: 1 path: app/code/core/Mage/Eav/Model/Attribute.php @@ -4220,11 +2790,6 @@ parameters: count: 1 path: app/code/core/Mage/Eav/Model/Attribute/Data/Abstract.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 2 - path: app/code/core/Mage/Eav/Model/Attribute/Data/Abstract.php - - message: "#^Property Mage_Eav_Model_Attribute_Data_Abstract\\:\\:\\$_attribite \\(Mage_Eav_Model_Attribute\\) does not accept Mage_Eav_Model_Entity_Attribute_Abstract\\.$#" count: 1 @@ -4245,11 +2810,6 @@ parameters: count: 1 path: app/code/core/Mage/Eav/Model/Config.php - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Eav/Model/Config.php - - message: "#^Method Mage_Eav_Model_Config\\:\\:getAttribute\\(\\) should return Mage_Eav_Model_Entity_Attribute_Abstract\\|false but returns Mage_Eav_Model_Entity_Attribute_Interface\\.$#" count: 1 @@ -4281,17 +2841,12 @@ parameters: path: app/code/core/Mage/Eav/Model/Convert/Adapter/Grid.php - - message: "#^Call to function is_string\\(\\) with Varien_Db_Adapter_Pdo_Mysql will always evaluate to false\\.$#" - count: 2 - path: app/code/core/Mage/Eav/Model/Entity/Abstract.php - - - - message: "#^Method Mage_Eav_Model_Entity_Abstract\\:\\:_getReadAdapter\\(\\) should return Magento_Db_Adapter_Pdo_Mysql but returns Varien_Db_Adapter_Pdo_Mysql\\.$#" + message: "#^Method Mage_Eav_Model_Entity_Abstract\\:\\:_getReadAdapter\\(\\) should return Magento_Db_Adapter_Pdo_Mysql but returns Varien_Db_Adapter_Interface\\|false\\.$#" count: 1 path: app/code/core/Mage/Eav/Model/Entity/Abstract.php - - message: "#^Method Mage_Eav_Model_Entity_Abstract\\:\\:_getWriteAdapter\\(\\) should return Magento_Db_Adapter_Pdo_Mysql but returns Varien_Db_Adapter_Pdo_Mysql\\.$#" + message: "#^Method Mage_Eav_Model_Entity_Abstract\\:\\:_getWriteAdapter\\(\\) should return Magento_Db_Adapter_Pdo_Mysql but returns Varien_Db_Adapter_Interface\\|false\\.$#" count: 1 path: app/code/core/Mage/Eav/Model/Entity/Abstract.php @@ -4330,11 +2885,6 @@ parameters: count: 1 path: app/code/core/Mage/Eav/Model/Entity/Attribute/Abstract.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Eav/Model/Entity/Attribute/Abstract.php - - message: "#^Property Mage_Eav_Model_Entity_Attribute_Abstract\\:\\:\\$_backend \\(Mage_Eav_Model_Entity_Attribute_Backend_Abstract\\) in empty\\(\\) is not falsy\\.$#" count: 1 @@ -4360,16 +2910,6 @@ parameters: count: 1 path: app/code/core/Mage/Eav/Model/Entity/Attribute/Backend/Abstract.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Eav/Model/Entity/Attribute/Frontend/Abstract.php - - - - message: "#^Unreachable statement \\- code above always terminates\\.$#" - count: 1 - path: app/code/core/Mage/Eav/Model/Entity/Attribute/Frontend/Abstract.php - - message: "#^Variable \\$out in empty\\(\\) always exists and is not falsy\\.$#" count: 1 @@ -4395,11 +2935,6 @@ parameters: count: 1 path: app/code/core/Mage/Eav/Model/Entity/Collection/Abstract.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 2 - path: app/code/core/Mage/Eav/Model/Entity/Collection/Abstract.php - - message: "#^Property Mage_Eav_Model_Entity_Collection_Abstract\\:\\:\\$_entity \\(Mage_Eav_Model_Entity_Abstract\\) in empty\\(\\) is not falsy\\.$#" count: 1 @@ -4440,16 +2975,6 @@ parameters: count: 1 path: app/code/core/Mage/Eav/Model/Entity/Type.php - - - message: "#^Ternary operator condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Eav/Model/Resource/Attribute/Collection.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Eav/Model/Resource/Config.php - - message: "#^Method Mage_Eav_Model_Resource_Entity_Attribute\\:\\:_getMaxSortOrder\\(\\) should return int but returns string\\|false\\|null\\.$#" count: 1 @@ -4480,36 +3005,6 @@ parameters: count: 2 path: app/code/core/Mage/Eav/Model/Resource/Form/Type.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/GiftMessage/Block/Adminhtml/Sales/Order/Create/Items.php - - - - message: "#^If condition is always true\\.$#" - count: 2 - path: app/code/core/Mage/GiftMessage/Block/Adminhtml/Sales/Order/View/Items.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 2 - path: app/code/core/Mage/GiftMessage/Block/Adminhtml/Sales/Order/View/Items.php - - - - message: "#^Unreachable statement \\- code above always terminates\\.$#" - count: 1 - path: app/code/core/Mage/GiftMessage/Block/Adminhtml/Sales/Order/View/Items.php - - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/GiftMessage/Helper/Message.php - - - - message: "#^Unreachable statement \\- code above always terminates\\.$#" - count: 1 - path: app/code/core/Mage/GiftMessage/Helper/Message.php - - message: "#^Method Mage_GiftMessage_Model_Api_V2\\:\\:_prepareData\\(\\) should return array but returns mixed\\.$#" count: 1 @@ -4525,11 +3020,6 @@ parameters: count: 1 path: app/code/core/Mage/GiftMessage/Model/Message.php - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/GiftMessage/Model/Observer.php - - message: "#^Call to an undefined method Mage_Eav_Model_Entity_Abstract\\:\\:setGiftMessageId\\(\\)\\.$#" count: 1 @@ -4595,31 +3085,11 @@ parameters: count: 1 path: app/code/core/Mage/ImportExport/Helper/Data.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/ImportExport/Model/Abstract.php - - message: "#^If condition is always true\\.$#" count: 1 path: app/code/core/Mage/ImportExport/Model/Export.php - - - message: "#^Instanceof between Mage_Core_Model_Abstract\\|false and Mage_ImportExport_Model_Export_Adapter_Abstract will always evaluate to false\\.$#" - count: 1 - path: app/code/core/Mage/ImportExport/Model/Export.php - - - - message: "#^Instanceof between Mage_Core_Model_Abstract\\|false and Mage_ImportExport_Model_Export_Entity_Abstract will always evaluate to false\\.$#" - count: 1 - path: app/code/core/Mage/ImportExport/Model/Export.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 2 - path: app/code/core/Mage/ImportExport/Model/Export.php - - message: "#^Property Mage_ImportExport_Model_Export\\:\\:\\$_entityAdapter \\(Mage_ImportExport_Model_Export_Entity_Abstract\\) does not accept Mage_Core_Model_Abstract\\|false\\.$#" count: 1 @@ -4630,21 +3100,11 @@ parameters: count: 1 path: app/code/core/Mage/ImportExport/Model/Export.php - - - message: "#^Unreachable statement \\- code above always terminates\\.$#" - count: 1 - path: app/code/core/Mage/ImportExport/Model/Export.php - - message: "#^Method Mage_Eav_Model_Entity_Attribute_Source_Interface\\:\\:getAllOptions\\(\\) invoked with 1 parameter, 0 required\\.$#" count: 1 path: app/code/core/Mage/ImportExport/Model/Export/Entity/Abstract.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/ImportExport/Model/Export/Entity/Abstract.php - - message: "#^Property Mage_ImportExport_Model_Export_Entity_Abstract\\:\\:\\$_connection \\(Varien_Db_Adapter_Pdo_Mysql\\) does not accept Varien_Db_Adapter_Interface\\|false\\.$#" count: 1 @@ -4675,36 +3135,16 @@ parameters: count: 1 path: app/code/core/Mage/ImportExport/Model/Export/Entity/Product.php - - - message: "#^Instanceof between Mage_Core_Model_Abstract and Mage_ImportExport_Model_Export_Entity_Product_Type_Abstract will always evaluate to false\\.$#" - count: 1 - path: app/code/core/Mage/ImportExport/Model/Export/Entity/Product.php - - message: "#^Offset int\\|string on non\\-empty\\-array\\ in isset\\(\\) always exists and is not nullable\\.$#" count: 2 path: app/code/core/Mage/ImportExport/Model/Export/Entity/Product.php - - - message: "#^Unreachable statement \\- code above always terminates\\.$#" - count: 1 - path: app/code/core/Mage/ImportExport/Model/Export/Entity/Product.php - - message: "#^Binary operation \"\\+\" between string and 50\\|int\\<100, max\\> results in an error\\.$#" count: 1 path: app/code/core/Mage/ImportExport/Model/Import.php - - - message: "#^Instanceof between Mage_Core_Model_Abstract\\|false and Mage_ImportExport_Model_Import_Entity_Abstract will always evaluate to false\\.$#" - count: 1 - path: app/code/core/Mage/ImportExport/Model/Import.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/ImportExport/Model/Import.php - - message: "#^Property Mage_ImportExport_Model_Import\\:\\:\\$_entityAdapter \\(Mage_ImportExport_Model_Import_Entity_Abstract\\) does not accept Mage_Core_Model_Abstract\\|false\\.$#" count: 1 @@ -4715,21 +3155,11 @@ parameters: count: 1 path: app/code/core/Mage/ImportExport/Model/Import.php - - - message: "#^Unreachable statement \\- code above always terminates\\.$#" - count: 1 - path: app/code/core/Mage/ImportExport/Model/Import.php - - message: "#^Method Mage_Eav_Model_Entity_Attribute_Source_Interface\\:\\:getAllOptions\\(\\) invoked with 1 parameter, 0 required\\.$#" count: 1 path: app/code/core/Mage/ImportExport/Model/Import/Entity/Abstract.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 2 - path: app/code/core/Mage/ImportExport/Model/Import/Entity/Abstract.php - - message: "#^Property Mage_ImportExport_Model_Import_Entity_Abstract\\:\\:\\$_connection \\(Varien_Convert_Adapter_Interface\\) does not accept Varien_Db_Adapter_Interface\\|false\\.$#" count: 1 @@ -4815,11 +3245,6 @@ parameters: count: 2 path: app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php - - - message: "#^Instanceof between Mage_Core_Model_Abstract and Mage_ImportExport_Model_Import_Entity_Product_Type_Abstract will always evaluate to false\\.$#" - count: 1 - path: app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php - - message: "#^Method Mage_ImportExport_Model_Import_Entity_Product\\:\\:getConnection\\(\\) should return Varien_Db_Adapter_Pdo_Mysql but returns Varien_Convert_Adapter_Interface\\.$#" count: 1 @@ -4840,16 +3265,6 @@ parameters: count: 1 path: app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php - - - message: "#^Unreachable statement \\- code above always terminates\\.$#" - count: 1 - path: app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php - - - - message: "#^Else branch is unreachable because previous condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/ImportExport/Model/Resource/Import/Data.php - - message: "#^Method Mage_Index_Model_Lock\\:\\:getInstance\\(\\) should return \\$this\\(Mage_Index_Model_Lock\\) but returns Mage_Index_Model_Lock\\.$#" count: 1 @@ -4885,11 +3300,6 @@ parameters: count: 1 path: app/code/core/Mage/Index/Model/Lock/Storage/Db.php - - - message: "#^If condition is always true\\.$#" - count: 2 - path: app/code/core/Mage/Index/Model/Process.php - - message: "#^Call to function is_array\\(\\) with '' will always evaluate to false\\.$#" count: 1 @@ -4900,11 +3310,6 @@ parameters: count: 1 path: app/code/core/Mage/Index/Model/Resource/Lock/Resource.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Index/Model/Resource/Setup.php - - message: "#^Return type \\(void\\) of method Mage_Index_Model_Resource_Setup\\:\\:applyUpdates\\(\\) should be compatible with return type \\(\\$this\\(Mage_Core_Model_Resource_Setup\\)\\|true\\) of method Mage_Core_Model_Resource_Setup\\:\\:applyUpdates\\(\\)$#" count: 1 @@ -4920,11 +3325,6 @@ parameters: count: 1 path: app/code/core/Mage/Install/Model/Installer.php - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Install/Model/Installer.php - - message: "#^Method Mage_Install_Model_Installer\\:\\:getDataModel\\(\\) should return Mage_Install_Model_Session but returns Mage_Install_Model_Installer_Data\\|null\\.$#" count: 1 @@ -4945,11 +3345,6 @@ parameters: count: 1 path: app/code/core/Mage/Install/Model/Installer/Db.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 2 - path: app/code/core/Mage/Install/Model/Installer/Db.php - - message: "#^Property Mage_Install_Model_Installer_Db\\:\\:\\$_dbResource \\(resource\\) does not accept Mage_Core_Model_Abstract\\.$#" count: 1 @@ -5005,16 +3400,6 @@ parameters: count: 2 path: app/code/core/Mage/Log/Model/Resource/Log.php - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Newsletter/Model/Resource/Template.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Oauth/Block/Adminhtml/Oauth/Consumer/Edit.php - - message: "#^Call to an undefined method Mage_Core_Model_Abstract\\:\\:authenticate\\(\\)\\.$#" count: 1 @@ -5030,16 +3415,6 @@ parameters: count: 1 path: app/code/core/Mage/Oauth/controllers/Customer/TokenController.php - - - message: "#^Negated boolean expression is always true\\.$#" - count: 1 - path: app/code/core/Mage/Page/Block/Html/Breadcrumbs.php - - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Page/Block/Html/Topmenu/Renderer.php - - message: "#^Call to an undefined method Mage_Payment_Model_Method_Abstract\\:\\:isPartialAuthorization\\(\\)\\.$#" count: 1 @@ -5050,16 +3425,6 @@ parameters: count: 1 path: app/code/core/Mage/Paygate/Model/Authorizenet.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Paygate/Model/Authorizenet.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Paygate/Model/Authorizenet/Cards.php - - message: "#^Call to an undefined method Mage_Payment_Model_Method_Abstract\\:\\:cancelPartialAuthorization\\(\\)\\.$#" count: 1 @@ -5070,44 +3435,19 @@ parameters: count: 1 path: app/code/core/Mage/Paygate/controllers/Authorizenet/PaymentController.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Payment/Block/Catalog/Product/View/Profile.php - - message: "#^Property Mage_Payment_Block_Catalog_Product_View_Profile\\:\\:\\$_profile \\(Mage_Payment_Model_Recurring_Profile\\) does not accept default value of type false\\.$#" count: 1 path: app/code/core/Mage/Payment/Block/Catalog/Product/View/Profile.php - - - message: "#^If condition is always true\\.$#" - count: 2 - path: app/code/core/Mage/Payment/Block/Form/Cc.php - - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Payment/Block/Form/Cc.php - - - - message: "#^Unreachable statement \\- code above always terminates\\.$#" - count: 1 - path: app/code/core/Mage/Payment/Block/Form/Cc.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 2 - path: app/code/core/Mage/Payment/Block/Info.php - - message: "#^Call to an undefined method Mage_Core_Model_Abstract\\:\\:isAvailable\\(\\)\\.$#" count: 1 path: app/code/core/Mage/Payment/Helper/Data.php - - message: "#^If condition is always true\\.$#" - count: 2 + message: "#^Cannot call method setInfo\\(\\) on object\\|false\\.$#" + count: 1 path: app/code/core/Mage/Payment/Helper/Data.php - @@ -5135,26 +3475,11 @@ parameters: count: 1 path: app/code/core/Mage/Payment/Model/Method/Cc.php - - - message: "#^If condition is always true\\.$#" - count: 2 - path: app/code/core/Mage/Payment/Model/Recurring/Profile.php - - message: "#^Method Mage_Payment_Model_Recurring_Profile\\:\\:exportStartDatetime\\(\\) should return string\\|Zend_Date but empty return statement found\\.$#" count: 1 path: app/code/core/Mage/Payment/Model/Recurring/Profile.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 6 - path: app/code/core/Mage/Payment/Model/Recurring/Profile.php - - - - message: "#^Result of \\|\\| is always false\\.$#" - count: 1 - path: app/code/core/Mage/Payment/Model/Recurring/Profile.php - - message: "#^Method Mage_Paypal_Block_Adminhtml_System_Config_Fieldset_Group\\:\\:_getCollapseState\\(\\) should return bool but returns int\\.$#" count: 1 @@ -5170,21 +3495,6 @@ parameters: count: 1 path: app/code/core/Mage/Paypal/Block/Express/Review.php - - - message: "#^Right side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Paypal/Block/Express/Review.php - - - - message: "#^Right side of \\|\\| is always true\\.$#" - count: 1 - path: app/code/core/Mage/Paypal/Block/Express/Review/Billing.php - - - - message: "#^Right side of \\|\\| is always true\\.$#" - count: 1 - path: app/code/core/Mage/Paypal/Block/Express/Review/Shipping.php - - message: "#^Return type \\(false\\) of method Mage_Paypal_Block_Hosted_Pro_Info\\:\\:getCcTypeName\\(\\) should be compatible with return type \\(string\\|null\\) of method Mage_Paypal_Block_Payment_Info\\:\\:getCcTypeName\\(\\)$#" count: 1 @@ -5195,11 +3505,6 @@ parameters: count: 1 path: app/code/core/Mage/Paypal/Block/Iframe.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 2 - path: app/code/core/Mage/Paypal/Block/Iframe.php - - message: "#^Property Mage_Paypal_Block_Iframe\\:\\:\\$_block \\(Mage_Payment_Block_Form\\) does not accept Mage_Core_Block_Abstract\\|false\\.$#" count: 1 @@ -5210,16 +3515,6 @@ parameters: count: 1 path: app/code/core/Mage/Paypal/Block/Payflow/Link/Info.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Paypal/Controller/Express/Abstract.php - - - - message: "#^Left side of && is always true\\.$#" - count: 2 - path: app/code/core/Mage/Paypal/Controller/Express/Abstract.php - - message: "#^Method Mage_Paypal_Controller_Express_Abstract\\:\\:_initCheckout\\(\\) should return Mage_Paypal_Model_Express_Checkout but returns Mage_Core_Model_Abstract\\.$#" count: 1 @@ -5230,11 +3525,6 @@ parameters: count: 1 path: app/code/core/Mage/Paypal/Controller/Express/Abstract.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Paypal/Controller/Express/Abstract.php - - message: "#^Property Mage_Paypal_Controller_Express_Abstract\\:\\:\\$_checkout \\(Mage_Paypal_Model_Express_Checkout\\) does not accept Mage_Core_Model_Abstract\\.$#" count: 1 @@ -5250,26 +3540,11 @@ parameters: count: 1 path: app/code/core/Mage/Paypal/Controller/Express/Abstract.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Paypal/Helper/Hss.php - - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Paypal/Helper/Hss.php - - message: "#^Method Mage_Paypal_Model_Api_Abstract\\:\\:_exportLineItems\\(\\) should return bool but empty return statement found\\.$#" count: 2 path: app/code/core/Mage/Paypal/Model/Api/Abstract.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Paypal/Model/Api/Abstract.php - - message: "#^Call to an undefined method Mage_Paypal_Model_Api_Nvp\\:\\:_export\\(\\)\\.$#" count: 1 @@ -5290,11 +3565,6 @@ parameters: count: 1 path: app/code/core/Mage/Paypal/Model/Api/Nvp.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Paypal/Model/Api/Nvp.php - - message: "#^Method Mage_Paypal_Model_Api_Standard\\:\\:_exportLineItems\\(\\) should return true\\|null but empty return statement found\\.$#" count: 1 @@ -5305,11 +3575,6 @@ parameters: count: 1 path: app/code/core/Mage/Paypal/Model/Api/Standard.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Paypal/Model/Api/Standard.php - - message: "#^Call to an undefined method Varien_Object\\:\\:isNominal\\(\\)\\.$#" count: 1 @@ -5325,6 +3590,11 @@ parameters: count: 1 path: app/code/core/Mage/Paypal/Model/Cart.php + - + message: "#^Method Mage_Paypal_Model_Config\\:\\:_matchBnCountryCode\\(\\) is unused\\.$#" + count: 1 + path: app/code/core/Mage/Paypal/Model/Config.php + - message: "#^Negated boolean expression is always true\\.$#" count: 1 @@ -5360,26 +3630,6 @@ parameters: count: 2 path: app/code/core/Mage/Paypal/Model/Express/Checkout.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Paypal/Model/Express/Checkout.php - - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Paypal/Model/Express/Checkout.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Paypal/Model/Express/Checkout.php - - - - message: "#^Right side of && is always true\\.$#" - count: 2 - path: app/code/core/Mage/Paypal/Model/Express/Checkout.php - - message: "#^Return type \\(bool\\) of method Mage_Paypal_Model_Hostedpro\\:\\:getAllowedCcTypes\\(\\) should be compatible with return type \\(string\\) of method Mage_Paypal_Model_Direct\\:\\:getAllowedCcTypes\\(\\)$#" count: 1 @@ -5395,16 +3645,6 @@ parameters: count: 1 path: app/code/core/Mage/Paypal/Model/Ipn.php - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Paypal/Model/Ipn.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Paypal/Model/Payflowlink.php - - message: "#^Return type \\(bool\\) of method Mage_Paypal_Model_Payflowlink\\:\\:validate\\(\\) should be compatible with return type \\(\\$this\\(Mage_Payment_Model_Method_Cc\\)\\) of method Mage_Payment_Model_Method_Cc\\:\\:validate\\(\\)$#" count: 1 @@ -5450,21 +3690,11 @@ parameters: count: 1 path: app/code/core/Mage/Paypal/controllers/HostedproController.php - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Paypal/controllers/PayflowController.php - - message: "#^Method Mage_Paypal_PayflowController\\:\\:_getIframeBlock\\(\\) should return Mage_Paypal_Block_Payflow_Link_Iframe but returns Mage_Core_Block_Abstract\\|false\\.$#" count: 1 path: app/code/core/Mage/Paypal/controllers/PayflowController.php - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Paypal/controllers/PayflowadvancedController.php - - message: "#^Method Mage_Paypal_PayflowadvancedController\\:\\:_getIframeBlock\\(\\) should return Mage_Paypal_Block_Payflow_Advanced_Iframe but returns Mage_Core_Block_Abstract\\|false\\.$#" count: 1 @@ -5475,36 +3705,16 @@ parameters: count: 1 path: app/code/core/Mage/PaypalUk/Model/Pro.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 2 - path: app/code/core/Mage/ProductAlert/Block/Product/View.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/ProductAlert/Block/Stock.php - - message: "#^Method Mage_ProductAlert_Helper_Data\\:\\:createBlock\\(\\) should return Mage_ProductAlert_Block_Email_Price\\|Mage_ProductAlert_Block_Email_Stock but returns Mage_Core_Block_Abstract\\.$#" count: 1 path: app/code/core/Mage/ProductAlert/Helper/Data.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 2 - path: app/code/core/Mage/ProductAlert/Model/Observer.php - - message: "#^Method Mage_ProductAlert_Model_Observer\\:\\:process\\(\\) invoked with 1 parameter, 0 required\\.$#" count: 1 path: app/code/core/Mage/ProductAlert/controllers/AddController.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/ProductAlert/controllers/AddController.php - - message: "#^Method Mage_Rating_Model_Resource_Rating\\:\\:getEntityIdByCode\\(\\) should return int but returns string\\|false\\|null\\.$#" count: 1 @@ -5515,11 +3725,6 @@ parameters: count: 1 path: app/code/core/Mage/Rating/Model/Resource/Rating.php - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Rating/Model/Resource/Rating/Collection.php - - message: "#^Method Mage_Rating_Model_Resource_Rating_Collection\\:\\:getItemById\\(\\) invoked with 1 parameter, 0 required\\.$#" count: 2 @@ -5565,11 +3770,6 @@ parameters: count: 1 path: app/code/core/Mage/Reports/Model/Resource/Customer/Collection.php - - - message: "#^Else branch is unreachable because previous condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Reports/Model/Resource/Customer/Collection.php - - message: "#^Property Mage_Reports_Model_Resource_Entity_Summary_Collection_Abstract\\:\\:\\$_entityCollection \\(Mage_Eav_Model_Entity_Collection_Abstract\\) in empty\\(\\) is not falsy\\.$#" count: 1 @@ -5645,11 +3845,6 @@ parameters: count: 1 path: app/code/core/Mage/Reports/Model/Totals.php - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Review/Block/Form.php - - message: "#^Return type \\(string\\) of method Mage_Review_Block_Form\\:\\:getAction\\(\\) should be compatible with return type \\(Mage_Core_Controller_Varien_Action\\) of method Mage_Core_Block_Abstract\\:\\:getAction\\(\\)$#" count: 1 @@ -5660,11 +3855,6 @@ parameters: count: 1 path: app/code/core/Mage/Review/Model/Resource/Review.php - - - message: "#^Right side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Review/Model/Resource/Review.php - - message: "#^Comparison operation \"\\=\\=\" between array\\|null and 1 results in an error\\.$#" count: 1 @@ -5675,36 +3865,11 @@ parameters: count: 1 path: app/code/core/Mage/Review/Model/Resource/Review/Product/Collection.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Review/Model/Review.php - - message: "#^Cannot call method getId\\(\\) on true\\.$#" count: 1 path: app/code/core/Mage/Rss/Helper/Data.php - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Rss/Helper/Data.php - - - - message: "#^Call to function is_string\\(\\) with array will always evaluate to false\\.$#" - count: 1 - path: app/code/core/Mage/Rule/Model/Abstract.php - - - - message: "#^If condition is always true\\.$#" - count: 2 - path: app/code/core/Mage/Rule/Model/Abstract.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 2 - path: app/code/core/Mage/Rule/Model/Abstract.php - - message: "#^Offset 'actions'\\|'conditions' on array\\{\\} in isset\\(\\) does not exist\\.$#" count: 1 @@ -5715,11 +3880,6 @@ parameters: count: 1 path: app/code/core/Mage/Rule/Model/Abstract.php - - - message: "#^Result of && is always false\\.$#" - count: 1 - path: app/code/core/Mage/Rule/Model/Abstract.php - - message: "#^Call to an undefined method Mage_Rule_Model_Action_Interface\\:\\:getId\\(\\)\\.$#" count: 1 @@ -5755,11 +3915,6 @@ parameters: count: 1 path: app/code/core/Mage/Rule/Model/Condition/Combine.php - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Rule/Model/Condition/Product/Abstract.php - - message: "#^Method Mage_Eav_Model_Entity_Attribute_Source_Interface\\:\\:getAllOptions\\(\\) invoked with 1 parameter, 0 required\\.$#" count: 1 @@ -5770,26 +3925,6 @@ parameters: count: 1 path: app/code/core/Mage/Rule/Model/Condition/Product/Abstract.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 2 - path: app/code/core/Mage/Rule/Model/Condition/Product/Abstract.php - - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Block/Adminhtml/Recurring/Profile/Edit/Form.php - - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Block/Adminhtml/Recurring/Profile/Edit/Form.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Block/Adminhtml/Recurring/Profile/View/Items.php - - message: "#^Cannot call method setParentFilter\\(\\) on Mage_Core_Model_Resource_Db_Collection_Abstract\\|false\\.$#" count: 1 @@ -5810,56 +3945,21 @@ parameters: count: 1 path: app/code/core/Mage/Sales/Block/Order/Details.php - - - message: "#^Elseif condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Block/Order/Totals.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Block/Recurring/Profile/View.php - - message: "#^Property Mage_Sales_Block_Recurring_Profiles\\:\\:\\$_profiles \\(Mage_Sales_Model_Resource_Recurring_Profile_Collection\\) does not accept Mage_Core_Model_Resource_Db_Collection_Abstract\\.$#" count: 1 path: app/code/core/Mage/Sales/Block/Recurring/Profiles.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Block/Reorder/Sidebar.php - - - - message: "#^Unreachable statement \\- code above always terminates\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Block/Reorder/Sidebar.php - - message: "#^Call to an undefined method Varien_Simplexml_Element\\:\\:getClassName\\(\\)\\.$#" count: 1 path: app/code/core/Mage/Sales/Model/Config/Ordered.php - - - message: "#^Offset 'after' on array\\{\\000\\*\\000_parent\\: Varien_Simplexml_Element, \\000\\*\\000_parent\\: Varien_Simplexml_Element, before\\: array\\{\\}\\} in isset\\(\\) does not exist\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Config/Ordered.php - - - - message: "#^Offset 'before' on array\\{\\000\\*\\000_parent\\: Varien_Simplexml_Element, \\000\\*\\000_parent\\: Varien_Simplexml_Element\\} in isset\\(\\) does not exist\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Config/Ordered.php - - message: "#^Call to an undefined method Mage_Sales_Model_Resource_Quote_Collection\\:\\:addAttributeToSelect\\(\\)\\.$#" count: 2 path: app/code/core/Mage/Sales/Model/Entity/Quote.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Entity/Quote/Address/Attribute/Backend/Region.php - - message: "#^Return type \\(\\$this\\(Mage_Sales_Model_Entity_Quote_Address_Attribute_Frontend_Custbalance\\)\\) of method Mage_Sales_Model_Entity_Quote_Address_Attribute_Frontend_Custbalance\\:\\:fetchTotals\\(\\) should be compatible with return type \\(array\\) of method Mage_Sales_Model_Entity_Quote_Address_Attribute_Frontend\\:\\:fetchTotals\\(\\)$#" count: 1 @@ -5890,126 +3990,26 @@ parameters: count: 1 path: app/code/core/Mage/Sales/Model/Entity/Quote/Address/Attribute/Frontend/Tax.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Entity/Quote/Item/Collection.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Entity/Quote/Item/Collection.php - - - - message: "#^Right side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Entity/Quote/Item/Collection.php - - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Order.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Order/Address.php - - - - message: "#^Right side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Order/Address.php - - message: "#^Property Mage_Sales_Model_Order_Creditmemo\\:\\:\\$_items \\(iterable\\&Mage_Sales_Model_Resource_Order_Creditmemo_Item_Collection\\) in empty\\(\\) is not falsy\\.$#" count: 1 path: app/code/core/Mage/Sales/Model/Order/Creditmemo.php - - - message: "#^Right side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Order/Creditmemo.php - - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Order/Creditmemo/Comment.php - - - - message: "#^Right side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Order/Creditmemo/Comment.php - - - - message: "#^Unreachable statement \\- code above always terminates\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Order/Creditmemo/Comment.php - - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Order/Creditmemo/Item.php - - - - message: "#^Right side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Order/Creditmemo/Item.php - - message: "#^Cannot call method addAttributeToFilter\\(\\) on Mage_Core_Model_Resource_Db_Collection_Abstract\\|false\\.$#" count: 1 path: app/code/core/Mage/Sales/Model/Order/Invoice.php - - - message: "#^Right side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Order/Invoice.php - - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Order/Invoice/Comment.php - - - - message: "#^Right side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Order/Invoice/Comment.php - - - - message: "#^Unreachable statement \\- code above always terminates\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Order/Invoice/Comment.php - - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Order/Invoice/Item.php - - - - message: "#^Right side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Order/Invoice/Item.php - - message: "#^Call to an undefined method Mage_Catalog_Model_Product_Type_Abstract\\:\\:getForceApplyDiscountToParentItem\\(\\)\\.$#" count: 1 path: app/code/core/Mage/Sales/Model/Order/Item.php - - - message: "#^Right side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Order/Item.php - - message: "#^If condition is always false\\.$#" count: 1 path: app/code/core/Mage/Sales/Model/Order/Payment.php - - - message: "#^If condition is always true\\.$#" - count: 2 - path: app/code/core/Mage/Sales/Model/Order/Payment.php - - message: "#^Method Mage_Sales_Model_Order_Payment\\:\\:_addTransaction\\(\\) should return Mage_Sales_Model_Order_Payment_Transaction\\|null but return statement is missing\\.$#" count: 1 @@ -6021,45 +4021,10 @@ parameters: path: app/code/core/Mage/Sales/Model/Order/Payment.php - - message: "#^Right side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Order/Payment.php - - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Order/Payment/Transaction.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Order/Payment/Transaction.php - - - - message: "#^Right side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Order/Payment/Transaction.php - - - - message: "#^Ternary operator condition is always true\\.$#" + message: "#^Method Mage_Sales_Model_Order_Payment_Transaction\\:\\:getOrderId\\(\\) should return int\\|null but return statement is missing\\.$#" count: 1 path: app/code/core/Mage/Sales/Model/Order/Payment/Transaction.php - - - message: "#^If condition is always false\\.$#" - count: 2 - path: app/code/core/Mage/Sales/Model/Order/Pdf/Abstract.php - - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Order/Pdf/Abstract.php - - - - message: "#^Instanceof between Mage_Core_Model_Abstract\\|false and Mage_Sales_Model_Order_Pdf_Total_Default will always evaluate to false\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Order/Pdf/Abstract.php - - message: "#^Method Mage_Sales_Model_Order_Pdf_Abstract\\:\\:getAlignCenter\\(\\) should return int but returns float\\.$#" count: 1 @@ -6085,79 +4050,24 @@ parameters: count: 1 path: app/code/core/Mage/Sales/Model/Order/Shipment.php - - - message: "#^Right side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Order/Shipment.php - - message: "#^Call to an undefined method Mage_Eav_Model_Entity_Abstract\\:\\:getStoreId\\(\\)\\.$#" count: 1 path: app/code/core/Mage/Sales/Model/Order/Shipment/Api.php - - message: "#^Call to function is_object\\(\\) with array\\|string will always evaluate to false\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Order/Shipment/Api.php - - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Order/Shipment/Api.php - - - - message: "#^Unreachable statement \\- code above always terminates\\.$#" + message: "#^Method Mage_Sales_Model_Order_Shipment_Api\\:\\:create\\(\\) should return string but returns null\\.$#" count: 1 path: app/code/core/Mage/Sales/Model/Order/Shipment/Api.php - - message: "#^Unreachable statement \\- code above always terminates\\.$#" + message: "#^Method Mage_Sales_Model_Order_Shipment_Api_V2\\:\\:create\\(\\) should return string but returns null\\.$#" count: 1 path: app/code/core/Mage/Sales/Model/Order/Shipment/Api/V2.php - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Order/Shipment/Comment.php - - - - message: "#^Right side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Order/Shipment/Comment.php - - - - message: "#^Unreachable statement \\- code above always terminates\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Order/Shipment/Comment.php - - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Order/Shipment/Item.php - - - - message: "#^Right side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Order/Shipment/Item.php - - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Order/Shipment/Track.php - - - - message: "#^Right side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Order/Shipment/Track.php - - - - message: "#^Unreachable statement \\- code above always terminates\\.$#" + message: "#^Method Mage_Sales_Model_Order_Status_History\\:\\:getStatusLabel\\(\\) should return string but return statement is missing\\.$#" count: 1 - path: app/code/core/Mage/Sales/Model/Order/Shipment/Track.php - - - - message: "#^If condition is always true\\.$#" - count: 2 path: app/code/core/Mage/Sales/Model/Order/Status/History.php - @@ -6165,46 +4075,11 @@ parameters: count: 1 path: app/code/core/Mage/Sales/Model/Order/Status/History.php - - - message: "#^Right side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Order/Status/History.php - - - - message: "#^Unreachable statement \\- code above always terminates\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Order/Status/History.php - - - - message: "#^Instanceof between Mage_Core_Model_Abstract\\|false and Mage_Sales_Model_Order_Total_Abstract will always evaluate to false\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Order/Total/Config/Base.php - - - - message: "#^Unreachable statement \\- code above always terminates\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Order/Total/Config/Base.php - - - - message: "#^Right side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Payment/Method/Billing/AgreementAbstract.php - - message: "#^Call to an undefined method Mage_Sales_Model_Quote_Item_Abstract\\:\\:compare\\(\\)\\.$#" count: 1 path: app/code/core/Mage/Sales/Model/Quote.php - - - message: "#^If condition is always true\\.$#" - count: 2 - path: app/code/core/Mage/Sales/Model/Quote.php - - - - message: "#^Left side of && is always true\\.$#" - count: 4 - path: app/code/core/Mage/Sales/Model/Quote.php - - message: "#^Method Mage_Sales_Model_Quote\\:\\:getIsVirtual\\(\\) should return bool but returns int\\.$#" count: 1 @@ -6215,76 +4090,31 @@ parameters: count: 1 path: app/code/core/Mage/Sales/Model/Quote.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Quote.php - - message: "#^Property Mage_Sales_Model_Quote\\:\\:\\$_addresses \\(Mage_Sales_Model_Resource_Order_Address_Collection\\|null\\) does not accept Mage_Sales_Model_Resource_Quote_Address_Collection\\.$#" count: 1 path: app/code/core/Mage/Sales/Model/Quote.php - - - message: "#^Right side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Quote.php - - - - message: "#^Unreachable statement \\- code above always terminates\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Quote.php - - message: "#^Variable \\$old in empty\\(\\) always exists and is not falsy\\.$#" count: 2 path: app/code/core/Mage/Sales/Model/Quote.php - - - message: "#^If condition is always true\\.$#" - count: 3 - path: app/code/core/Mage/Sales/Model/Quote/Address.php - - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Quote/Address.php - - message: "#^Method Mage_Sales_Model_Quote_Address\\:\\:getItemsCollection\\(\\) should return Mage_Eav_Model_Entity_Collection_Abstract but returns Mage_Sales_Model_Resource_Quote_Address_Item_Collection\\.$#" count: 1 path: app/code/core/Mage/Sales/Model/Quote/Address.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Quote/Address.php - - message: "#^Right side of && is always true\\.$#" count: 1 path: app/code/core/Mage/Sales/Model/Quote/Address.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Quote/Address/Item.php - - message: "#^Call to an undefined method Varien_Simplexml_Element\\:\\:getClassName\\(\\)\\.$#" count: 1 path: app/code/core/Mage/Sales/Model/Quote/Address/Total/Collector.php - - - message: "#^Instanceof between Mage_Core_Model_Abstract\\|false and Mage_Sales_Model_Quote_Address_Total_Abstract will always evaluate to false\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Quote/Address/Total/Collector.php - - - - message: "#^Unreachable statement \\- code above always terminates\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Quote/Address/Total/Collector.php - - message: "#^Return type \\(\\$this\\(Mage_Sales_Model_Quote_Address_Total_Discount\\)\\) of method Mage_Sales_Model_Quote_Address_Total_Discount\\:\\:fetch\\(\\) should be compatible with return type \\(array\\) of method Mage_Sales_Model_Quote_Address_Total_Abstract\\:\\:fetch\\(\\)$#" count: 1 @@ -6325,41 +4155,16 @@ parameters: count: 1 path: app/code/core/Mage/Sales/Model/Quote/Address/Total/Shipping.php - - - message: "#^If condition is always true\\.$#" - count: 2 - path: app/code/core/Mage/Sales/Model/Quote/Address/Total/Subtotal.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 2 - path: app/code/core/Mage/Sales/Model/Quote/Address/Total/Subtotal.php - - message: "#^Return type \\(Mage_Sales_Model_Quote_Address_Total_Subtotal\\) of method Mage_Sales_Model_Quote_Address_Total_Subtotal\\:\\:fetch\\(\\) should be compatible with return type \\(array\\) of method Mage_Sales_Model_Quote_Address_Total_Abstract\\:\\:fetch\\(\\)$#" count: 1 path: app/code/core/Mage/Sales/Model/Quote/Address/Total/Subtotal.php - - - message: "#^Else branch is unreachable because ternary operator condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Quote/Address/Total/Tax.php - - message: "#^Return type \\(\\$this\\(Mage_Sales_Model_Quote_Address_Total_Tax\\)\\) of method Mage_Sales_Model_Quote_Address_Total_Tax\\:\\:fetch\\(\\) should be compatible with return type \\(array\\) of method Mage_Sales_Model_Quote_Address_Total_Abstract\\:\\:fetch\\(\\)$#" count: 1 path: app/code/core/Mage/Sales/Model/Quote/Address/Total/Tax.php - - - message: "#^If condition is always true\\.$#" - count: 4 - path: app/code/core/Mage/Sales/Model/Quote/Item.php - - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Quote/Item.php - - message: "#^Method Mage_Sales_Model_Quote_Item\\:\\:__clone\\(\\) with return type void returns \\$this\\(Mage_Sales_Model_Quote_Item\\) but should not return anything\\.$#" count: 1 @@ -6375,41 +4180,16 @@ parameters: count: 1 path: app/code/core/Mage/Sales/Model/Quote/Item.php - - - message: "#^Unreachable statement \\- code above always terminates\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Quote/Item.php - - message: "#^Method Mage_Sales_Model_Quote_Item_Abstract\\:\\:__clone\\(\\) with return type void returns \\$this\\(Mage_Sales_Model_Quote_Item_Abstract\\) but should not return anything\\.$#" count: 1 path: app/code/core/Mage/Sales/Model/Quote/Item/Abstract.php - - - message: "#^Ternary operator condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Quote/Item/Abstract.php - - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Quote/Item/Option.php - - message: "#^Method Mage_Sales_Model_Quote_Item_Option\\:\\:__clone\\(\\) with return type void returns \\$this\\(Mage_Sales_Model_Quote_Item_Option\\) but should not return anything\\.$#" count: 1 path: app/code/core/Mage/Sales/Model/Quote/Item/Option.php - - - message: "#^If condition is always true\\.$#" - count: 3 - path: app/code/core/Mage/Sales/Model/Quote/Payment.php - - - - message: "#^Unreachable statement \\- code above always terminates\\.$#" - count: 2 - path: app/code/core/Mage/Sales/Model/Quote/Payment.php - - message: "#^Call to Exception\\:\\:__construct\\(\\) on a separate line has no effect\\.$#" count: 1 @@ -6430,11 +4210,6 @@ parameters: count: 3 path: app/code/core/Mage/Sales/Model/Recurring/Profile.php - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Recurring/Profile.php - - message: "#^Cannot call method updateOnRelatedRecordChanged\\(\\) on Mage_Core_Model_Resource_Db_Collection_Abstract\\|false\\.$#" count: 1 @@ -6445,16 +4220,6 @@ parameters: count: 1 path: app/code/core/Mage/Sales/Model/Resource/Order/Payment/Transaction.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Resource/Quote.php - - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Resource/Quote/Address/Attribute/Backend/Region.php - - message: "#^Return type \\(\\$this\\(Mage_Sales_Model_Resource_Quote_Address_Attribute_Frontend_Custbalance\\)\\) of method Mage_Sales_Model_Resource_Quote_Address_Attribute_Frontend_Custbalance\\:\\:fetchTotals\\(\\) should be compatible with return type \\(array\\) of method Mage_Sales_Model_Resource_Quote_Address_Attribute_Frontend\\:\\:fetchTotals\\(\\)$#" count: 1 @@ -6476,29 +4241,14 @@ parameters: path: app/code/core/Mage/Sales/Model/Resource/Quote/Address/Attribute/Frontend/Shipping.php - - message: "#^Return type \\(\\$this\\(Mage_Sales_Model_Resource_Quote_Address_Attribute_Frontend_Subtotal\\)\\) of method Mage_Sales_Model_Resource_Quote_Address_Attribute_Frontend_Subtotal\\:\\:fetchTotals\\(\\) should be compatible with return type \\(array\\) of method Mage_Sales_Model_Resource_Quote_Address_Attribute_Frontend\\:\\:fetchTotals\\(\\)$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Resource/Quote/Address/Attribute/Frontend/Subtotal.php - - - - message: "#^Return type \\(\\$this\\(Mage_Sales_Model_Resource_Quote_Address_Attribute_Frontend_Tax\\)\\) of method Mage_Sales_Model_Resource_Quote_Address_Attribute_Frontend_Tax\\:\\:fetchTotals\\(\\) should be compatible with return type \\(array\\) of method Mage_Sales_Model_Resource_Quote_Address_Attribute_Frontend\\:\\:fetchTotals\\(\\)$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Resource/Quote/Address/Attribute/Frontend/Tax.php - - - - message: "#^If condition is always true\\.$#" - count: 2 - path: app/code/core/Mage/Sales/Model/Resource/Quote/Item/Collection.php - - - - message: "#^Left side of && is always false\\.$#" + message: "#^Return type \\(\\$this\\(Mage_Sales_Model_Resource_Quote_Address_Attribute_Frontend_Subtotal\\)\\) of method Mage_Sales_Model_Resource_Quote_Address_Attribute_Frontend_Subtotal\\:\\:fetchTotals\\(\\) should be compatible with return type \\(array\\) of method Mage_Sales_Model_Resource_Quote_Address_Attribute_Frontend\\:\\:fetchTotals\\(\\)$#" count: 1 - path: app/code/core/Mage/Sales/Model/Resource/Quote/Item/Collection.php + path: app/code/core/Mage/Sales/Model/Resource/Quote/Address/Attribute/Frontend/Subtotal.php - - message: "#^Right side of && is always true\\.$#" + message: "#^Return type \\(\\$this\\(Mage_Sales_Model_Resource_Quote_Address_Attribute_Frontend_Tax\\)\\) of method Mage_Sales_Model_Resource_Quote_Address_Attribute_Frontend_Tax\\:\\:fetchTotals\\(\\) should be compatible with return type \\(array\\) of method Mage_Sales_Model_Resource_Quote_Address_Attribute_Frontend\\:\\:fetchTotals\\(\\)$#" count: 1 - path: app/code/core/Mage/Sales/Model/Resource/Quote/Item/Collection.php + path: app/code/core/Mage/Sales/Model/Resource/Quote/Address/Attribute/Frontend/Tax.php - message: "#^Comparison operation \"\\!\\=\" between array\\|int and 0 results in an error\\.$#" @@ -6510,11 +4260,6 @@ parameters: count: 1 path: app/code/core/Mage/Sales/Model/Resource/Report/Bestsellers/Collection.php - - - message: "#^Call to function is_array\\(\\) with string will always evaluate to false\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Resource/Report/Collection/Abstract.php - - message: "#^Call to an undefined method Varien_Db_Adapter_Interface\\:\\:listTables\\(\\)\\.$#" count: 1 @@ -6545,21 +4290,11 @@ parameters: count: 1 path: app/code/core/Mage/Sales/controllers/DownloadController.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Sales/controllers/DownloadController.php - - message: "#^Method Mage_Sales_Recurring_ProfileController\\:\\:preDispatch\\(\\) should return \\$this\\(Mage_Sales_Recurring_ProfileController\\) but empty return statement found\\.$#" count: 1 path: app/code/core/Mage/Sales/controllers/Recurring/ProfileController.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/SalesRule/Model/Observer.php - - message: "#^Return type \\(Mage_SalesRule_Model_Quote_Discount\\) of method Mage_SalesRule_Model_Quote_Discount\\:\\:fetch\\(\\) should be compatible with return type \\(array\\) of method Mage_Sales_Model_Quote_Address_Total_Abstract\\:\\:fetch\\(\\)$#" count: 1 @@ -6585,16 +4320,6 @@ parameters: count: 1 path: app/code/core/Mage/SalesRule/Model/Resource/Coupon/Usage.php - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/SalesRule/Model/Resource/Coupon/Usage.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/SalesRule/Model/Rule.php - - message: "#^Return type \\(Mage_SalesRule_Model_Rule_Condition_Product_Combine\\) of method Mage_SalesRule_Model_Rule\\:\\:getActionsInstance\\(\\) should be compatible with return type \\(Mage_Rule_Model_Action_Collection\\) of method Mage_Rule_Model_Abstract\\:\\:getActionsInstance\\(\\)$#" count: 1 @@ -6650,11 +4375,6 @@ parameters: count: 1 path: app/code/core/Mage/Shipping/Model/Carrier/Tablerate.php - - - message: "#^Result of && is always false\\.$#" - count: 1 - path: app/code/core/Mage/Shipping/Model/Carrier/Tablerate.php - - message: "#^Variable \\$rate in empty\\(\\) always exists and is not falsy\\.$#" count: 3 @@ -6675,16 +4395,6 @@ parameters: count: 1 path: app/code/core/Mage/Shipping/Model/Shipping.php - - - message: "#^Instanceof between Mage_Core_Model_Abstract\\|Mage_Shipping_Model_Carrier_Abstract\\|true and Mage_Shipping_Model_Rate_Result_Error will always evaluate to false\\.$#" - count: 1 - path: app/code/core/Mage/Shipping/Model/Shipping.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Shipping/Model/Shipping.php - - message: "#^Property Mage_Shipping_Model_Shipping\\:\\:\\$_result \\(Mage_Shipping_Model_Rate_Result\\) in empty\\(\\) is not falsy\\.$#" count: 1 @@ -6755,11 +4465,6 @@ parameters: count: 1 path: app/code/core/Mage/Tax/Block/Sales/Order/Tax.php - - - message: "#^Instanceof between Mage_Sales_Model_Order_Invoice and Mage_Sales_Model_Order will always evaluate to false\\.$#" - count: 1 - path: app/code/core/Mage/Tax/Block/Sales/Order/Tax.php - - message: "#^Property Mage_Tax_Block_Sales_Order_Tax\\:\\:\\$_source \\(Mage_Sales_Model_Order_Invoice\\) does not accept Mage_Sales_Model_Order\\.$#" count: 1 @@ -6790,11 +4495,6 @@ parameters: count: 1 path: app/code/core/Mage/Tax/Model/Calculation.php - - - message: "#^Right side of && is always true\\.$#" - count: 2 - path: app/code/core/Mage/Tax/Model/Calculation.php - - message: "#^Property Mage_Tax_Model_Calculation_Rate\\:\\:\\$_titles \\(array\\|null\\) does not accept Mage_Tax_Model_Resource_Calculation_Rate_Title_Collection\\.$#" count: 1 @@ -6810,21 +4510,11 @@ parameters: count: 1 path: app/code/core/Mage/Tax/Model/Config/Price/Include.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Tax/Model/Resource/Setup.php - - message: "#^Return type \\(array\\) of method Mage_Tax_Model_Sales_Total_Quote_Nominal_Tax\\:\\:fetch\\(\\) should be compatible with return type \\(\\$this\\(Mage_Tax_Model_Sales_Total_Quote_Tax\\)\\) of method Mage_Tax_Model_Sales_Total_Quote_Tax\\:\\:fetch\\(\\)$#" count: 1 path: app/code/core/Mage/Tax/Model/Sales/Total/Quote/Nominal/Tax.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Tax/Model/Sales/Total/Quote/Tax.php - - message: "#^Return type \\(\\$this\\(Mage_Tax_Model_Sales_Total_Quote_Tax\\)\\) of method Mage_Tax_Model_Sales_Total_Quote_Tax\\:\\:fetch\\(\\) should be compatible with return type \\(array\\) of method Mage_Sales_Model_Quote_Address_Total_Abstract\\:\\:fetch\\(\\)$#" count: 1 @@ -6840,11 +4530,6 @@ parameters: count: 2 path: app/code/core/Mage/Usa/Model/Shipping/Carrier/Dhl.php - - - message: "#^Instanceof between Mage_Shipping_Model_Rate_Result\\|null and Mage_Shipping_Model_Tracking_Result will always evaluate to false\\.$#" - count: 1 - path: app/code/core/Mage/Usa/Model/Shipping/Carrier/Dhl.php - - message: "#^Method Mage_Usa_Model_Shipping_Carrier_Dhl\\:\\:_doRequest\\(\\) should return Mage_Shipping_Model_Rate_Result\\|Varien_Object but empty return statement found\\.$#" count: 1 @@ -6880,11 +4565,6 @@ parameters: count: 1 path: app/code/core/Mage/Usa/Model/Shipping/Carrier/Dhl.php - - - message: "#^Variable \\$statuses in empty\\(\\) always exists and is always falsy\\.$#" - count: 1 - path: app/code/core/Mage/Usa/Model/Shipping/Carrier/Dhl.php - - message: "#^Access to an undefined property Varien_Object\\:\\:\\$domestic\\.$#" count: 1 @@ -6910,11 +4590,6 @@ parameters: count: 1 path: app/code/core/Mage/Usa/Model/Shipping/Carrier/Dhl/International.php - - - message: "#^Else branch is unreachable because previous condition is always true\\.$#" - count: 2 - path: app/code/core/Mage/Usa/Model/Shipping/Carrier/Dhl/International.php - - message: "#^Invalid array key type strin\\.$#" count: 3 @@ -6980,11 +4655,6 @@ parameters: count: 1 path: app/code/core/Mage/Usa/Model/Shipping/Carrier/Fedex.php - - - message: "#^Instanceof between Mage_Shipping_Model_Rate_Result\\|null and Mage_Shipping_Model_Tracking_Result will always evaluate to false\\.$#" - count: 1 - path: app/code/core/Mage/Usa/Model/Shipping/Carrier/Fedex.php - - message: "#^Method Mage_Usa_Model_Shipping_Carrier_Fedex\\:\\:_getQuotes\\(\\) should return Mage_Shipping_Model_Rate_Result but returns true\\.$#" count: 1 @@ -7000,16 +4670,6 @@ parameters: count: 2 path: app/code/core/Mage/Usa/Model/Shipping/Carrier/Fedex.php - - - message: "#^Variable \\$statuses in empty\\(\\) always exists and is always falsy\\.$#" - count: 1 - path: app/code/core/Mage/Usa/Model/Shipping/Carrier/Fedex.php - - - - message: "#^Instanceof between Mage_Shipping_Model_Rate_Result\\|null and Mage_Shipping_Model_Tracking_Result will always evaluate to false\\.$#" - count: 1 - path: app/code/core/Mage/Usa/Model/Shipping/Carrier/Ups.php - - message: "#^Method Mage_Usa_Model_Shipping_Carrier_Ups\\:\\:_getQuotes\\(\\) should return Mage_Shipping_Model_Rate_Result but returns null\\.$#" count: 1 @@ -7040,21 +4700,11 @@ parameters: count: 2 path: app/code/core/Mage/Usa/Model/Shipping/Carrier/Ups.php - - - message: "#^Variable \\$statuses in empty\\(\\) always exists and is always falsy\\.$#" - count: 1 - path: app/code/core/Mage/Usa/Model/Shipping/Carrier/Ups.php - - message: "#^Access to an undefined property Mage_Usa_Model_Shipping_Carrier_Usps\\:\\:\\$_rawTrackRequest\\.$#" count: 2 path: app/code/core/Mage/Usa/Model/Shipping/Carrier/Usps.php - - - message: "#^Instanceof between Mage_Shipping_Model_Rate_Result\\|null and Mage_Shipping_Model_Tracking_Result will always evaluate to false\\.$#" - count: 1 - path: app/code/core/Mage/Usa/Model/Shipping/Carrier/Usps.php - - message: "#^Method Mage_Usa_Model_Shipping_Carrier_Usps\\:\\:_parseXmlResponse\\(\\) should return Mage_Shipping_Model_Rate_Result but return statement is missing\\.$#" count: 1 @@ -7075,11 +4725,6 @@ parameters: count: 1 path: app/code/core/Mage/Usa/Model/Shipping/Carrier/Usps.php - - - message: "#^Variable \\$statuses in empty\\(\\) always exists and is always falsy\\.$#" - count: 1 - path: app/code/core/Mage/Usa/Model/Shipping/Carrier/Usps.php - - message: "#^Call to an undefined method Mage_Core_Helper_Abstract\\:\\:priceIncludesTax\\(\\)\\.$#" count: 1 @@ -7090,11 +4735,6 @@ parameters: count: 1 path: app/code/core/Mage/Weee/Helper/Data.php - - - message: "#^Right side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Weee/Helper/Data.php - - message: "#^Variable \\$title in isset\\(\\) always exists and is not nullable\\.$#" count: 1 @@ -7150,38 +4790,13 @@ parameters: count: 1 path: app/code/core/Mage/Widget/Block/Adminhtml/Widget/Options.php - - - message: "#^Unreachable statement \\- code above always terminates\\.$#" - count: 1 - path: app/code/core/Mage/Widget/Block/Adminhtml/Widget/Options.php - - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Wishlist/Block/Customer/Wishlist/Item/Column.php - - - - message: "#^Unreachable statement \\- code above always terminates\\.$#" - count: 1 - path: app/code/core/Mage/Wishlist/Block/Customer/Wishlist/Item/Column.php - - message: "#^Parameter \\#1 \\$item \\(Mage_Wishlist_Model_Item\\) of method Mage_Wishlist_Block_Share_Email_Items\\:\\:hasDescription\\(\\) should be compatible with parameter \\$item \\(Mage_Catalog_Model_Product\\) of method Mage_Wishlist_Block_Abstract\\:\\:hasDescription\\(\\)$#" count: 1 path: app/code/core/Mage/Wishlist/Block/Share/Email/Items.php - - message: "#^If condition is always true\\.$#" - count: 2 - path: app/code/core/Mage/Wishlist/Helper/Data.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Wishlist/Helper/Data.php - - - - message: "#^Result of && is always false\\.$#" + message: "#^Method Mage_Wishlist_Helper_Data\\:\\:getCustomerName\\(\\) should return string\\|null but return statement is missing\\.$#" count: 1 path: app/code/core/Mage/Wishlist/Helper/Data.php @@ -7190,21 +4805,11 @@ parameters: count: 1 path: app/code/core/Mage/Wishlist/Model/Item.php - - - message: "#^Result of && is always false\\.$#" - count: 1 - path: app/code/core/Mage/Wishlist/Model/Item.php - - message: "#^Variable \\$buyRequest in empty\\(\\) always exists and is not falsy\\.$#" count: 2 path: app/code/core/Mage/Wishlist/Model/Item.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Wishlist/Model/Item/Option.php - - message: "#^Method Mage_Wishlist_Model_Item_Option\\:\\:__clone\\(\\) with return type void returns \\$this\\(Mage_Wishlist_Model_Item_Option\\) but should not return anything\\.$#" count: 1 @@ -7225,21 +4830,11 @@ parameters: count: 3 path: app/code/core/Mage/Wishlist/controllers/IndexController.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 2 - path: app/code/core/Mage/Wishlist/controllers/IndexController.php - - message: "#^Comparison operation \"\\>\\=\" between int\\<0, max\\> and 0 is always true\\.$#" count: 1 path: lib/Mage/Archive.php - - - message: "#^Offset 'basename' on array\\{dirname\\?\\: string, basename\\: string, extension\\?\\: string, filename\\: string\\} on left side of \\?\\? always exists and is not nullable\\.$#" - count: 1 - path: lib/Mage/Archive/Helper/File.php - - message: "#^Negated boolean expression is always true\\.$#" count: 1 @@ -7255,21 +4850,11 @@ parameters: count: 1 path: lib/Mage/DB/Mysqli.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 2 - path: lib/Mage/HTTP/Client/Curl.php - - message: "#^Property Mage_HTTP_Client_Curl\\:\\:\\$_ch \\(object\\) does not accept resource\\.$#" count: 1 path: lib/Mage/HTTP/Client/Curl.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 2 - path: lib/Mage/HTTP/Client/Socket.php - - message: "#^Property Mage_HTTP_Client_Socket\\:\\:\\$_postFields is never read, only written\\.$#" count: 1 @@ -7285,29 +4870,14 @@ parameters: count: 1 path: lib/Mage/System/Ftp.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: lib/Mage/Xml/Generator.php - - message: "#^Argument of an invalid type Zend_Db_Statement_Interface supplied for foreach, only iterables are supported\\.$#" count: 1 path: lib/Magento/Db/Object/Trigger.php - - - message: "#^Ternary operator condition is always true\\.$#" - count: 2 - path: lib/Magento/Profiler/Output/Firebug.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: lib/Varien/Autoload.php - - message: "#^Left side of && is always true\\.$#" - count: 3 + count: 2 path: lib/Varien/Cache/Backend/Database.php - @@ -7315,16 +4885,6 @@ parameters: count: 1 path: lib/Varien/Cache/Backend/Database.php - - - message: "#^Right side of && is always true\\.$#" - count: 1 - path: lib/Varien/Cache/Backend/Database.php - - - - message: "#^Strict comparison using \\=\\=\\= between int\\\\|int\\<1, max\\> and null will always evaluate to false\\.$#" - count: 1 - path: lib/Varien/Cache/Backend/Database.php - - message: "#^Parameter \\#4 \\$specificLifetime \\(bool\\) of method Varien_Cache_Backend_Memcached\\:\\:save\\(\\) should be compatible with parameter \\$specificLifetime \\(int\\) of method Zend_Cache_Backend_Interface\\:\\:save\\(\\)$#" count: 2 @@ -7345,31 +4905,6 @@ parameters: count: 2 path: lib/Varien/Convert/Action/Abstract.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: lib/Varien/Convert/Action/Abstract.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: lib/Varien/Convert/Adapter/Db/Table.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: lib/Varien/Convert/Adapter/Io.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: lib/Varien/Convert/Adapter/Zend/Cache.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: lib/Varien/Convert/Adapter/Zend/Db.php - - message: "#^Call to an undefined method Varien_Convert_Container_Interface\\:\\:getName\\(\\)\\.$#" count: 2 @@ -7425,31 +4960,16 @@ parameters: count: 1 path: lib/Varien/Data/Form/Abstract.php - - - message: "#^If condition is always true\\.$#" - count: 2 - path: lib/Varien/Data/Form/Element/Abstract.php - - message: "#^Access to an undefined property Varien_Data_Form_Element_Fieldset\\:\\:\\$_sortDirection\\.$#" count: 1 path: lib/Varien/Data/Form/Element/Fieldset.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: lib/Varien/Data/Form/Element/Fieldset.php - - message: "#^Parameter \\#1 \\$suffix \\(int\\) of method Varien_Data_Form_Element_Multiline\\:\\:getLabelHtml\\(\\) should be compatible with parameter \\$idSuffix \\(string\\) of method Varien_Data_Form_Element_Abstract\\:\\:getLabelHtml\\(\\)$#" count: 1 path: lib/Varien/Data/Form/Element/Multiline.php - - - message: "#^If condition is always true\\.$#" - count: 2 - path: lib/Varien/Data/Tree.php - - message: "#^Function explode invoked with 1 parameter, 2\\-3 required\\.$#" count: 1 @@ -7460,11 +4980,6 @@ parameters: count: 1 path: lib/Varien/Data/Tree/Dbp.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: lib/Varien/Data/Tree/Node.php - - message: "#^Method Varien_Data_Tree\\:\\:load\\(\\) invoked with 2 parameters, 0\\-1 required\\.$#" count: 1 @@ -7510,11 +5025,6 @@ parameters: count: 1 path: lib/Varien/Db/Adapter/Mysqli.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: lib/Varien/Db/Adapter/Mysqli.php - - message: "#^Strict comparison using \\=\\=\\= between false and mysqli will always evaluate to false\\.$#" count: 1 @@ -7535,26 +5045,11 @@ parameters: count: 2 path: lib/Varien/Db/Adapter/Pdo/Mysql.php - - - message: "#^Comparison operation \"\\>\" between int\\<256, max\\> and 255 is always true\\.$#" - count: 1 - path: lib/Varien/Db/Adapter/Pdo/Mysql.php - - - - message: "#^Comparison operation \"\\>\" between int\\<65537, max\\> and 65536 is always true\\.$#" - count: 1 - path: lib/Varien/Db/Adapter/Pdo/Mysql.php - - message: "#^Method Varien_Db_Adapter_Pdo_Mysql\\:\\:query\\(\\) should return Zend_Db_Statement_Pdo but returns PDOStatement\\|Zend_Db_Statement_Interface\\.$#" count: 1 path: lib/Varien/Db/Adapter/Pdo/Mysql.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 2 - path: lib/Varien/Db/Adapter/Pdo/Mysql.php - - message: "#^Property Varien_Db_Adapter_Pdo_Mysql\\:\\:\\$_cacheAdapter \\(Zend_Cache_Core\\) does not accept Zend_Cache_Backend_Interface\\.$#" count: 1 @@ -7575,11 +5070,6 @@ parameters: count: 1 path: lib/Varien/Db/Adapter/Pdo/Mysql.php - - - message: "#^Unreachable statement \\- code above always terminates\\.$#" - count: 1 - path: lib/Varien/Db/Adapter/Pdo/Mysql.php - - message: "#^Cannot call method bindParam\\(\\) on object\\|resource\\.$#" count: 1 @@ -7665,21 +5155,6 @@ parameters: count: 1 path: lib/Varien/Image/Adapter/Gd2.php - - - message: "#^Result of \\|\\| is always true\\.$#" - count: 1 - path: lib/Varien/Image/Adapter/Gd2.php - - - - message: "#^If condition is always true\\.$#" - count: 1 - path: lib/Varien/Io/File.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 8 - path: lib/Varien/Io/File.php - - message: "#^Access to an undefined property Varien_Object_Cache\\:\\:\\$_referencesByObject\\.$#" count: 1 @@ -7690,11 +5165,6 @@ parameters: count: 1 path: lib/Varien/Object/Cache.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: lib/Varien/Object/Cache.php - - message: "#^Offset 'function' on array\\{function\\: string, line\\?\\: int, file\\?\\: string, class\\?\\: class\\-string, type\\?\\: '\\-\\>'\\|'\\:\\:', args\\?\\: array, object\\?\\: object\\} in isset\\(\\) always exists and is not nullable\\.$#" count: 1 @@ -7751,6 +5221,6 @@ parameters: path: lib/Varien/Simplexml/Config.php - - message: "#^Strict comparison using \\=\\=\\= between string and false will always evaluate to false\\.$#" + message: "#^Strict comparison using \\=\\=\\= between mixed and false will always evaluate to false\\.$#" count: 1 path: lib/Varien/Simplexml/Config.php diff --git a/phpstan.dist.issues.neon b/phpstan.dist.issues.neon index 8eaf45ae702f..6bbad89042e2 100644 --- a/phpstan.dist.issues.neon +++ b/phpstan.dist.issues.neon @@ -2,9 +2,6 @@ parameters: ignoreErrors: # Level 2 - "#Variable \\$+[a-zA-Z_]+ might not be defined.#" - - - message: "#Call to function is_null\\(\\) with Mage_Core_Model_Store will always evaluate to false.$#" - path: app/code/core/Mage/Adminhtml/Block/Customer/Edit/Tab/Account.php - message: "#Call to function is_null\\(\\) with bool will always evaluate to false.$#" path: app/code/core/Mage/Newsletter/Model/Subscriber.php @@ -14,6 +11,3 @@ parameters: - message: "#Call to function is_null\\(\\) with string will always evaluate to false.$#" path: lib/Mage/HTTP/Client/Socket.php - - - message: "#Call to function is_null\\(\\) with string will always evaluate to false.$#" - path: lib/Varien/Convert/Parser/Xml/Excel.php