Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Streaming Response #271

Closed
leifg opened this issue Dec 18, 2018 · 3 comments · May be fixed by #498
Closed

Streaming Response #271

leifg opened this issue Dec 18, 2018 · 3 comments · May be fixed by #498
Labels
feature ✨ good first issue

Comments

@leifg
Copy link

leifg commented Dec 18, 2018

According to the README, Tesla supports streaming if the underlying adapter supports it.

From the code and the examples I found it seems though that streaming means in this instance, streaming of the request.

I am interested in how I would be able to stream the response of a request (very useful for something like large downloads).

Is this supported, if so: how?
@teamon teamon added the question label Jan 3, 2019
@teamon
Copy link
Member

teamon commented Jan 3, 2019

Unfortunately streaming response body is not implemented, but it could be done.
I can imagine something like:

case Tesla.get(client, "/stream", stream_response: true) do
  {:ok, env} -> # on successful read of status & headers env.body is a Stream
  {:error, reason} -> # ...
end

@thojanssens thojanssens mentioned this issue May 23, 2020
Closed
@teamon teamon mentioned this issue Mar 24, 2021
Closed
@tim-smart tim-smart mentioned this issue Oct 29, 2021
Open
@teamon teamon added this to Roadmap May 8, 2022
@teamon teamon moved this to Todo in Roadmap May 8, 2022
@teamon
Copy link
Member

teamon commented May 8, 2022

I'd go with Tesla.get(client, "/path", response: :stream) (instead of stream_response: true)

@teamon teamon linked a pull request May 8, 2022 that will close this issue
Add stream_response option to hackney adapter #498
Open
@teamon teamon moved this from Todo to In Progress in Roadmap May 8, 2022
@teamon teamon mentioned this issue Aug 24, 2022
Merged
@mruoss mruoss mentioned this issue Jan 18, 2023
Open
@mwhitworth mwhitworth mentioned this issue Feb 24, 2024
Closed
@teamon
Copy link
Member

teamon commented Apr 11, 2024

Response streaming added for Finch in https://github.com/elixir-tesla/tesla/releases/tag/v1.9.0

@teamon teamon closed this as completed Apr 11, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Roadmap Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature ✨ good first issue
Projects
Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add stream_response option to hackney adapter arisechurch/tesla
2 participants
@teamon @leifg