[Bug] regression for example

[phanirithvij]

Bug reports

As I mentioned here, c-bata#212 (comment)

Expected Behavior

The new example should work normally, tabbing should switch, tab character should not be insterted in the text.

Current Behavior and Steps to Reproduce

Steps:

• get the example from c-bata/go-prompt readme build and run unchanged
• get the example from elk-language/go-prompt, build and run unchanged
• compare
• see gif below

Gif

Context

• Operating System: linux, manjaro, tmux (also reproduced without tmux)
• Terminal Emulator: (i.e. iTerm2) alacritty (also tried on Konsole same issue)
• tag of go-prompt or commit revision: elk-language/go-prompt latest version v1.1.5 and c-bata/go-prompt latest version v0.2.6

[Verseth]

Thanks for reporting the bug.
The thing that surprises me is that _example/http-prompt works properly while being almost identical to _example/simple-echo which has this bug.

I'll look into it and try to fix it.

[phanirithvij]

http-prompt also accepts tab as a valid input

[Verseth]

That alone doesn't constitute a regression. This was changed on purpose.
When no suggestions are available and you press tab, it should be inserted as two spaces (by default, you can configure the amount of spaces for a single tab).

[phanirithvij]

That doesn't behave like any shell I know, it is becoming a text editor then.
Is it possible to disable this behavior then?

[Verseth]

That's because I intended to make it suitable for building interactive text-editor-like REPLs like ipython, I didn't intend to make it work like a basic shell.

But you're right, this behaviour should be configurable.
It's not possible to disable it right now, but I'll add it in the next patch, together with the bugfix.