Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code cleanup: local buffer #320

Closed
fako1024 opened this issue May 25, 2024 · 0 comments · Fixed by #321
Closed

Code cleanup: local buffer #320

fako1024 opened this issue May 25, 2024 · 0 comments · Fixed by #321
Assignees
@fako1024

Comments

@fako1024
Copy link
Collaborator

Currently, the shared local buffer is implemented as global object for the whole capture package, which is not only crude but also might introduce unwanted side effects. Instead, it should be made a field / object of the CaptureManager, with a valid default and a functional option to inject it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fako1024 fako1024

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[feature] Refactor local buffer / memory pool handling for CaptureManager els0r/goProbe
1 participant
@fako1024