Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Elsa2: Why Elsa.Models.WorkflowPersistenceBehavior enum doesn't have WorkflowPassCompleted #4478

Open
NightinGale997 opened this issue Sep 25, 2023 · 2 comments
Open

Elsa2: Why Elsa.Models.WorkflowPersistenceBehavior enum doesn't have WorkflowPassCompleted #4478

NightinGale997 opened this issue Sep 25, 2023 · 2 comments
Labels
elsa 2

Comments

@NightinGale997
Copy link

In Elsa.Abstractions there is enum for serialization of existing workflows in blob storage. I couldn't change their persistBehavior to WorkflowPassCompleted and then saw that there is no WorkflowPassCompleted.
@NightinGale997 NightinGale997 changed the title Why Elsa.Models.WorkflowPersistenceBehavior enum doesn't have WorkflowPassCompleted Elsa2: Why Elsa.Models.WorkflowPersistenceBehavior enum doesn't have WorkflowPassCompleted Sep 25, 2023
@sfmskywalker
Copy link
Member

Hi @NightinGale997 , I'm not sure actually. It does sound like it would make sense to have the WorkflowPassCompleted behavior as well.

If you want to add it back, I'd welcome a PR.

@NightinGale997
Copy link
Author

I'm pleased to do that. #4480

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
elsa 2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sfmskywalker @NightinGale997