Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Compatibility Problem with Workflow Context Providers in Upgrade from 3.0.5 to 3.2 #5827

Closed
sfmskywalker opened this issue Jul 24, 2024 · 1 comment · Fixed by #5861
Assignees
Labels
bug Something isn't working
Milestone

Comments

@sfmskywalker
Copy link
Member

When running Elsa Workflows version 3.0.5 in a production environment, there is a consideration to upgrade to version 3.2. The primary concern involves several workflow definitions that utilize workflow context providers, specifically leveraging CustomProperties.

In version 3.2, the mechanism for saving workflow context providers has been changed from CustomProperties to PropertyBag. This change presents potential issues for existing workflows.

Steps to Reproduce

  1. Use Elsa Workflows 3.0.5 with workflow definitions that utilize CustomProperties.
  2. Upgrade to Elsa Workflows 3.2.
  3. Attempt to use the existing workflow definitions and observe the behavior related to workflow context providers.

Expected Behavior

Existing workflow instances should end correctly after the upgrade, and the workflow context provider configurations should remain functional.

Actual Behavior

There is a potential for suspended instances to not end correctly and for configurations to break due to changes from CustomProperties to PropertyBag.

Additional Information

  • Current Elsa Workflows version: 3.0.5
  • Target Elsa Workflows version: 3.2
  • Workflow definitions use CustomProperties
@sfmskywalker sfmskywalker added the bug Something isn't working label Jul 24, 2024
@sfmskywalker sfmskywalker added this to the Elsa 3.2 milestone Jul 24, 2024
@sfmskywalker sfmskywalker self-assigned this Jul 25, 2024
@sfmskywalker
Copy link
Member Author

Fixed via #5861

@sfmskywalker sfmskywalker linked a pull request Aug 6, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant