Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The parameter "clientToken" is NOT required in authlib-injector documentation #35

Closed
allMagicNB opened this issue Nov 24, 2024 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@allMagicNB
Copy link

The parameter "clientToken" is NOT required in authlib-injector documentation, but it is required in Ely.by.

@erickskrauch
Copy link
Member

Could you please explain the problem with some links and more details?

@erickskrauch
Copy link
Member

I believe we've made the implementation in such a way because the Mojang were doing so. Without the clientToken you won't be able to refresh the token later. Right now there is no way to check the official implementation since it's disabled. But I see that this behavior is declared for authlib-injector's routes, so I this we must implement it too.

@allMagicNB
Copy link
Author

allMagicNB commented Nov 24, 2024

Like this: Hex-Dragon/PCL2#5135.

@allMagicNB
Copy link
Author

wiki.vg: https://wiki.vg/Legacy_Mojang_Authentication#Authenticate

@erickskrauch erickskrauch added the bug Something isn't working label Nov 24, 2024
@erickskrauch erickskrauch self-assigned this Nov 24, 2024
@erickskrauch
Copy link
Member

@allMagicNB, the requested changes have been implemented and deployed. Thank you for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants