rename not working

[rileyrg]

rename doesn't seem to work properly - it doesn't recognise accessors/getters or the member data within them. eg here I rename member variable $logger to $_logger both locally and "in file" - neither correctly updates the logger() method.

Here I tried renaming from the declaration. Trying to rename from an "$this->logger" results in:-

user-error: Expected Variable or Parameter node, got
"Microsoft\PhpParser\Node\Expression\MemberAccessExpression"

Possibly the worst problem though is renaming a member variable that has parameters named after it. eg here I rename member var "cache" to "cache2" and it renames method parameters in that class and not the actual member variable usages.

[zonuexe]

@rileyrg Thanks for the report.

However, this problem is due upstream (Phpactor and Tolerant PHP Parser). Submitting minimal code that reproduces this problem will help us resolve the cause.

[rileyrg]

There is no code. Its simply trying to rename using the php actor interface. See screenshot. The second part suggests a real issue.