breaks locationType: "auto"

[rlivsey]

Just upgraded to master and locationType "auto" is ignored and gets set to "hash" for some reason.

The only change I made was upgrading, then downgrading back to 0.8.4 fixed it but @ef4 notes in #69 that it doesn't happen in a fresh app so I'll dig a little deeper.

[rlivsey]

I just replicated it in a new ember-cli app (0.0.46).

Here's the repo: https://github.com/rlivsey/liquid-fire-test

There's a console.log in router.js which just outputs the ember config. Note that it contains locationType: "hash".

If you remove liquid-fire (see/clone the without branch) then restart you'll see it is now locationType: "auto".

The only difference between these is the inclusion of liquid-fire.

I'll dig some more and see if I can figure out what commit causes it.

[ef4]

Thanks, with that repo I can reproduce.

[ef4]

The locationType value from liquid-fire's own config/environment.js is leaking through. I'm going to file an ember-cli bug and see what they say.

[ef4]

(Looks like it may be an intentional feature now that addons can export config, but it still seems wrong that the addon would be able to override the application.)

[rlivsey]

read my mind, was just in the process of testing that out!

[rlivsey]

Just confirmed that's definitely the issue.

See forked branch of the repo which uses a fork of liquid-fire with the config changed.

Cheers.

[rwjblue]

I submitted #75 to fix the immediate issue, but am also looking to figure out how/why the addon's config was overriding the applications config (app should ALWAYS win).

[rwjblue]

Thanks for reporting this on ember-cli, there was definitely a bug that allowed the addon to override application config. ember-cli/ember-cli#2133 fixes the underlying problem.