Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update terser to v3.10.8 #93

Merged
merged 2 commits into from
Nov 22, 2018
Merged

Update terser to v3.10.8 #93

merged 2 commits into from
Nov 22, 2018

Conversation

msz
Copy link
Contributor

@msz msz commented Nov 1, 2018

Closes #72
Closes #90

We've encountered a terser bug which crashed the uglification process of our vendor.js. Upgrading the version fixed it, but we currently need to use custom forks of ember-cli-uglify and broccoli-uglify-sourcemap, so I suggest merging this upstream.

This will also fix #72.

@Turbo87
Copy link
Member

Turbo87 commented Nov 22, 2018

but we currently need to use custom forks of ember-cli-uglify and broccoli-uglify-sourcemap, so I suggest merging this upstream.

I don't see why you need to use any forks. We use a caret constraint for the terser dependency, so if you install from scratch you should get the latest version of it.

@Turbo87 Turbo87 changed the title bump terser to 3.10.8 Update terser to v3.10.8 Nov 22, 2018
@Turbo87 Turbo87 merged commit 2aa86b4 into ember-cli:master Nov 22, 2018
@Turbo87 Turbo87 added the dependencies Pull requests that update a dependency file label Nov 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move to terser breaks the order of yield in generators
2 participants