Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use EMBER_CLI_INJECT_LIVE_RELOAD_BASEURL in the injected script #30

Closed
Emerson opened this issue Jul 7, 2016 · 1 comment
Closed

Use EMBER_CLI_INJECT_LIVE_RELOAD_BASEURL in the injected script #30

Emerson opened this issue Jul 7, 2016 · 1 comment

Comments

@Emerson
Copy link

Emerson commented Jul 7, 2016

    return "(function() {\n " +
           "var src = (location.protocol || 'http:') + '//' + (location.hostname || 'localhost') + ':" + liveReloadPort + "/livereload.js?snipver=1';\n " +
           "var script    = document.createElement('script');\n " +
           "script.type   = 'text/javascript';\n " +
           "script.src    = src;\n " +
           "document.getElementsByTagName('head')[0].appendChild(script);\n" +
           "}());";

Certainly possible I'm missing something, but I suspect the dynamic script we are loading should be using the same baseURL that's defined in the EMBER_CLI_INJECT_LIVE_RELOAD_BASEURL environment variable.

Feel free to close this if I'm wrong 👍

@lukemelia
Copy link
Contributor

In master, this is now independently configurable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants