This repository has been archived by the owner on Dec 10, 2024. It is now read-only.
Remove blueprints #123
Merged
Remove blueprints #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
force-pushed
the
remove-blueprints
branch
2 times, most recently
from
c528e8e to
96a0227
Compare
|
@rwjblue any comments? |
|
now that this is an |
Turbo87
force-pushed
the
remove-blueprints
branch
from
96a0227 to
f04fb63
Compare
They have been moved into "ember-core", "ember-data" and "ember-cli-legacy-blueprints"
|
LGTM |
|
👍 |
|
YESSS. 😛 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These blueprints have been moved into ember.js, ember-data and ember-cli-legacy-blueprints.
Merging this will require a major version bump (actually only a minor since we're still sub-1.0), but due to the JSHint removal that is necessary anyway.
This PR resolves #120, resolves #121 and obsoletes #81 and #118.
/cc @rwjblue