Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for ariaRole property of the JS class #49

Closed
jelhan opened this issue Jan 15, 2020 · 3 comments · Fixed by #51
Closed

Support for ariaRole property of the JS class #49

jelhan opened this issue Jan 15, 2020 · 3 comments · Fixed by #51
Labels
enhancement New feature or request

Comments

@jelhan
Copy link
Contributor

jelhan commented Jan 15, 2020 

export default Component.extend({
  ariaRole: "button",
});

should be converted to

<div role="button"></div>
@Turbo87
Copy link
Contributor

Turbo87 commented Jan 15, 2020

hmm, why? do Ember components do this by default?

@jelhan
Copy link
Contributor Author

jelhan commented Jan 15, 2020 •
edited
Loading

@ember/component have a ariaRole property that does this. The API of @ember/component's is huge. 😱

@Turbo87
Copy link
Contributor

Turbo87 commented Jan 15, 2020

huh, I've never seen that before 😅

@jelhan jelhan mentioned this issue Jan 16, 2020
Merged
@simonihmig simonihmig added the enhancement New feature or request label Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for ariaRole property jelhan/tagless-ember-components-codemod
3 participants
@Turbo87 @simonihmig @jelhan