Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guide for importing-inject-from-ember-service deprecation #1336

Merged

Conversation

bertdeblock
Copy link
Contributor

@netlify
Copy link

netlify bot commented Aug 18, 2023

Deploy Preview for ember-deprecations ready!

Name Link
🔨 Latest commit ecd5e5e
🔍 Latest deploy log https://app.netlify.com/sites/ember-deprecations/deploys/67570967aaff480007442d56
😎 Deploy Preview https://deploy-preview-1336--ember-deprecations.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@IgnaceMaes
Copy link
Member

Content looks good, but I believe we'll need a new folder for Ember v6 deprecations.

@bertdeblock
Copy link
Contributor Author

Woops, didn't notice the v5 folder when reopening. Made this one a while ago.

@bertdeblock bertdeblock force-pushed the importing-inject-from-ember-service branch from accd979 to 70dee01 Compare December 9, 2024 12:48
@IgnaceMaes IgnaceMaes force-pushed the importing-inject-from-ember-service branch from 70dee01 to e0c458e Compare December 9, 2024 14:30
@IgnaceMaes
Copy link
Member

Why are the tests failing 🤔

@mansona
Copy link
Member

mansona commented Dec 9, 2024

The tests are failing because of the node tests (specifically because of the markdown validation):

  1) Json Tests
       ember/v6/importing-inject-from-ember-service.md is ok:
     Error: You don't need to define a displayId if it's the same as the file name
      at Context.<anonymous> (file:///home/runner/work/deprecation-app/deprecation-app/node-tests/index.mjs:23:15)
      at process.processImmediate (node:internal/timers:478:21)

@IgnaceMaes
Copy link
Member

Aha thanks, I missed the failed test from the logs above. (as the last one did succeed)

@IgnaceMaes
Copy link
Member

And thanks @bertdeblock for the contribution 😄

@IgnaceMaes IgnaceMaes merged commit 90f0321 into ember-learn:main Dec 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants