-
-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add guide for importing-inject-from-ember-service
deprecation
#1336
Add guide for importing-inject-from-ember-service
deprecation
#1336
Conversation
✅ Deploy Preview for ember-deprecations ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
5caced2
to
accd979
Compare
Content looks good, but I believe we'll need a new folder for Ember v6 deprecations. |
Woops, didn't notice the v5 folder when reopening. Made this one a while ago. |
accd979
to
70dee01
Compare
70dee01
to
e0c458e
Compare
Why are the tests failing 🤔 |
The tests are failing because of the node tests (specifically because of the markdown validation):
|
Aha thanks, I missed the failed test from the logs above. (as the last one did succeed) |
And thanks @bertdeblock for the contribution 😄 |
emberjs/ember.js#20526