Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isSaving stays true after 422 response #2638

Closed
mxrguspxrt opened this issue Dec 29, 2014 · 5 comments
Closed

isSaving stays true after 422 response #2638

mxrguspxrt opened this issue Dec 29, 2014 · 5 comments

Comments

@mxrguspxrt
Copy link

For me it not expected behaviour - I would like to use isError or isDirty, because save action had return from server.

@igorT
Copy link
Member

igorT commented Dec 30, 2014

Could you write a failing test please?

@wecc
Copy link
Contributor

wecc commented Dec 30, 2014

I did a bit of research on this and it seems like this line causes Uncaught TypeError: Cannot assign to read only property '__reason_with_error_thrown__' of OK in Chrome and TypeError: Attempted to assign to readonly property. in Safari.

It's easily reproduceable on Chrome 39.0.2171.95 even without Ember Data (just mimicking RESTAdapter.ajaxError()), see this JSBin.

Might be caused by https://bugs.webkit.org/show_bug.cgi?id=49739

ping @stefanpenner

@wecc
Copy link
Contributor

wecc commented Jan 14, 2015

@mxrguspxrt would you be able to test using Ember canary? emberjs/ember.js#10215 from @bmac should most likely solve this.

@wecc
Copy link
Contributor

wecc commented Jan 14, 2015

Sorry, the PR above won't fix this but #2697 most likely will, my bad :)

@wecc
Copy link
Contributor

wecc commented Jan 22, 2015

@mxrguspxrt #2697 has been merged, could this be closed?

@bmac bmac closed this as completed Jan 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants