Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

recordArray param no longer available in query #5076

Closed
mikkopaderes opened this issue Jul 20, 2017 · 4 comments
Closed

recordArray param no longer available in query #5076

mikkopaderes opened this issue Jul 20, 2017 · 4 comments

Comments

@mikkopaderes
Copy link

mikkopaderes commented Jul 20, 2017 •
edited
Loading

I believe it's related to #4947 but I'm not sure if it's intentional.

My use case is that I have an adapter that currently sets a Firebase listener to mutate that recordArray on record changes at the start of the query.

Before I go off to find another solution, I just wanted to make sure that the removal of recordArray is intentional? Seeing that it's a public API, I would've thought that there should've been some deprecation.

EDIT:

This is for 2.15+ btw.
This was referenced Jul 21, 2017
Merged
Open
@mikkopaderes
Copy link
Author

mikkopaderes commented Jul 29, 2017 •
edited
Loading

@stefanpenner, could you confirm this? I believe your PR #4947 is connected to this issue.

@pangratz
Copy link
Member

pangratz commented Oct 7, 2017

Just to add more context, I recall another discussion about the recordArray param for query in #4610...

@pangratz
Copy link
Member

pangratz commented Oct 7, 2017

ping @stefanpenner

@runspired
Copy link
Contributor

The issue here was recently fixed by #5345

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pangratz @runspired @mikkopaderes