Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@ember/ordered-set interop with ember-source@3.5 #5556

Closed
rwjblue opened this issue Aug 6, 2018 · 2 comments
Closed

@ember/ordered-set interop with ember-source@3.5 #5556

rwjblue opened this issue Aug 6, 2018 · 2 comments
Assignees

Comments

@rwjblue
Copy link
Member

rwjblue commented Aug 6, 2018

When ember-data (emberjs/data#4e0bc45) is used with ember-source 3.5 (current canary emberjs/ember.js#04dec4f9) the following error occurs:

image 2

Reported in slack by @NullVoxPopuli.


When ember-source hits 3.5 we no longer are leveraging @ember/ordered-set from Ember itself (see here), and instead we are using the version in the addon.

The error occurs because we are mixing native classes (because the implementation in the addon does not get transpiled) and ES5 style classes.

@runspired
Copy link
Contributor

Fixed in #5557

@NullVoxPopuli
Copy link
Contributor

/giphy party time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants