Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: restore type checks and lint on tests #9041

Closed
runspired opened this issue Oct 23, 2023 · 2 comments · Fixed by #9054 or #9101
Closed

chore: restore type checks and lint on tests #9041

runspired opened this issue Oct 23, 2023 · 2 comments · Fixed by #9054 or #9101
Assignees
@gitKrystan
Labels
🏷️ chore This PR primarily refactors code or updates dependencies

Comments

@runspired
Copy link
Contributor

as part of splitting out into per-package lint and types compilation in #9032 we removed the global versions of these things, which means tests are no longer linted or type checked. We need to bring this back.
@runspired runspired added the 🏷️ chore This PR primarily refactors code or updates dependencies label Oct 23, 2023
@gitKrystan
Copy link
Contributor

I'm it

@runspired runspired linked a pull request Oct 26, 2023 that will close this issue
Initial lint config for tests/blueprints #9054
Merged
@runspired runspired mentioned this issue Oct 26, 2023
Merged
@gitKrystan gitKrystan reopened this Nov 3, 2023
@runspired runspired mentioned this issue Nov 15, 2023
Merged
@gitKrystan
Copy link
Contributor

Done

#9125

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gitKrystan gitKrystan

Labels
🏷️ chore This PR primarily refactors code or updates dependencies
Projects
EmberData
Archived in project
Milestone
No milestone
2 participants
@runspired @gitKrystan