-
-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
configurable-file-extensions: Shadowing addon files doesn't always work #240
Comments
I have the suspicion that this is actually caused by my overrides having a I changed the file extension of all override files from I'll get back to you once we have more certainty or another failure. |
Okay, so I am now 💯 certain, that this is caused by having overrides with a As far as I understand the plan with ember-cli-typescript is to move into the direction of using ember-cli-babel to do the compilation, so I guess this is an issue we need to fix? |
Yep, addons' With MU this issue goes away (since there's no longer any merging like that), but in the interim it's likely to be annoying. I could imagine updating |
Cross-posting from #topic-typescript, so it doesn't get lost:
I noticed a peculiar problem with #140. I’m shadowing / clobbering files in the
app
directory provided by addons. For example, ember-intl re-exports theintl
service andt
helper in theirapp
directory. I’m shadowing these with my own compatibility layerintl
service andt
helper. I’m doing the exact same thing to thefeatures
service of ember-feature-flags. This used to work reliably with ember-cli-babel 6.But now it seems that sometimes this shadowing does not work and the addon-provided files “leak through”. I’m also unable to find my override file in the Chrome Dev Tools. Triggering a re-build on the “missing” file by
touch
ing it fixes the problem.Does it maybe have something to do with parallelization?
Concretely what happened is that my
t
helper was sometimes missing and the ember-intl one leaked through. Same happened to thefeatures
service.One side-note: I’m using my #236 branch to process
.ts
files.This might be part of the cause.
The text was updated successfully, but these errors were encountered: