From 590b008692d45f8dc22d83e4dac70694e4a6893c Mon Sep 17 00:00:00 2001 From: Robert Jackson Date: Mon, 8 Jun 2020 12:08:22 -0400 Subject: [PATCH] Ensure docs use `require.resolve` for custom plugins If you don't use `require.resolve`, it is quite easy to be trolled by resolving a different version of a given plugin than you expect. --- README.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index 3ceba744..b1014ddb 100755 --- a/README.md +++ b/README.md @@ -68,7 +68,7 @@ let app = new EmberApp({ 'transform-regenerator', ], plugins: [ - 'transform-object-rest-spread' + require.resolve('transform-object-rest-spread') ] } }); @@ -138,7 +138,7 @@ rest/spread syntax, you would do something like this in an app: // ember-cli-build.js let app = new EmberApp(defaults, { babel: { - plugins: ['transform-object-rest-spread'] + plugins: [require.resolve('transform-object-rest-spread')] } }); ``` @@ -148,7 +148,7 @@ In an engine: // index.js module.exports = EngineAddon.extend({ babel: { - plugins: ['transform-object-rest-spread'] + plugins: [require.resolve('transform-object-rest-spread')] } }); ``` @@ -159,7 +159,7 @@ In an addon: module.exports = { options: { babel: { - plugins: ['transform-object-rest-spread'] + plugins: [require.resolve('transform-object-rest-spread')] } } };